diff options
author | Stephen Hines <srhines@google.com> | 2016-12-02 15:57:53 -0800 |
---|---|---|
committer | Stephen Hines <srhines@google.com> | 2016-12-05 13:52:33 -0800 |
commit | 672acdeb3c63987a9a778dbcc84fe74e0fb4a5db (patch) | |
tree | af9cdd571dd42c097972abcf9da666d0b2ff6266 /firmware/os/algos | |
parent | 5c959ba05eccbe76434b538dfc092afdf8f6cbbc (diff) | |
download | contexthub-672acdeb3c63987a9a778dbcc84fe74e0fb4a5db.tar.gz |
Refactor to eliminate taking the address of a packed member.
Bug: http://b/31532493
NanoHub::doRun() was previously taking the address of msg.hdr.app_name,
which isn't allowed, as it could possibly be misaligned. In fact,
looking at the data structure layout of the packed, nested structs,
app_name (a struct containing only a single uint64_t) will always be
packed immediately after a uint32_t. No matter what alignment we want to
apply to the main struct, we will never end up with an aligned uint64_t.
To address this, we merely switch to copying the uint64_t directly,
rather than passing it as a pointer.
Test: Built successfully with latest compilers.
Change-Id: Iecf67cb10a0f5e2b8ceb6363e0c4a9b927d1bfa9
Diffstat (limited to 'firmware/os/algos')
0 files changed, 0 insertions, 0 deletions