From 7603fcafe065ee99456fbcf8cf742a433bc870a4 Mon Sep 17 00:00:00 2001 From: Abhijeet Kaur Date: Fri, 2 Aug 2019 15:41:37 +0100 Subject: Remove notifications from bugreport generation using combo keys In Q, we added a new bugreport API that asks for user consent before showing the "Share" notification for the bugreport. We will be migrating all bugreporting clients to use the API in R. In the new API workflow we are moving away from broadcasts and using callbacks to communicate with dumpstate. Finished bugreport notification broadcast used to share the final path of the bugreport but API now uses file descriptors instead. Hence, moving away from broadcasts. The full bugreport in this case can be retrieved from dumpstate directory using 'adb pull' or finding and attaching the file directly to gmail or betterbug. Remove outputfile flag since it's unused. Bug: 135186519 Bug: 137825702 Test: Build and flash to the device. Create a bugreport using combo keys, share notification does not pop up. Full bugreport created in bugreports/ dir Change-Id: I380e11d6494d7241f2911df4bd2e1c50395195f2 --- init.common.rc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/init.common.rc b/init.common.rc index 04783a8a..d4f48e84 100644 --- a/init.common.rc +++ b/init.common.rc @@ -119,8 +119,7 @@ service watchdogd /system/bin/watchdogd 10 20 oneshot seclabel u:r:watchdogd:s0 -service bugreport /system/bin/dumpstate -d -p -B -z \ - -o /data/user_de/0/com.android.shell/files/bugreports/bugreport +service bugreport /system/bin/dumpstate -d -p -z class main disabled oneshot -- cgit v1.2.3