summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYifan Hong <elsk@google.com>2022-09-15 15:09:38 -0700
committerYifan Hong <elsk@google.com>2022-09-15 22:19:02 +0000
commit4390841817357d6876ab141b5f4912851fa5ac8f (patch)
tree88e9a7fb7091cfcd2f4b8d063624b8ac75e2ae87
parent43800e02dfe9e4d179f587e2443b188f63393b12 (diff)
downloadbuild-4390841817357d6876ab141b5f4912851fa5ac8f.tar.gz
kleaf: Fix kernel_module.outs = None failure
_kernel_module_set_defaults sets the defaults in kwargs but it doesn't mutate the original local variable outs. Test: TH Change-Id: Ib5929ccc51a2fa225f779c64d24da9fba405c5c4
-rw-r--r--kleaf/impl/kernel_module.bzl2
1 files changed, 1 insertions, 1 deletions
diff --git a/kleaf/impl/kernel_module.bzl b/kleaf/impl/kernel_module.bzl
index 0da71de..e5a0c4d 100644
--- a/kleaf/impl/kernel_module.bzl
+++ b/kleaf/impl/kernel_module.bzl
@@ -162,7 +162,7 @@ def kernel_module(
sibling_kwargs = dict(kwargs)
sibling_target_name = name + "_" + sibling_name
sibling_kwargs["name"] = sibling_target_name
- sibling_kwargs["outs"] = ["{sibling_target_name}/{out}".format(sibling_target_name = sibling_target_name, out = out) for out in outs]
+ sibling_kwargs["outs"] = ["{sibling_target_name}/{out}".format(sibling_target_name = sibling_target_name, out = out) for out in sibling_kwargs["outs"]]
# This assumes the target is a kernel_build_abi with define_abi_targets
# etc., which may not be the case. See below for adding "manual" tag.