summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-06-15Revert "Revert "drm:samsung: add histogram_always_on support""android-u-beta-5.3_r0.7android-u-beta-5.3_r0.5android-u-beta-5.3_r0.4android-u-beta-5.3_r0.2android-u-beta-5.3_r0.1android-u-beta-4_r0.4android-u-beta-4_r0.3android-u-beta-4_r0.2android-14.0.0_r0.7android-14.0.0_r0.6android-14.0.0_r0.5android-14.0.0_r0.4android-14.0.0_r0.3android-14.0.0_r0.2android-gs-tangorpro-5.10-u-beta5.3android-gs-tangorpro-5.10-android14android-gs-raviole-5.10-u-beta5.3android-gs-raviole-5.10-android14android-gs-pantah-5.10-u-beta5.3android-gs-pantah-5.10-u-beta4android-gs-pantah-5.10-android14android-gs-lynx-5.10-u-beta4android-gs-lynx-5.10-android14android-gs-felix-5.10-u-beta5.3android-gs-felix-5.10-u-beta4android-gs-felix-5.10-android14android-gs-bluejay-5.10-u-beta5.3android-gs-bluejay-5.10-android14Leo Chen
This reverts commit 10257b6c36f6aa404385dbd72ea69b865e9fb5f4. Reason for revert: flaky test as mentioned in b/285587335#comment22 Bug: 261376040 Change-Id: I277fcc417968b9fa3ae755dd2ca33fc3d723a108 Signed-off-by: Leo Chen <yinchiuan@google.com>
2023-06-08Revert "drm:samsung: add histogram_always_on support"android-u-beta-4_r0.7android-u-beta-4_r0.5android-u-beta-4_r0.1android-gs-tangorpro-5.10-u-beta4android-gs-raviole-5.10-u-beta4android-gs-bluejay-5.10-u-beta4Oleg Matcovschi
This reverts commit f3deb4be40c0d55b5c676c47acb65d8605111a5f. Reason for revert: b/285587335 Bug: 285587335 Signed-off-by: Oleg Matcovschi <omatcovschi@google.com> Change-Id: I959256cc689a75fe1ed96cedead254a6a6da7218
2023-05-31drm:samsung: add histogram_always_on supportOleg Matcovschi
Changes: * track histogram engine status via simple state machine. * preserve histogram_bins data when required. * immediate return cached histogram data in context of histogram_request ioctl whenever possible. Note, histogram is enabled as long as DRM histogram properties are valid. Bug: 261376040 Change-Id: Iadc71d6af32651b760194156ce902e0b47fc2d8b Signed-off-by: Oleg Matcovschi <omatcovschi@google.com>
2023-05-24panel: s6e3hc4: use fixed TE in AOD modeChris Lu
Set fixed TE to have a consistent TE frequency (30Hz) in AOD mode. Bug: 281917185 Test: capture trace, signal measurement, AOD in/out Change-Id: I7850d1bf9941f00dcb08fbc176784030a5c4bfde Signed-off-by: Chris Lu <luchris@google.com>
2023-05-19drm: samsung: add trace for frame transferChris Lu
Add the trace which will be changed according to frame start and frame done IRQs. Bug: 283419973 Test: capture the trace and check "frame_transfer" Change-Id: I90417482fcba520f068b0cbb681528939b3dcf5c Signed-off-by: Chris Lu <luchris@google.com> (cherry picked from commit a32af6fcb0950c573fc2bfd3d6de53cf4bde02df)
2023-05-09drm: samsung: trigger emergency reboot if fail to set PLL_ENandroid-u-beta-3_r0.3android-u-beta-3_r0.2android-u-beta-2.1_r0.4android-u-beta-2.1_r0.3android-u-beta-2.1_r0.2android-gs-raviole-5.10-u-beta3android-gs-raviole-5.10-u-beta2android-gs-pantah-5.10-u-beta2android-gs-bluejay-5.10-u-beta3android-gs-bluejay-5.10-u-beta2Ken Huang
Scandump doesn't record the right timing after receiving itmon error. Trigger emergency reboot to ensure the issue timing. Bug: 279094593 Test: trigger ramdump by hard code Change-Id: I3da1f5febd335de8ffaf472b7fb27ff5c76ba61e Signed-off-by: Ken Huang <kenbshuang@google.com>
2023-05-08display: s6e3hc4: show idle refresh rate in AOD modeLeo Chen
The refresh rate indicator reads the sysfs node of display state, and the state shows the actual refresh rate according to whether panel idle refresh rate is set. This change sets idle refresh rate to 10 in AOD mode so that the indicator can show correct refresh rate. Bug: 273577459 Test: cat sys/class/backlight/panel0-backlight/state while AOD Change-Id: I5b023fd5a4f177c99bf2ea2cd36930d4b020ae19 Signed-off-by: Leo Chen <yinchiuan@google.com> (Cherry picked from commit c18b655dde3e58c7c5274fc5420753557795c3c5)
2023-05-08display: nt37290: show idle refresh rate in AOD modeLeo Chen
The refresh rate indicator reads the sysfs node of display state, and the state shows the actual refresh rate according to whether panel idle refresh rate is set. This change sets idle refresh rate to 10 in AOD mode so that the indicator can show correct refresh rate. Bug: 273577459 Test: cat sys/class/backlight/panel0-backlight/state while AOD Change-Id: If8fb450caf5b12913d43ae2281bdeaa04ff77394 Signed-off-by: Leo Chen <yinchiuan@google.com> (Cherry picked from commit c18b655dde3e58c7c5274fc5420753557795c3c5)
2023-05-05Revert "Revert "panel: predict nearest te timestamp for mipi sync timing if ↵Midas Chien
possible"" This reverts commit e302f182ae12d5d5ce8cec93e5aefe8dfb4c866d. Bug: 280727794 Test: refresh rate switch, LHBM Change-Id: I1372996beaade519e49a6256b91c273c43bde4d2 Signed-off-by: Midas Chien <midaschieh@google.com>
2023-05-04drm: samsung: improve debug log for sysmmu fault issueKen Huang
Bug: 278834131 Test: trigger sysmmu fault and check last kmsg Change-Id: I809763e39b0441c545f65bbbb8c3bed87a92317c Signed-off-by: Ken Huang <kenbshuang@google.com>
2023-05-03Revert "panel: s6e3hc4: update AOD brightness"Chris Lu
This reverts commit e65e7c4f651fd8a11c7eeba894e99bae8a3eb3a5. Reason for revert: revert AOD changes since it's not needed Bug: 280519993 Test: enter/exit AOD, change AOD brightness Change-Id: I040de7e329b145c2876e153f918f56ffa7bc21a2 Signed-off-by: Chris Lu <luchris@google.com>
2023-04-24drm: samsung: correct some DPU events informationMidas Chien
Use "CH" for id of dpp device. Add zpos to ATOMIC_COMMIT event. Correct resource occupancy information in DECON_RSC_OCCUPANCY event. Add marco to map id of plane to dpp device. Bug: 247790341 Test: check dpu event Signed-off-by: Midas Chien <midaschieh@google.com> Change-Id: I92e308ed22331eb1b72cc7523891eed5448d5435
2023-04-19drm/samsung: decon: support TE width measurementandroid-u-beta-2_r0.4android-u-beta-2_r0.3android-u-beta-2_r0.2Shiyong Li
Report both TE rising and falling edge event to measure TE width. Bug: 266484665 Test: echo 1 > /d/dri/0/crtc-0/force_te_on, check perfetto trace Change-Id: I1f8c2a69739fee825b7de371efe0812e0fe554cc Signed-off-by: Shiyong Li <shiyongli@google.com> (cherry picked from commit 2d0a3e6aa273582a97cca581cd99a9c3dd4daa90)
2023-04-17Merge android13-gs-pixel-5.10-tm-qpr3 into android13-gs-pixel-5.10-udcRobin Peng
Bug: 255246572 Change-Id: Idd002e6ca61c6f950d2e6e0f059fffe997dbab76 Signed-off-by: Robin Peng <robinpeng@google.com>
2023-04-12panel: s6e3hc4: increase source amplifier power in AODandroid-t-qpr3-beta-3_r0.5android-t-qpr3-beta-3.1_r0.5android-t-qpr3-beta-3.1_r0.4android-t-qpr3-beta-3.1_r0.3android-13.0.0_r0.92android-13.0.0_r0.85android-13.0.0_r0.84android-13.0.0_r0.83android-13.0.0_r0.82android-13.0.0_r0.126android-13.0.0_r0.125android-13.0.0_r0.124android-13.0.0_r0.123android-13.0.0_r0.121android-13.0.0_r0.116android-13.0.0_r0.115android-13.0.0_r0.114android-13.0.0_r0.113android-13.0.0_r0.112android-13.0.0_r0.106android-13.0.0_r0.105android-13.0.0_r0.104android-13.0.0_r0.103android-13.0.0_r0.100android-gs-tangorpro-5.10-android13-qpr3android-gs-raviole-5.10-t-qpr3-beta-3android-gs-raviole-5.10-android13-qpr3android-gs-pantah-5.10-t-qpr3-beta-3android-gs-pantah-5.10-android13-qpr3android-gs-lynx-5.10-android13-qpr3android-gs-bluejay-5.10-t-qpr3-beta-3android-gs-bluejay-5.10-android13-qpr3Shiyong Li
Bug: 274187749 Test: check AOD flicker Change-Id: I95ee814a8e6a0f80f83c967fd76f8e69beb99783 Signed-off-by: Shiyong Li <shiyongli@google.com>
2023-04-12panel: s6e3hc4: update init and AOD command sequenceShiyong Li
- set Vreg = 4.5V instead of 6.4V at display-off and 6.8V at display-on. - disable idle before setting Vreg=4.5V - refactor AOD enter/exit command sequence, remove lp_off mode Bug: 274187749 Test: check perfetto trace, enter and exit AOD Signed-off-by: Shiyong Li <shiyongli@google.com> Change-Id: If124d4ef0a0de56189cb5311598ecd98d402b1f3
2023-04-12samsung/panel: add the functions of waiting for vsyncShiyong Li
Bug: 274187749 Change-Id: Iedd736ff7753da1ada8669e8f30c7603f87838ba Signed-off-by: Shiyong Li <shiyongli@google.com>
2023-04-10drm: samsung: set dma mask while decon probeKen Huang
Bug: 261700544 Test: add debug log to check coherent_dma_mask in plane update Change-Id: I7bdb312d46de32913af17ddabb10d65845ffa3f2 Signed-off-by: Ken Huang <kenbshuang@google.com>
2023-04-09Merge android13-gs-pixel-5.10-tm-qpr3 into android13-gs-pixel-5.10-udcPixelBot AutoMerger
SBMerger: 516612970 Change-Id: Ic325879d956ee882d8e978604aa6f05627ae0660 Signed-off-by: SecurityBot <android-nexus-securitybot@system.gserviceaccount.com>
2023-04-07drm: samsung: support sbwc encoded writebackKwanghyun Chung
The feature to support sbwc encoded writeback was added. And, DRM_FORMAT_NV12 to writeback also was added. Bug: 187000170 Test: ./build_cloudripper.sh Signed-off-by: Kwanghyun Chung <khyun.chung@samsung.com> Change-Id: Id38229165b799799fecd653e2386a4d87bdfe368
2023-04-07panel: s6e3hc4: update AOD brightnessShiyong Li
support 10, 20 and 30 nits. Bug: 274187749 Test: turn on/off screen, check AOD Change-Id: Ieb764fbfd6a27f5b6671b52bbaff114b4556956d Signed-off-by: Shiyong Li <shiyongli@google.com>
2023-04-03panel: s6e3hc4: increase source amplifier power in AODShiyong Li
Bug: 274187749 Test: check AOD flicker Change-Id: I95ee814a8e6a0f80f83c967fd76f8e69beb99783 Signed-off-by: Shiyong Li <shiyongli@google.com>
2023-04-01Revert "panel: s6e3hc4: update AOD power voltage"Shiyong Li
This reverts commit 72a95a72d5ea77fc0deb2067774a4ae52cddeb75. Reason for revert: some phone sees band issue Change-Id: I0c3bea911663cdc3ae6e59bf72851f72e1c8ea6a
2023-03-30panel: s6e3hc4: update AOD power voltageShiyong Li
Bug: 274187749 Test: check artifacts in AOD Change-Id: Iea713e56d007d0fbf2cf1516d43352496bbd0ad4 Signed-off-by: Shiyong Li <shiyongli@google.com>
2023-03-30panel: s6e3hc4: update init and AOD command sequenceShiyong Li
- set Vreg = 4.5V instead of 6.4V at display-off and 6.8V at display-on. - disable idle before setting Vreg=4.5V - refactor AOD enter/exit command sequence, remove lp_off mode Bug: 274187749 Test: check perfetto trace, enter and exit AOD Signed-off-by: Shiyong Li <shiyongli@google.com> Change-Id: If124d4ef0a0de56189cb5311598ecd98d402b1f3
2023-03-30samsung/panel: add the functions of waiting for vsyncShiyong Li
Bug: 274187749 Change-Id: Iedd736ff7753da1ada8669e8f30c7603f87838ba Signed-off-by: Shiyong Li <shiyongli@google.com>
2023-03-29drm: samsung: dsim: handle mode change on TUI exitandroid-t-qpr3-beta-3_r0.4android-t-qpr3-beta-3_r0.3Oleg Matcovschi
Bug: 268038983 Change-Id: Ieb2aa0522b2cba057b5569883fe546530eced8aa Signed-off-by: Adrian Salido <salidoa@google.com> Signed-off-by: Oleg Matcovschi <omatcovschi@google.com>
2023-03-29drm: samsung: move commit work to crtc stateAdrian Salido
The private object is global for all devices so it's possible that commits on different crtc could cause previous private objects to be removed and cause use-after-free issues. To avoid this, move commit work to happen within crtc. Since we are already using per crtc/decon worker, it won't be possible to get ahead in this case. Bug: 263674548 Test: perform empty atomic commits after non-blocking one on crtc Change-Id: Ie648a2e7069290cd3168ed2d847b97e176f8a2ee Signed-off-by: Adrian Salido <salidoa@google.com>
2023-03-26Merge android13-gs-pixel-5.10-tm-qpr3 into android13-gs-pixel-5.10-udcPixelBot AutoMerger
SBMerger: 516612970 Change-Id: I57d5d75c494ada7ce630f1aa08f5b2511a9c3ad8 Signed-off-by: SecurityBot <android-nexus-securitybot@system.gserviceaccount.com>
2023-03-24drm: samsung: change tui sequence for video modeAdrian Salido
Bug: 270193879 Bug: 232723067 Change-Id: Icef95f24bb1b4906d8187fa530ada17785010091 Signed-off-by: Adrian Salido <salidoa@google.com>
2023-03-24Revert "drm: samsung: tui: skip blankmode transition for video mode panels"Oleg Matcovschi
This reverts commit e93401fb68a8cf2e3c99c6b349274cf6aa7f0ffe. Reason for revert: b/241837873 is fixed. Bug: 241837873 Change-Id: I7b2aab7d5a705bf7e737b5e5f111a2a7e0a60bb5 Signed-off-by: Oleg Matcovschi <omatcovschi@google.com>
2023-03-21drm: samsung: improve debug messages for secure contentsKen Huang
Dump the security bit as well when the sysmmu fault happens. Bug: 260514681 Test: check dpu event log Change-Id: I9af612686ce35d24fa271045959f14b59a942fc2 Signed-off-by: Ken Huang <kenbshuang@google.com>
2023-03-17drm: samsung: call local_clock to log timestampKen Huang
The timestamp in dpu event log missaligns with printk and causes sometimes we can see future time in the event log. Bug: 273665747 Test: check dpu event log Change-Id: Id1a5720f65e394327193134e4decb281ca1c32ee Signed-off-by: Ken Huang <kenbshuang@google.com>
2023-03-16samsung: cal_9845: check PLL_EN right after config itKen Huang
PLL enable timeout may be from a wrong PLL_EN setting. Add a readback to make sure the config is applied correctly. Bug: 269239140 Test: frequently enter or exit hibernation then check log Change-Id: Iac75235f6a8f045c6d951694a747c19bc88aecac Signed-off-by: Ken Huang <kenbshuang@google.com>
2023-03-16drm: samsung: add more log to debug stability issuesKen Huang
Bug: 269239140 Test: check dpu event log Change-Id: Ia7c3cb8753d382de016c6ed8c5fef194a16203af Signed-off-by: Ken Huang <kenbshuang@google.com>
2023-03-12Merge android13-gs-pixel-5.10-tm-qpr3 into android13-gs-pixel-5.10-udcandroid-u-beta-1_r0.5android-u-beta-1_r0.4android-u-beta-1_r0.3android-gs-raviole-5.10-u-beta1android-gs-pantah-5.10-u-beta1android-gs-bluejay-5.10-u-beta1PixelBot AutoMerger
SBMerger: 478053055 Change-Id: I8726c62d1951fbe135641c68d260a5de742db741 Signed-off-by: SecurityBot <android-nexus-securitybot@system.gserviceaccount.com>
2023-03-01drm: samsung: dsim: cleanup dsim command packet prepareAdrian Salido
Fix the following problems: * Completion structs may not be reset properly leading to improperly waiting on stale completions. * Packet go commands are not being logged in event log * Payload FIFO size check may include PH only packets Bug: 259135990 Test: suspend/resume and check dynamic debug logs Change-Id: I4d84c37ab8872a47baae02c7d9f3bc6240149475 Signed-off-by: Adrian Salido <salidoa@google.com>
2023-03-01drm: samsung: dsim: check for fifo status before waitAdrian Salido
There are instances in which the PH/PL FIFO is consumed before be even start waiting on them. In order to avoid unnecessary waits, check whether FIFO is empty first. Bug: 259135990 Test: check dynamic debug logs, fifo is already empty in many cases Change-Id: I8b8a9c62f0a6a1a5d014438453d99202af441716 Signed-off-by: Adrian Salido <salidoa@google.com>
2023-03-01drm: samsung: dsim: cleanup packet-go even after failureAdrian Salido
When there's a timeout sending a series of commands using packet-go feature, sending of commands could fail due to unexpected issues. In such cases we still need to ensure that the state of the feature is cleared even if it timed out, otherwise we may land in unexpected sw state. Bug: 269702366 Test: turn screen on/off, check dynamic debug logs Change-Id: I65648964372daa1519fbe68d796425f4bb5cf56b Signed-off-by: Adrian Salido <salidoa@google.com>
2023-02-24panel: s6e3hc4: update command sequence to mitigate artifactsShiyong Li
add deleting toggle command at init and remove display-off command in AOD. Bug: 269047402 Change-Id: I07d4549f552ee40389d7ad73a97f8acfb2308e19 Signed-off-by: Shiyong Li <shiyongli@google.com> (cherry picked from commit e5a3f7a78dcccf0314d1587c9d0dd1ebc6d24cc8)
2023-02-23samsung: panel: don't duplicate setting brightness=0Shiyong Li
- as backlight is off after resetting panel, don't duplicate setting it. - some panel could show artifacts if setting brightness from zero to non-zero. Bug: 269425859 Change-Id: Id49253eb5cec96d4268a22ff6a6480da06154a2e Signed-off-by: Shiyong Li <shiyongli@google.com> (cherry picked from commit 76a438509a4c5fbf0823a7e11e52e10aa4473f81) (cherry picked from commit e4306382ad52932072282d72b7636610010c0157)
2023-02-23Merge "Merge android13-gs-pixel-5.10-tm-qpr2 into ↵android-t-qpr3-beta-2_r0.4android-t-qpr3-beta-2_r0.3android-gs-raviole-5.10-t-qpr3-beta-2android-gs-bluejay-5.10-t-qpr3-beta-2Joey Lin
android13-gs-pixel-5.10-tm-qpr3" into android13-gs-pixel-5.10-tm-qpr3
2023-02-22samsung: panel: don't duplicate setting brightness=0android-t-qpr3-beta-2_r0.5android-t-qpr3-beta-1_r0.5android-gs-pantah-5.10-t-qpr3-beta-2android-gs-pantah-5.10-android13-qpr3-beta1Shiyong Li
- as backlight is off after resetting panel, don't duplicate setting it. - some panel could show artifacts if setting brightness from zero to non-zero. Bug: 269425859 Change-Id: Id49253eb5cec96d4268a22ff6a6480da06154a2e Signed-off-by: Shiyong Li <shiyongli@google.com>
2023-02-21panel: s6e3hc4: update command sequence to mitigate artifactsShiyong Li
add deleting toggle command at init and remove display-off command in AOD. Bug: 269047402 Change-Id: I07d4549f552ee40389d7ad73a97f8acfb2308e19 Signed-off-by: Shiyong Li <shiyongli@google.com>
2023-02-20Merge "Merge android13-gs-pixel-5.10-tm-qpr3 into ↵Joey Lin
android13-gs-pixel-5.10-udc" into android13-gs-pixel-5.10-udc
2023-02-20Merge "Merge android13-gs-pixel-5.10-tm-qpr2 into ↵Joey Lin
android13-gs-pixel-5.10-tm-qpr3" into android13-gs-pixel-5.10-tm-qpr3
2023-02-19Merge android13-gs-pixel-5.10-tm-qpr2 into android13-gs-pixel-5.10-tm-qpr3PixelBot AutoMerger
SBMerger: 478053055 Change-Id: I660acd66e5d95d36ec6dcac066763e57793aafea Signed-off-by: SecurityBot <android-nexus-securitybot@system.gserviceaccount.com>
2023-02-16Revert "drm: samsung: restore immutable flag for lp_mode"Safayat Ullah
This reverts commit ea1de20e61012b53e52d8e4b56048d5a52cb2440. Reason for revert: Display cannot enter LP mode Bug: 268306343 Change-Id: I596ac734e5eb44f6f59a5094fb34529a1dcb6003
2023-02-15drm: samsung: recovery: isolate recovery only to a single pipelineAdrian Salido
Current recovery mechanism is resetting all interfaces (via the call to drm_mode_config_reset). This leads to inconsistent state, and unnecessarily modifying other display pipelines. Instead isolate the recovery sequence to only the crtc provided. Bug: 267877897 Change-Id: Ib6358ade88eb322d79194c062f9125c31e4cb7eb Signed-off-by: Adrian Salido <salidoa@google.com>
2023-02-15drm: samsung: add MIPI_CMD_SYNC_NONE to mipi_sync_modeandroid-u-preview-2_r0.2android-gs-raviole-5.10-u-preview-2Safayat Ullah
kms_properties test fails as bitmask property mipi_sync contains value zero. So, MIPI_CMD_SYNC_NONE is introduced and used as the default value. Bug: 263460552 Test: run kms_properties test Change-Id: If12caeff31f853318e78bdb12eca5f580020cae4 Signed-off-by: Safayat Ullah <safayat@google.com>