summaryrefslogtreecommitdiff
path: root/mali_kbase/mmu
diff options
context:
space:
mode:
authorJack Diver <diverj@google.com>2022-07-23 10:56:18 +0000
committerJack Diver <diverj@google.com>2022-07-23 11:02:26 +0000
commitd82f270351f0488a475a396609cca08fbe0a17f6 (patch)
tree96b3ed582b7d21544823a7668c362b558ce8e212 /mali_kbase/mmu
parentdf58a621a4259e58cb1a2c51ede6d84807eeadf2 (diff)
downloadgpu-d82f270351f0488a475a396609cca08fbe0a17f6.tar.gz
mali_kbase: Do not modify work_struct.data
coredump work struct data member was incorrectly used leading to the pending bit to get improperly cleared. When work is queued in quick succession, this prevents protection against double queuing. Bug: 232508335 Test: Stress test core dump work queueing Signed-off-by: Jack Diver <diverj@google.com> Change-Id: Ifebebbfb8cfd6ece57f8a96ddf0a0986d458b6e7
Diffstat (limited to 'mali_kbase/mmu')
-rw-r--r--mali_kbase/mmu/mali_kbase_mmu_hw_direct.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/mali_kbase/mmu/mali_kbase_mmu_hw_direct.c b/mali_kbase/mmu/mali_kbase_mmu_hw_direct.c
index c4ac529..9973d39 100644
--- a/mali_kbase/mmu/mali_kbase_mmu_hw_direct.c
+++ b/mali_kbase/mmu/mali_kbase_mmu_hw_direct.c
@@ -142,7 +142,6 @@ static int wait_ready(struct kbase_device *kbdev,
dev_err(kbdev->dev,
"AS_ACTIVE bit stuck for as %u, might be caused by slow/unstable GPU clock or possible faulty FPGA connector",
as_nr);
- atomic_long_set(&kbdev->csf.coredump_work.data, KBASE_COREDUMP_MMU_HANG);
queue_work(system_highpri_wq, &kbdev->csf.coredump_work);
return -1;
}