From 2ee7d4b9f5ea05fb777ed1224bb5932526b33bf6 Mon Sep 17 00:00:00 2001 From: Ankit Goyal Date: Wed, 17 May 2023 13:13:55 -0700 Subject: mali_kbase: add NULL checks before global_iface register dump Based on the commit 440a991eda5dfb08e9f6ba1234a475dd8bd89325 with further changes. Bug: 320427777 Test: Manually tested the error path. Signed-off-by: Shashank Sharma Change-Id: Ibb4b18ae14f8ec03379acf2b4892b212b46607c3 --- mali_kbase/csf/mali_kbase_csf_reset_gpu.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mali_kbase/csf/mali_kbase_csf_reset_gpu.c b/mali_kbase/csf/mali_kbase_csf_reset_gpu.c index 726cee2..c722c96 100644 --- a/mali_kbase/csf/mali_kbase_csf_reset_gpu.c +++ b/mali_kbase/csf/mali_kbase_csf_reset_gpu.c @@ -268,9 +268,10 @@ void kbase_csf_debug_dump_registers(struct kbase_device *kbdev) } dev_err(kbdev->dev, " MCU DB0: %x", kbase_reg_read32(kbdev, DEBUG_MCUC_DB_VALUE_0)); - dev_err(kbdev->dev, " MCU GLB_REQ %x GLB_ACK %x", - kbase_csf_firmware_global_input_read(global_iface, GLB_REQ), - kbase_csf_firmware_global_output(global_iface, GLB_ACK)); + if (global_iface && global_iface->kbdev && global_iface->input && global_iface->output) + dev_err(kbdev->dev, " MCU GLB_REQ %x GLB_ACK %x", + kbase_csf_firmware_global_input_read(global_iface, GLB_REQ), + kbase_csf_firmware_global_output(global_iface, GLB_ACK)); } -- cgit v1.2.3