diff options
| author | Ruofei Ma <ruofeim@google.com> | 2022-11-29 12:41:00 -0800 |
|---|---|---|
| committer | Ruofei Ma <ruofeim@google.com> | 2023-02-09 20:19:23 +0000 |
| commit | 64e5ca6bfa32c6bf5bcd52c0c0ff35761a4b2465 (patch) | |
| tree | 2dcc22363c0dc21912ff5dc31224874e48ae9add | |
| parent | 7de143a697adb5152051896454a4ec36a9bf63e5 (diff) | |
| download | gchips-64e5ca6bfa32c6bf5bcd52c0c0ff35761a4b2465.tar.gz | |
Fix error handling in secure modeandroid-u-beta-3_r0.3android-u-beta-3_r0.2android-u-beta-2_r0.4android-u-beta-2_r0.3android-u-beta-2_r0.2android-u-beta-2.1_r0.4android-u-beta-2.1_r0.3android-u-beta-2.1_r0.2android-gs-raviole-5.10-u-beta3android-gs-raviole-5.10-u-beta2android-gs-pantah-5.10-u-beta2android-gs-bluejay-5.10-u-beta3android-gs-bluejay-5.10-u-beta2
Driver should always do SMC_PROTECTION_DISABLE regardless of job status.
Bug: 233393972
Bug: 267935059
Change-Id: Id9b78fb1cd7e8d5cdbd68511c8d6fc3a8a04cee2
Signed-off-by: Ruofei Ma <ruofeim@google.com>
(cherry picked from commit be7c095ef86dd9d083af7b0045765fa8406179f4)
| -rw-r--r-- | bigo.c | 11 |
1 files changed, 3 insertions, 8 deletions
@@ -635,16 +635,11 @@ static int bigo_worker_thread(void *data) } rc = bigo_run_job(core, job); - if (rc) { - pr_err("Error running job\n"); - goto done; - } if (inst->is_secure) { - rc = exynos_smc(SMC_PROTECTION_SET, 0, BIGO_SMC_ID, - SMC_PROTECTION_DISABLE); - if (rc) - pr_err("failed to disable SMC_PROTECTION_SET: %d\n", rc); + if (exynos_smc(SMC_PROTECTION_SET, 0, BIGO_SMC_ID, + SMC_PROTECTION_DISABLE)) + pr_err("failed to disable SMC_PROTECTION_SET\n"); } done: |