summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSubash Abhinov Kasiviswanathan <subashab@codeaurora.org>2020-07-16 12:22:42 -0700
committerSubash Abhinov Kasiviswanathan <subashab@codeaurora.org>2020-07-16 12:48:26 -0700
commite3abf2d2c67f52f4b9ab683b1119c4bd8de771bf (patch)
tree161aeb080051b4fe3a066999424a32324ee4b85f
parentc7f0fbe8f0d8f723000441c4afc2270c88fd011e (diff)
downloaddata-kernel-e3abf2d2c67f52f4b9ab683b1119c4bd8de771bf.tar.gz
drivers: rmnet: shs: Remove unecessary dereference
Remove double dereference to get segs_per_skb. This should prevent a null dereference is node is invalid. Change-Id: I6f199457088c9f33d69192dd24360b95718db54d Acked-by: Raul Martinez <mraul@qti.qualcomm.com> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
-rw-r--r--drivers/rmnet/shs/rmnet_shs_wq.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/rmnet/shs/rmnet_shs_wq.c b/drivers/rmnet/shs/rmnet_shs_wq.c
index 3445519..07566a2 100644
--- a/drivers/rmnet/shs/rmnet_shs_wq.c
+++ b/drivers/rmnet/shs/rmnet_shs_wq.c
@@ -1941,7 +1941,7 @@ void rmnet_shs_update_cfg_mask(void)
}
}
-void rmnet_shs_wq_filter(void)
+noinline void rmnet_shs_wq_filter(void)
{
int cpu, cur_cpu;
int temp;
@@ -1966,11 +1966,11 @@ void rmnet_shs_wq_filter(void)
rmnet_shs_cpu_rx_filter_flows[temp]++;
}
cur_cpu = hnode->current_cpu;
- if (cur_cpu >= MAX_CPUS) {
+ if (cur_cpu >= MAX_CPUS || cur_cpu < 0) {
continue;
}
- if (hnode->node->hstats->segs_per_skb > 0) {
+ if (hnode->segs_per_skb > 0) {
rmnet_shs_cpu_node_tbl[cur_cpu].seg++;
}
}