diff options
| author | Subash Abhinov Kasiviswanathan <subashab@codeaurora.org> | 2018-10-02 17:08:08 -0600 |
|---|---|---|
| committer | Sean Tranchetti <stranche@codeaurora.org> | 2018-10-02 18:05:33 -0600 |
| commit | be4a1559dcc2c0ac344ade8ab2561f98c2be04d0 (patch) | |
| tree | 2a548855e351d5c8c057309a696c788f532d97a0 /drivers/rmnet/shs | |
| parent | 65d902ec3cc5262d5bfc2a3c16a8e42ccb5d6c27 (diff) | |
| download | data-kernel-be4a1559dcc2c0ac344ade8ab2561f98c2be04d0.tar.gz | |
drivers: rmnet_shs: Static analysis fixes
Fixed potential issues found by static analysis.
Fixed Junk trace output
CR-Fixed: 2326419
Change-Id: Icf42f28b8e123e36af522eccef4b1e6aaa0bf001
Acked-by: Raul Martinez <mraul@qti.qualcomm.com>
Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Diffstat (limited to 'drivers/rmnet/shs')
| -rw-r--r-- | drivers/rmnet/shs/rmnet_shs_main.c | 4 | ||||
| -rw-r--r-- | drivers/rmnet/shs/rmnet_shs_wq.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/drivers/rmnet/shs/rmnet_shs_main.c b/drivers/rmnet/shs/rmnet_shs_main.c index 1b89d81..fe3c347 100644 --- a/drivers/rmnet/shs/rmnet_shs_main.c +++ b/drivers/rmnet/shs/rmnet_shs_main.c @@ -452,6 +452,8 @@ void rmnet_shs_flush_node(struct rmnet_shs_skbn_s *node) if (!node->skb_list.head) return; + hash2stamp = rmnet_shs_form_hash(node->map_index, + map->len, node->skb_list.head->hash); trace_rmnet_shs_high(RMNET_SHS_FLUSH, RMNET_SHS_FLUSH_NODE_START, node->hash, hash2stamp, @@ -459,8 +461,6 @@ void rmnet_shs_flush_node(struct rmnet_shs_skbn_s *node) node->skb_list.num_parked_bytes, node, node->skb_list.head); - hash2stamp = rmnet_shs_form_hash(node->map_index, - map->len, node->skb_list.head->hash); for ((skb = node->skb_list.head); skb != NULL; skb = nxt_skb) { nxt_skb = skb->next; diff --git a/drivers/rmnet/shs/rmnet_shs_wq.c b/drivers/rmnet/shs/rmnet_shs_wq.c index a008108..547e9de 100644 --- a/drivers/rmnet/shs/rmnet_shs_wq.c +++ b/drivers/rmnet/shs/rmnet_shs_wq.c @@ -808,7 +808,7 @@ u16 rmnet_shs_wq_find_cpu_to_move_flows(u16 current_cpu, cur_cpu_list_p = &rx_flow_tbl_p->cpu_list[current_cpu]; cur_cpu_rx_pps = cur_cpu_list_p->rx_pps; - + pps_uthresh = rmnet_shs_cpu_rx_max_pps_thresh[current_cpu]; /* If we are already on a perf core and required pps is beyond * beyond the capacity that even perf cores aren't sufficient * there is nothing much we can do. So we will continue to let flows |