diff options
| author | Abhinav Kumar <abhikuma@codeaurora.org> | 2019-10-23 15:30:17 +0530 |
|---|---|---|
| committer | Isaac Chiou <isaacchiou@google.com> | 2020-02-25 02:15:47 +0000 |
| commit | edcd3208bf3636bd1d66748b69d18b9ae864e46b (patch) | |
| tree | c1caefa40de1be5e6bad64a29ec972647eea5bd5 | |
| parent | fc294a14124df3c49c00b879deab10825ce51e01 (diff) | |
| download | qcacld-edcd3208bf3636bd1d66748b69d18b9ae864e46b.tar.gz | |
qcacld-3.0: Reduce the candidate list to 5 in roam cmd for SAE auth
Current driver configuration is as follow:
1. SME active roam command queue timeout is 30 seconds
2. SAE auth timeout is 5 seconds
3. Max BSS count in roam command (CSR_MAX_BSSID_COUNT) for SAE
authentication is 8
As SAE auth timeout is 5 seconds and SME active command queue timeout
are 30 seconds, so only 6 SAE auth timeouts (30/5 = 6) are enough to
trigger SME active command queue timeout for roam command.
In case of continuous SAE auth time out, Driver will try SAE
connection till 8th candidate. So when driver tries to process SAE
connection for 7th BSSID, device leads to crash as by this time
SAE roam command(connect command) gets removed from SME active roam
command queue.
Fix is to reduce the candidate list to 5 in roam command for SAE
authentication considering SME roam command queue timeout is of 30
seconds.
Merged-In: Ic43f44ef14ea4c3b972635682941a624cdc6dcc7
Change-Id: Ic43f44ef14ea4c3b972635682941a624cdc6dcc7
CRs-Fixed: 2551462
bug: 143129445
Signed-off-by: Isaac Chiou <isaacchiou@google.com>
(cherry picked from commit 49dd69705899ad2ee3266b0e3b0727f978d69dd1)
| -rw-r--r-- | core/sme/src/csr/csr_inside_api.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/core/sme/src/csr/csr_inside_api.h b/core/sme/src/csr/csr_inside_api.h index 34b5f2cb6d..77d469702d 100644 --- a/core/sme/src/csr/csr_inside_api.h +++ b/core/sme/src/csr/csr_inside_api.h @@ -94,10 +94,11 @@ #define CSR_ACTIVE_SCAN_LIST_CMD_TIMEOUT (1000*30) /* *************************************************************************** - * The MAX BSSID Count should be lower than the command timeout value and it - * can be of a fraction of 1/3 to 1/2 of the total command timeout value. + * The MAX BSSID Count should be lower than the command timeout value. + * As in some case auth timeout can take upto 5 sec (in case of SAE auth) try + * (command timeout/5000 - 1) candidates. * ***************************************************************************/ -#define CSR_MAX_BSSID_COUNT (SME_ACTIVE_LIST_CMD_TIMEOUT_VALUE/3000) - 2 +#define CSR_MAX_BSSID_COUNT (SME_ACTIVE_LIST_CMD_TIMEOUT_VALUE/5000) - 1 #define CSR_CUSTOM_CONC_GO_BI 100 extern uint8_t csr_wpa_oui[][CSR_WPA_OUI_SIZE]; bool csr_is_supported_channel(tpAniSirGlobal pMac, uint8_t channelId); |