diff options
| author | Dustin Brown <dustinb@codeaurora.org> | 2017-10-19 16:21:22 -0700 |
|---|---|---|
| committer | snandini <snandini@codeaurora.org> | 2017-10-21 20:00:54 -0700 |
| commit | f303532f05a24aa667d75bd51e1ecbf85da7704d (patch) | |
| tree | c2efb3c407bb4ed584aa0033fcb67015874c35d3 /core/cds | |
| parent | ffa1a14b0cd06af8eafb7590ee5bd7b69866f1ab (diff) | |
| download | qcacld-f303532f05a24aa667d75bd51e1ecbf85da7704d.tar.gz | |
qcacld-3.0: Call cds_sched_close in cds_open error path
When cds_open fails after calling cds_sched_open, cleanup is attempted.
However, cds_sched_close is currently protected by a faulty
conditional. Remove the conditional so the scheduler context can be
cleaned up appropriately for all cds_open failure modes.
Change-Id: I709e8d2af06ffdf1a2910d81d23fa3a33ffbe074
CRs-Fixed: 2129677
Diffstat (limited to 'core/cds')
| -rw-r--r-- | core/cds/src/cds_api.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/core/cds/src/cds_api.c b/core/cds/src/cds_api.c index a816151399..e4a50629d0 100644 --- a/core/cds/src/cds_api.c +++ b/core/cds/src/cds_api.c @@ -532,12 +532,9 @@ err_bmi_close: bmi_cleanup(ol_ctx); err_sched_close: - if (QDF_IS_STATUS_SUCCESS(qdf_status)) { - qdf_status = cds_sched_close(gp_cds_context); - if (!QDF_IS_STATUS_SUCCESS(qdf_status)) { - cds_err("Failed to close CDS Scheduler"); - QDF_ASSERT(false); - } + if (QDF_IS_STATUS_ERROR(cds_sched_close(gp_cds_context))) { + cds_err("Failed to close CDS Scheduler"); + QDF_ASSERT(false); } err_concurrency_lock: |