diff options
| author | Maciej Żenczykowski <maze@google.com> | 2021-06-14 21:18:53 +0000 |
|---|---|---|
| committer | Maciej Zenczykowski <maze@google.com> | 2021-06-22 04:44:12 +0000 |
| commit | e9bda53308a56f7c0bf493bfdcdf94a4ad036f8b (patch) | |
| tree | 17b742dfb058b7509edce18edf53ed58ee9a30bf | |
| parent | 0be81bc251e4f2cda50813b032437480ae5c5648 (diff) | |
| download | tests-e9bda53308a56f7c0bf493bfdcdf94a4ad036f8b.tar.gz | |
net-test: remove bbr/bbr2 from list of acceptable congestion control algos
bbr2 isn't even yet available in the upstream linux kernel.
Quoting from https://android-review.googlesource.com/c/kernel/common/+/1735979:
Neal Cardwell says:
As one of the co-authors of BBR, some thoughts:
Currently mainline Linux only has BBRv1. BBR is a work in progress,
and BBRv1 is not at the level of performance where we would like to
see it deployed at wide scale on Android phones. In some circumstances
BBRv1 can cause high and frequent packet loss, and thus also poor latency
for request/response (web, RPC, SSH) traffic, and low throughput for
coexisting Reno and CUBIC flows. This could cause poor user experiences
in households, schools, or enterprises where there are constrained uplinks
into the Internet. I would recommend against making BBRv1 available on
Android phones, and I would urge that BBR not be made available on Android
phones until BBRv2 is upstream.
Test: TreeHugger, ran tests against ACK 5.4
Bug: 191723680
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Original-Change: https://android-review.googlesource.com/1736796
Merged-In: Ia1a600d93f0420fbb57238d70c9ae3d5cfd1eac3
Change-Id: Ia1a600d93f0420fbb57238d70c9ae3d5cfd1eac3
| -rwxr-xr-x | net/test/sysctls_test.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/test/sysctls_test.py b/net/test/sysctls_test.py index 4b71f39..cb608f6 100755 --- a/net/test/sysctls_test.py +++ b/net/test/sysctls_test.py @@ -23,7 +23,7 @@ class SysctlsTest(net_test.NetworkTest): def check(self, f): algs = open(f).readline().strip().split(' ') - bad_algs = [a for a in algs if a not in ['bbr', 'bbr2', 'cubic', 'reno']] + bad_algs = [a for a in algs if a not in ['cubic', 'reno']] msg = ("Obsolete TCP congestion control algorithm found. These " "algorithms will decrease real-world networking performance for " "users and must be disabled. Found: %s" % bad_algs) |