diff options
author | Shubhangi Pawar <svpawar@google.com> | 2022-10-05 23:57:01 +0000 |
---|---|---|
committer | Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> | 2022-10-05 23:57:01 +0000 |
commit | 32e6cca3282d41ba2a7e5d4c79369eb313edc816 (patch) | |
tree | ec7eaf7308d22f592a0ca98737897d801df40d7b | |
parent | e6fb091bbaaea06bd8b4dae07e3ba92ec6eb6d22 (diff) | |
parent | 793d1fb5ab5e038332f7c54647bea507a094910f (diff) | |
download | bionic-32e6cca3282d41ba2a7e5d4c79369eb313edc816.tar.gz |
Merge "stack_protector_DeathTest#modify_stack_protector: avoid flake." into android12-tests-dev am: 793d1fb5ab
Original change: https://android-review.googlesource.com/c/platform/bionic/+/2240186
Change-Id: I3b367d57efa507d95bba1dfcc630237995c7adda
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-rw-r--r-- | tests/stack_protector_test_helper.cpp | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/tests/stack_protector_test_helper.cpp b/tests/stack_protector_test_helper.cpp index fd90b939b..eddd94074 100644 --- a/tests/stack_protector_test_helper.cpp +++ b/tests/stack_protector_test_helper.cpp @@ -19,7 +19,8 @@ __attribute__((noinline)) void modify_stack_protector_test() { // We can't use memset here because it's fortified, and we want to test // the line of defense *after* that. // Without volatile, the generic x86/x86-64 targets don't write to the stack. - volatile char* p; - p = reinterpret_cast<volatile char*>(&p + 1); - *p = '\0'; + // We can't make a constant change, since the existing byte might already have + // had that value. + volatile char* p = reinterpret_cast<volatile char*>(&p + 1); + *p = ~*p; } |