diff options
| author | Christopher Ferris <cferris@google.com> | 2017-08-22 11:24:09 -0700 |
|---|---|---|
| committer | Christopher Ferris <cferris@google.com> | 2017-08-22 13:17:28 -0700 |
| commit | 92476407115f4431c5888c02cdb5f476b26e393a (patch) | |
| tree | d1724f23f16883ab14e7fca02054973635bc6141 /tests/async_safe_test.cpp | |
| parent | 3ce8834e53304b66e5b0d0d56bc0efea1a172e95 (diff) | |
| download | bionic-92476407115f4431c5888c02cdb5f476b26e393a.tar.gz | |
Refactor BufferOutputStream.
- Rewrite BufferOutputStream to handle 0 sized buffers and to get rid
of an unnecessary loop.
- Add tests to verify overflow corner cases.
- Implement async_safe_format_buffer to call async_safe_format_buffer_va_list
instead of duplicate the code.
Test: Ran new unit tests, booted on angler.
Change-Id: I7fb13e209f5b7443d212f55aab4b05ff2e0e8219
Diffstat (limited to 'tests/async_safe_test.cpp')
| -rw-r--r-- | tests/async_safe_test.cpp | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/tests/async_safe_test.cpp b/tests/async_safe_test.cpp index 3d6fcaa8f..e71ba7a83 100644 --- a/tests/async_safe_test.cpp +++ b/tests/async_safe_test.cpp @@ -181,8 +181,20 @@ TEST(async_safe_log, buffer_overrun) { char buf[BUFSIZ]; ASSERT_EQ(11, async_safe_format_buffer(buf, sizeof(buf), "hello %s", "world")); EXPECT_STREQ("hello world", buf); + ASSERT_EQ(11, async_safe_format_buffer(buf, 8, "hello %s", "world")); EXPECT_STREQ("hello w", buf); + + ASSERT_EQ(11, async_safe_format_buffer(buf, 6, "hello %s", "world")); + EXPECT_STREQ("hello", buf); + + ASSERT_EQ(4, async_safe_format_buffer(nullptr, 0, "xxxx")); + + ASSERT_EQ(4, async_safe_format_buffer(buf, 1, "xxxx")); + EXPECT_STREQ("", buf); + + ASSERT_EQ(4, async_safe_format_buffer(buf, 2, "xxxx")); + EXPECT_STREQ("x", buf); #else // __BIONIC__ GTEST_LOG_(INFO) << "This test does nothing.\n"; #endif // __BIONIC__ |