diff options
author | Elliott Hughes <enh@google.com> | 2019-03-08 15:20:23 -0800 |
---|---|---|
committer | Elliott Hughes <enh@google.com> | 2019-03-12 10:26:39 -0700 |
commit | bcaa454d32e1b4ccf92467bb263d627695ac9a5b (patch) | |
tree | 65d7d4c493242ecb51bfe1796f133b32538de514 /tests/membarrier_test.cpp | |
parent | ff16c0b89b7297bc70353f60afac9bb93d6b0087 (diff) | |
download | bionic-bcaa454d32e1b4ccf92467bb263d627695ac9a5b.tar.gz |
bionic tests: use GTEST_SKIP.
Also be a bit more to the point in our messages, focusing on "why" not
"what".
Test: ran tests
Change-Id: I297806c7a102bd52602dcd2fcf7a2cd34aba3a11
Diffstat (limited to 'tests/membarrier_test.cpp')
-rw-r--r-- | tests/membarrier_test.cpp | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/tests/membarrier_test.cpp b/tests/membarrier_test.cpp index 9e871c71c..6f650e712 100644 --- a/tests/membarrier_test.cpp +++ b/tests/membarrier_test.cpp @@ -46,8 +46,7 @@ TEST(membarrier, query) { TEST(membarrier, global_barrier) { if (!HasMembarrier(MEMBARRIER_CMD_GLOBAL)) { - GTEST_LOG_(INFO) << "MEMBARRIER_CMD_GLOBAL not supported, skipping test."; - return; + GTEST_SKIP() << "MEMBARRIER_CMD_GLOBAL not supported"; } ASSERT_EQ(0, syscall(__NR_membarrier, MEMBARRIER_CMD_GLOBAL, 0)); } @@ -78,14 +77,10 @@ static const char* MembarrierCommandToName(int membarrier_cmd) { static void TestRegisterAndBarrierCommands(int membarrier_cmd_register, int membarrier_cmd_barrier) { if (!HasMembarrier(membarrier_cmd_register)) { - GTEST_LOG_(INFO) << MembarrierCommandToName(membarrier_cmd_register) - << " not supported, skipping test."; - return; + GTEST_SKIP() << MembarrierCommandToName(membarrier_cmd_register) << " not supported"; } if (!HasMembarrier(membarrier_cmd_barrier)) { - GTEST_LOG_(INFO) << MembarrierCommandToName(membarrier_cmd_barrier) - << " not supported, skipping test."; - return; + GTEST_SKIP() << MembarrierCommandToName(membarrier_cmd_barrier) << " not supported"; } ScopedErrnoCleaner errno_cleaner; |