diff options
author | Fumitoshi Ukai <fumitoshi.ukai@gmail.com> | 2015-06-08 11:21:16 +0900 |
---|---|---|
committer | Fumitoshi Ukai <fumitoshi.ukai@gmail.com> | 2015-06-08 11:21:16 +0900 |
commit | 936de1096b57e72d19c624df335cbc5dca4a1077 (patch) | |
tree | 326343c8a8e2804c05e38e3575e129b765a88a12 /para_test.go | |
parent | 8fabdd09a55e26bc340666837cd3be0744c1e1d9 (diff) | |
download | kati-936de1096b57e72d19c624df335cbc5dca4a1077.tar.gz |
fix go lint (except comment on exported fields, error message with punct)
ast.go:70:1: comment on exported type MaybeRuleAST should be of the form "MaybeRuleAST ..." (with optional leading article)
eval.go:241:1: comment on exported method Evaluator.EvaluateVar should be of the form "EvaluateVar ..."
eval.go:14:2: don't use ALL_CAPS in Go names; use CamelCase
eval.go:15:2: don't use ALL_CAPS in Go names; use CamelCase
eval.go:16:2: don't use ALL_CAPS in Go names; use CamelCase
eval.go:431:2: don't use underscores in Go names; var makefile_list should be makefileList
main.go:29:2: var loadJson should be loadJSON
main.go:30:2: var saveJson should be saveJSON
ninja.go:19:2: struct field ruleId should be ruleID
para.go:15:9: if block ends with a return statement, so drop this else and outdent its block
para_test.go:21:2: don't use underscores in Go names; var num_tasks should be numTasks
parser.go:713:1: error should be the last type when returning multiple items
serialize.go:20:2: don't use ALL_CAPS in Go names; use CamelCase
serialize.go:21:2: don't use ALL_CAPS in Go names; use CamelCase
serialize.go:22:2: don't use ALL_CAPS in Go names; use CamelCase
serialize.go:23:2: don't use ALL_CAPS in Go names; use CamelCase
serialize.go:24:2: don't use ALL_CAPS in Go names; use CamelCase
serialize.go:25:2: don't use ALL_CAPS in Go names; use CamelCase
serialize.go:26:2: don't use ALL_CAPS in Go names; use CamelCase
serialize.go:27:2: don't use ALL_CAPS in Go names; use CamelCase
serialize.go:28:2: don't use ALL_CAPS in Go names; use CamelCase
serialize.go:29:2: don't use ALL_CAPS in Go names; use CamelCase
serialize.go:30:2: don't use ALL_CAPS in Go names; use CamelCase
serialize.go:31:2: don't use ALL_CAPS in Go names; use CamelCase
serialize.go:32:2: don't use ALL_CAPS in Go names; use CamelCase
serialize.go:230:6: func DumpDepGraphAsJson should be DumpDepGraphAsJSON
serialize.go:553:6: func LoadDepGraphFromJson should be LoadDepGraphFromJSON
serialize.go:437:9: if block ends with a return statement, so drop this else and outdent its block
var.go:174:1: receiver name should not be an underscore
var.go:175:1: receiver name should not be an underscore
var.go:176:1: receiver name should not be an underscore
var.go:177:1: receiver name should not be an underscore
var.go:178:1: receiver name should not be an underscore
var.go:180:1: receiver name should not be an underscore
var.go:183:1: receiver name should not be an underscore
var.go:187:1: receiver name should not be an underscore
var.go:191:1: receiver name should not be an underscore
Diffstat (limited to 'para_test.go')
-rw-r--r-- | para_test.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/para_test.go b/para_test.go index a447146..7452027 100644 --- a/para_test.go +++ b/para_test.go @@ -18,8 +18,8 @@ func TestPara(t *testing.T) { para := NewParaWorker(paraChan) go para.Run() - num_tasks := 100 - for i := 0; i < num_tasks; i++ { + numTasks := 100 + for i := 0; i < numTasks; i++ { runners := []runner{ { output: fmt.Sprintf("%d", i), @@ -32,7 +32,7 @@ func TestPara(t *testing.T) { var started []*ParaResult var results []*ParaResult - for len(started) != num_tasks || len(results) != num_tasks { + for len(started) != numTasks || len(results) != numTasks { select { case r := <-paraChan: fmt.Printf("started=%d finished=%d\n", len(started), len(results)) |