diff options
author | Android Build Coastguard Worker <android-build-coastguard-worker@google.com> | 2023-05-02 23:01:23 +0000 |
---|---|---|
committer | Android Build Coastguard Worker <android-build-coastguard-worker@google.com> | 2023-05-02 23:01:23 +0000 |
commit | cc9f68cdbb0766d800bd2413c4fecf481201d611 (patch) | |
tree | cbc147d72988f35eab9a3e75f527f20921b7fa44 | |
parent | 50dc6d284045059c211fd0ef57438dd2878b946f (diff) | |
parent | e03c3bb67c9e6556bf87203475e41d5c965c3697 (diff) | |
download | soong-cc9f68cdbb0766d800bd2413c4fecf481201d611.tar.gz |
Snap for 10052121 from e03c3bb67c9e6556bf87203475e41d5c965c3697 to udc-release
Change-Id: Ied870993c94487d3e7afe0f7ca1e0074c0634ed8
-rw-r--r-- | android/config.go | 7 | ||||
-rw-r--r-- | android/variable.go | 2 | ||||
-rw-r--r-- | cc/config/arm64_device.go | 11 | ||||
-rw-r--r-- | cc/config/arm_device.go | 7 |
4 files changed, 23 insertions, 4 deletions
diff --git a/android/config.go b/android/config.go index 032172d6e..9920fe41b 100644 --- a/android/config.go +++ b/android/config.go @@ -174,6 +174,13 @@ func (c Config) RunningInsideUnitTest() bool { return c.config.TestProductVariables != nil } +// MaxPageSizeSupported returns the max page size supported by the device. This +// value will define the ELF segment alignment for binaries (executables and +// shared libraries). +func (c Config) MaxPageSizeSupported() string { + return String(c.config.productVariables.DeviceMaxPageSizeSupported) +} + // A DeviceConfig object represents the configuration for a particular device // being built. For now there will only be one of these, but in the future there // may be multiple devices being built. diff --git a/android/variable.go b/android/variable.go index 249d53b07..d7152b367 100644 --- a/android/variable.go +++ b/android/variable.go @@ -218,6 +218,7 @@ type productVariables struct { DeviceVndkVersion *string `json:",omitempty"` DeviceCurrentApiLevelForVendorModules *string `json:",omitempty"` DeviceSystemSdkVersions []string `json:",omitempty"` + DeviceMaxPageSizeSupported *string `json:",omitempty"` RecoverySnapshotVersion *string `json:",omitempty"` @@ -505,6 +506,7 @@ func (v *productVariables) SetDefaultConfig() { DeviceSecondaryArchVariant: stringPtr("armv8-a"), DeviceSecondaryCpuVariant: stringPtr("generic"), DeviceSecondaryAbi: []string{"armeabi-v7a", "armeabi"}, + DeviceMaxPageSizeSupported: stringPtr("4096"), AAPTConfig: []string{"normal", "large", "xlarge", "hdpi", "xhdpi", "xxhdpi"}, AAPTPreferredConfig: stringPtr("xhdpi"), diff --git a/cc/config/arm64_device.go b/cc/config/arm64_device.go index 28f368205..ca2e05fc3 100644 --- a/cc/config/arm64_device.go +++ b/cc/config/arm64_device.go @@ -53,8 +53,7 @@ var ( "-Wl,-z,separate-code", } - arm64Lldflags = append(arm64Ldflags, - "-Wl,-z,max-page-size=4096") + arm64Lldflags = arm64Ldflags arm64Cppflags = []string{} @@ -93,7 +92,13 @@ var ( func init() { exportedVars.ExportStringListStaticVariable("Arm64Ldflags", arm64Ldflags) - exportedVars.ExportStringListStaticVariable("Arm64Lldflags", arm64Lldflags) + + exportedVars.ExportStringList("Arm64Lldflags", arm64Lldflags) + pctx.VariableFunc("Arm64Lldflags", func(ctx android.PackageVarContext) string { + maxPageSizeFlag := "-Wl,-z,max-page-size=" + ctx.Config().MaxPageSizeSupported() + flags := append(arm64Lldflags, maxPageSizeFlag) + return strings.Join(flags, " ") + }) exportedVars.ExportStringListStaticVariable("Arm64Cflags", arm64Cflags) exportedVars.ExportStringListStaticVariable("Arm64Cppflags", arm64Cppflags) diff --git a/cc/config/arm_device.go b/cc/config/arm_device.go index 070455021..dec2b4552 100644 --- a/cc/config/arm_device.go +++ b/cc/config/arm_device.go @@ -185,7 +185,12 @@ func init() { exportedVars.ExportString("ArmClangTriple", clangTriple) exportedVars.ExportStringListStaticVariable("ArmLdflags", armLdflags) - exportedVars.ExportStringListStaticVariable("ArmLldflags", armLldflags) + exportedVars.ExportStringList("ArmLldflags", armLldflags) + pctx.VariableFunc("ArmLldflags", func(ctx android.PackageVarContext) string { + maxPageSizeFlag := "-Wl,-z,max-page-size=" + ctx.Config().MaxPageSizeSupported() + flags := append(armLldflags, maxPageSizeFlag) + return strings.Join(flags, " ") + }) exportedVars.ExportStringListStaticVariable("ArmFixCortexA8LdFlags", armFixCortexA8LdFlags) exportedVars.ExportStringListStaticVariable("ArmNoFixCortexA8LdFlags", armNoFixCortexA8LdFlags) |