diff options
author | Martin Stjernholm <mast@google.com> | 2020-04-06 22:57:21 +0100 |
---|---|---|
committer | Martin Stjernholm <mast@google.com> | 2020-04-06 23:03:53 +0100 |
commit | bdd0dffc1b93d137a7642998219e6e7849873218 (patch) | |
tree | 171c835636b75f1e8989703cf4f43f593b231f3a /cc/library_sdk_member.go | |
parent | dd22225b3ace43f2edc3e522b74180a85a4920d5 (diff) | |
download | soong-bdd0dffc1b93d137a7642998219e6e7849873218.tar.gz |
Do not propagate the stub symbol file to prebuilts.
This partially reverts https://r.android.com/1278193. The propagated
symbol files contain all versions, even though only one is applicable
in a given SDK snapshot.
It's uncertain what repercussions this might have, but one is that if
we were to update a snapshot for a fixed version then it might change
because the symbol file contains new versions that aren't applicable.
Since the symbol file isn't actually needed at this point it's better
to wait with this step until the use cases for it are more clear.
Test: m nothing
Test: Create an SDK snapshot with Bionic libs, drop it into a
master-art tree without bionic/ in it, build ART APEXes, and check
that the Soong phase completes (specifically that the stubs are
detected even without symbol files).
Bug: 152481980
Change-Id: Ic79f89bc6d11d0b6552fa20791f5680ff9a40c0d
Diffstat (limited to 'cc/library_sdk_member.go')
-rw-r--r-- | cc/library_sdk_member.go | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/cc/library_sdk_member.go b/cc/library_sdk_member.go index 4e4df5b0e..754b96a98 100644 --- a/cc/library_sdk_member.go +++ b/cc/library_sdk_member.go @@ -271,10 +271,7 @@ func addPossiblyArchSpecificProperties(sdkModuleContext android.ModuleContext, b } if len(libInfo.StubsVersion) > 0 { - symbolFilePath := filepath.Join(nativeEtcDir, libInfo.StubsSymbolFile.Path().Base()) - builder.CopyToSnapshot(libInfo.StubsSymbolFile.Path(), symbolFilePath) stubsSet := outputProperties.AddPropertySet("stubs") - stubsSet.AddProperty("symbol_file", symbolFilePath) stubsSet.AddProperty("versions", []string{libInfo.StubsVersion}) } } @@ -283,7 +280,6 @@ const ( nativeIncludeDir = "include" nativeGeneratedIncludeDir = "include_gen" nativeStubDir = "lib" - nativeEtcDir = "etc" ) // path to the native library. Relative to <sdk_root>/<api_dir> @@ -348,9 +344,6 @@ type nativeLibInfoProperties struct { // are not in use. StubsVersion string - // The stubs symbol file. - StubsSymbolFile android.OptionalPath - // outputFile is not exported as it is always arch specific. outputFile android.Path } @@ -389,7 +382,6 @@ func (p *nativeLibInfoProperties) PopulateFromVariant(ctx android.SdkMemberConte if ccModule.HasStubsVariants() { p.StubsVersion = ccModule.StubsVersion() - p.StubsSymbolFile = ccModule.StubsSymbolFile() } } |