diff options
author | Tiem Song <tiem@google.com> | 2017-10-23 15:20:43 -0700 |
---|---|---|
committer | Tiem Song <tiem@google.com> | 2017-10-23 15:20:43 -0700 |
commit | fed097c7c3494c5622632771c58225177231962a (patch) | |
tree | 98a7a3c2b41d86759adf88520d51280f2b10a0fb /security | |
parent | d8b5621640750f458b6c6f13f459b5c03dc4a7e6 (diff) | |
download | android-fed097c7c3494c5622632771c58225177231962a.tar.gz |
Re-add missing toolbar for FingerprintDialog sample.
Additional minor changes:
- Set MainActivity as a parent for SettingsActivity
- XML spacing
- Redundant casts cleanup
Bug: 67894161
Test: Manual, verified app builds + runs and toolbar is available
Change-Id: I89b2fbd9308796a49392b06895801bebced92a5e
Diffstat (limited to 'security')
4 files changed, 95 insertions, 82 deletions
diff --git a/security/FingerprintDialog/Application/src/main/AndroidManifest.xml b/security/FingerprintDialog/Application/src/main/AndroidManifest.xml index 337f6419..218c190e 100644 --- a/security/FingerprintDialog/Application/src/main/AndroidManifest.xml +++ b/security/FingerprintDialog/Application/src/main/AndroidManifest.xml @@ -31,7 +31,8 @@ <activity android:name=".MainActivity" - android:label="@string/application_name"> + android:label="@string/application_name" + android:theme="@style/Theme.AppCompat.Light.NoActionBar"> <intent-filter> <action android:name="android.intent.action.MAIN" /> <category android:name="android.intent.category.LAUNCHER" /> @@ -40,6 +41,7 @@ <activity android:name=".SettingsActivity" - android:label="@string/action_settings" /> + android:label="@string/action_settings" + android:parentActivityName=".MainActivity"/> </application> </manifest> diff --git a/security/FingerprintDialog/Application/src/main/java/com/example/android/fingerprintdialog/MainActivity.java b/security/FingerprintDialog/Application/src/main/java/com/example/android/fingerprintdialog/MainActivity.java index 400b2d69..e30b4c22 100644 --- a/security/FingerprintDialog/Application/src/main/java/com/example/android/fingerprintdialog/MainActivity.java +++ b/security/FingerprintDialog/Application/src/main/java/com/example/android/fingerprintdialog/MainActivity.java @@ -16,7 +16,6 @@ package com.example.android.fingerprintdialog; -import android.app.Activity; import android.app.KeyguardManager; import android.content.Intent; import android.content.SharedPreferences; @@ -28,6 +27,8 @@ import android.security.keystore.KeyGenParameterSpec; import android.security.keystore.KeyPermanentlyInvalidatedException; import android.security.keystore.KeyProperties; import android.support.annotation.Nullable; +import android.support.v7.app.AppCompatActivity; +import android.support.v7.widget.Toolbar; import android.util.Base64; import android.util.Log; import android.view.Menu; @@ -57,7 +58,7 @@ import javax.crypto.SecretKey; /** * Main entry point for the sample, showing a backpack and "Purchase" button. */ -public class MainActivity extends Activity { +public class MainActivity extends AppCompatActivity { private static final String TAG = MainActivity.class.getSimpleName(); @@ -74,6 +75,8 @@ public class MainActivity extends Activity { protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); setContentView(R.layout.activity_main); + Toolbar toolbar = findViewById(R.id.toolbar); + setSupportActionBar(toolbar); try { mKeyStore = KeyStore.getInstance("AndroidKeyStore"); @@ -102,9 +105,8 @@ public class MainActivity extends Activity { KeyguardManager keyguardManager = getSystemService(KeyguardManager.class); FingerprintManager fingerprintManager = getSystemService(FingerprintManager.class); - Button purchaseButton = (Button) findViewById(R.id.purchase_button); - Button purchaseButtonNotInvalidated = (Button) findViewById( - R.id.purchase_button_not_invalidated); + Button purchaseButton = findViewById(R.id.purchase_button); + Button purchaseButtonNotInvalidated = findViewById(R.id.purchase_button_not_invalidated); if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) { purchaseButtonNotInvalidated.setEnabled(true); @@ -115,8 +117,7 @@ public class MainActivity extends Activity { // Hide the purchase button which uses a non-invalidated key // if the app doesn't work on Android N preview purchaseButtonNotInvalidated.setVisibility(View.GONE); - findViewById(R.id.purchase_button_not_invalidated_description) - .setVisibility(View.GONE); + findViewById(R.id.purchase_button_not_invalidated_description).setVisibility(View.GONE); } if (!keyguardManager.isKeyguardSecure()) { @@ -138,7 +139,8 @@ public class MainActivity extends Activity { purchaseButton.setEnabled(false); // This happens when no fingerprints are registered. Toast.makeText(this, - "Go to 'Settings -> Security -> Fingerprint' and register at least one fingerprint", + "Go to 'Settings -> Security -> Fingerprint' and register at least one" + + " fingerprint", Toast.LENGTH_LONG).show(); return; } @@ -195,7 +197,7 @@ public class MainActivity extends Activity { private void showConfirmation(byte[] encrypted) { findViewById(R.id.confirmation_message).setVisibility(View.VISIBLE); if (encrypted != null) { - TextView v = (TextView) findViewById(R.id.encrypted_message); + TextView v = findViewById(R.id.encrypted_message); v.setVisibility(View.VISIBLE); v.setText(Base64.encodeToString(encrypted, 0 /* flags */)); } diff --git a/security/FingerprintDialog/Application/src/main/java/com/example/android/fingerprintdialog/SettingsActivity.java b/security/FingerprintDialog/Application/src/main/java/com/example/android/fingerprintdialog/SettingsActivity.java index 08b39114..4ac88462 100644 --- a/security/FingerprintDialog/Application/src/main/java/com/example/android/fingerprintdialog/SettingsActivity.java +++ b/security/FingerprintDialog/Application/src/main/java/com/example/android/fingerprintdialog/SettingsActivity.java @@ -16,11 +16,11 @@ package com.example.android.fingerprintdialog; -import android.app.Activity; import android.os.Bundle; import android.preference.PreferenceFragment; +import android.support.v7.app.AppCompatActivity; -public class SettingsActivity extends Activity { +public class SettingsActivity extends AppCompatActivity { @Override protected void onCreate(Bundle savedInstanceState) { diff --git a/security/FingerprintDialog/Application/src/main/res/layout/activity_main.xml b/security/FingerprintDialog/Application/src/main/res/layout/activity_main.xml index f0a596fc..130bc8c7 100644 --- a/security/FingerprintDialog/Application/src/main/res/layout/activity_main.xml +++ b/security/FingerprintDialog/Application/src/main/res/layout/activity_main.xml @@ -14,71 +14,80 @@ ~ See the License for the specific language governing permissions and ~ limitations under the License --> -<ScrollView - xmlns:android="http://schemas.android.com/apk/res/android" - android:layout_width="match_parent" - android:layout_height="match_parent"> +<ScrollView xmlns:android="http://schemas.android.com/apk/res/android" + android:layout_width="match_parent" + android:layout_height="match_parent" + xmlns:app="http://schemas.android.com/apk/res-auto"> <LinearLayout + android:layout_width="match_parent" + android:layout_height="wrap_content" + android:orientation="vertical"> + + <android.support.v7.widget.Toolbar + android:id="@+id/toolbar" android:layout_width="match_parent" - android:layout_height="wrap_content" - android:orientation="vertical"> + android:layout_height="?attr/actionBarSize" + android:background="?attr/colorPrimary" + android:elevation="4dp" + android:theme="@style/ThemeOverlay.AppCompat.ActionBar" + app:popupTheme="@style/ThemeOverlay.AppCompat.Light"/> <ImageView - android:layout_width="150dp" - android:layout_height="150dp" - android:layout_marginTop="32dp" - android:layout_marginBottom="32dp" - android:layout_gravity="center_horizontal" - android:scaleType="fitCenter" - android:src="@drawable/android_robot" - android:contentDescription="@string/description_bugdroid_icon"/> + android:layout_width="150dp" + android:layout_height="150dp" + android:layout_marginTop="32dp" + android:layout_marginBottom="32dp" + android:layout_gravity="center_horizontal" + android:scaleType="fitCenter" + android:src="@drawable/android_robot" + android:contentDescription="@string/description_bugdroid_icon"/> <LinearLayout - android:layout_width="match_parent" - android:layout_height="wrap_content" - android:layout_marginTop="8dp" - android:layout_marginStart="8dp" - android:layout_marginEnd="8dp" - android:orientation="vertical" - android:background="@drawable/card" - android:elevation="4dp" - android:paddingTop="16dp" - android:paddingBottom="16dp" - android:paddingStart="16dp" - android:paddingEnd="16dp"> + android:layout_width="match_parent" + android:layout_height="wrap_content" + android:layout_marginTop="8dp" + android:layout_marginStart="8dp" + android:layout_marginEnd="8dp" + android:orientation="vertical" + android:background="@drawable/card" + android:elevation="4dp" + android:paddingTop="16dp" + android:paddingBottom="16dp" + android:paddingStart="16dp" + android:paddingEnd="16dp"> <TextView - android:layout_width="wrap_content" - android:layout_height="wrap_content" - android:textAppearance="@android:style/TextAppearance.Material.Headline" - android:text="@string/item_title"/> + android:layout_width="wrap_content" + android:layout_height="wrap_content" + android:textAppearance="@android:style/TextAppearance.Material.Headline" + android:text="@string/item_title"/> <TextView - android:layout_width="wrap_content" - android:layout_height="wrap_content" - android:textAppearance="@android:style/TextAppearance.Material.Body2" - android:textColor="?android:attr/colorAccent" - android:text="@string/item_price"/> + android:layout_width="wrap_content" + android:layout_height="wrap_content" + android:textAppearance="@android:style/TextAppearance.Material.Body2" + android:textColor="?android:attr/colorAccent" + android:text="@string/item_price"/> <TextView - android:layout_width="wrap_content" - android:layout_height="wrap_content" - android:layout_marginTop="16dp" - android:textAppearance="@android:style/TextAppearance.Material.Body1" - android:textColor="?android:attr/textColorSecondary" - android:text="@string/item_description"/> + android:layout_width="wrap_content" + android:layout_height="wrap_content" + android:layout_marginTop="16dp" + android:textAppearance="@android:style/TextAppearance.Material.Body1" + android:textColor="?android:attr/textColorSecondary" + android:text="@string/item_description"/> </LinearLayout> <Button style="@android:style/Widget.Material.Button.Colored" - android:layout_width="wrap_content" - android:layout_height="wrap_content" - android:layout_marginTop="8dp" - android:layout_marginEnd="4dp" - android:layout_gravity="end" - android:textColor="?android:attr/textColorPrimaryInverse" - android:text="@string/purchase" - android:id="@+id/purchase_button" /> + android:layout_width="wrap_content" + android:layout_height="wrap_content" + android:layout_marginTop="8dp" + android:layout_marginEnd="4dp" + android:layout_gravity="end" + android:textColor="?android:attr/textColorPrimaryInverse" + android:text="@string/purchase" + android:id="@+id/purchase_button" /> <Button style="@android:style/Widget.Material.Button.Colored" android:layout_width="wrap_content" @@ -101,27 +110,27 @@ /> <TextView - android:id="@+id/confirmation_message" - android:layout_width="wrap_content" - android:layout_height="wrap_content" - android:layout_marginTop="16dp" - android:paddingStart="16dp" - android:paddingEnd="16dp" - android:textAppearance="@android:style/TextAppearance.Material.Body2" - android:textColor="?android:attr/colorAccent" - android:text="@string/purchase_done" - android:visibility="gone"/> + android:id="@+id/confirmation_message" + android:layout_width="wrap_content" + android:layout_height="wrap_content" + android:layout_marginTop="16dp" + android:paddingStart="16dp" + android:paddingEnd="16dp" + android:textAppearance="@android:style/TextAppearance.Material.Body2" + android:textColor="?android:attr/colorAccent" + android:text="@string/purchase_done" + android:visibility="gone"/> <TextView - android:id="@+id/encrypted_message" - android:layout_width="wrap_content" - android:layout_height="wrap_content" - android:layout_marginTop="16dp" - android:paddingStart="16dp" - android:paddingEnd="16dp" - android:textAppearance="@android:style/TextAppearance.Material.Body2" - android:textColor="?android:attr/colorAccent" - android:text="@string/purchase_done" - android:visibility="gone"/> + android:id="@+id/encrypted_message" + android:layout_width="wrap_content" + android:layout_height="wrap_content" + android:layout_marginTop="16dp" + android:paddingStart="16dp" + android:paddingEnd="16dp" + android:textAppearance="@android:style/TextAppearance.Material.Body2" + android:textColor="?android:attr/colorAccent" + android:text="@string/purchase_done" + android:visibility="gone"/> </LinearLayout> </ScrollView>
\ No newline at end of file |