summaryrefslogtreecommitdiff
path: root/cras/examples
diff options
context:
space:
mode:
authorChinyue Chen <chinyue@chromium.org>2015-05-08 16:50:26 +0800
committerChromeOS Commit Bot <chromeos-commit-bot@chromium.org>2015-05-08 16:16:35 +0000
commit14b6cc953cece9c60efe0b2076b78d9cb6ff8479 (patch)
treeb80a3eb1d0e2efa0f52e21c446c81f52878ad3be /cras/examples
parent0976fa795efc451318f68fb77892838b72cd6be7 (diff)
downloadadhd-14b6cc953cece9c60efe0b2076b78d9cb6ff8479.tar.gz
CRAS: example - Fix potential leak.
BUG=None TEST=make Change-Id: I2b8d2a2ac150428f66a7ed03a21c1af68fd6f93e Reviewed-on: https://chromium-review.googlesource.com/269986 Reviewed-by: Dylan Reid <dgreid@chromium.org> Commit-Queue: Chinyue Chen <chinyue@chromium.org> Trybot-Ready: Chinyue Chen <chinyue@chromium.org> Tested-by: Chinyue Chen <chinyue@chromium.org>
Diffstat (limited to 'cras/examples')
-rw-r--r--cras/examples/cplay.c5
-rw-r--r--cras/examples/cplay_buffer.c3
2 files changed, 5 insertions, 3 deletions
diff --git a/cras/examples/cplay.c b/cras/examples/cplay.c
index 0320316a..8b784474 100644
--- a/cras/examples/cplay.c
+++ b/cras/examples/cplay.c
@@ -53,7 +53,7 @@ int main(int argc, char **argv)
{
struct cras_client *client;
cras_stream_id_t stream_id;
- struct stream_data *data = malloc(sizeof(*data));
+ struct stream_data *data;
int rc = 0;
int fd;
const unsigned int block_size = 4800;
@@ -77,6 +77,7 @@ int main(int argc, char **argv)
return rc;
}
+ data = malloc(sizeof(*data));
data->fd = fd;
data->frame_bytes = 4;
@@ -85,7 +86,7 @@ int main(int argc, char **argv)
num_channels, NO_DEVICE, &stream_id);
if (rc < 0) {
fprintf(stderr, "adding a stream %d\n", rc);
- return rc;
+ goto destroy_exit;
}
/* At this point the stream has been added and audio callbacks will
diff --git a/cras/examples/cplay_buffer.c b/cras/examples/cplay_buffer.c
index 43b03814..98c63c15 100644
--- a/cras/examples/cplay_buffer.c
+++ b/cras/examples/cplay_buffer.c
@@ -46,6 +46,7 @@ int main(int argc, char **argv)
rc = cras_helper_create_connect(&client);
if (rc < 0) {
fprintf(stderr, "Couldn't create client.\n");
+ free(buffer);
close(fd);
return rc;
}
@@ -57,7 +58,7 @@ int main(int argc, char **argv)
CRAS_STREAM_OUTPUT));
if (rc < 0) {
fprintf(stderr, "playing a buffer %d\n", rc);
- return rc;
+ goto destroy_exit;
}
/* At this point the stream has been added and audio callbacks will