diff options
| author | En-Shuo Hsu <enshuo@chromium.org> | 2020-05-04 19:12:49 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-05-06 14:18:17 +0000 |
| commit | 84ae536ecede278e99ee3621e286ee8db5c6ccac (patch) | |
| tree | 6e01fe601d578a205a8a653b51049b5b59d14933 /cras | |
| parent | 864e5386249f4aad687fd786f34ce18f07212177 (diff) | |
| download | adhd-84ae536ecede278e99ee3621e286ee8db5c6ccac.tar.gz | |
CRAS: Respond Error if receive non-support AT+BIEV
According to HFP spec we should respond ERROR if HF send AT+BIEV
commands with indicator AG doesn't support.
This fixes the PTS test HFI/BI-03-1.
BUG=b:149188379
TEST=Run HFI/BI-03-1
Change-Id: Ic8babea8ccc1c8de6a1762fd6ffab354199ff29f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/2178808
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Commit-Queue: En-Shuo Hsu <enshuo@chromium.org>
Tested-by: En-Shuo Hsu <enshuo@chromium.org>
Diffstat (limited to 'cras')
| -rw-r--r-- | cras/src/server/cras_hfp_slc.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/cras/src/server/cras_hfp_slc.c b/cras/src/server/cras_hfp_slc.c index 25284174..7fb35847 100644 --- a/cras/src/server/cras_hfp_slc.c +++ b/cras/src/server/cras_hfp_slc.c @@ -774,13 +774,15 @@ static int indicator_state_change(struct hfp_slc_handle *handle, syslog(LOG_ERR, "Get invalid battery status from cmd:%s", cmd); } + } else { + goto error_out; } free(tokens); return hfp_send(handle, AT_CMD("OK")); error_out: - syslog(LOG_ERR, "%s: malformed command: '%s'", __func__, cmd); + syslog(LOG_WARNING, "%s: invalid command: '%s'", __func__, cmd); free(tokens); return hfp_send(handle, AT_CMD("ERROR")); } |