diff options
| author | Cheng-Yi Chiang <cychiang@chromium.org> | 2014-03-11 22:10:23 +0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-03-17 08:42:05 +0000 |
| commit | 14a75e49ac4aed5af5e2af61e9007885d2c65039 (patch) | |
| tree | a35ecf5ed253aaaded2fa03c7877400564a391a4 /scripts/audio_tuning | |
| parent | fee0261a882c659aaab25d98bad695755ab66cb2 (diff) | |
| download | adhd-14a75e49ac4aed5af5e2af61e9007885d2c65039.tar.gz | |
scripts: Fix audio-tuning frontend createMediaElementSource error
When audio file is played in a loop, we don't need to reset source node
in every loop. Now we just set the source node when there is a new file
url being set.
BUG=chrome-os-partner:26686
TEST=run audio-tuning frontend, check there is no error message
complaining audioContext.createMediaElementSource gets an invalid
argument. Also check that processing effect remains the same
when playing a file in a loop.
Change-Id: Ia75b732690a0d467be0c5096e78bef327780fd18
Reviewed-on: https://chromium-review.googlesource.com/189567
Reviewed-by: Chih-Chung Chang <chihchung@chromium.org>
Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Diffstat (limited to 'scripts/audio_tuning')
| -rw-r--r-- | scripts/audio_tuning/frontend/audio.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/audio_tuning/frontend/audio.js b/scripts/audio_tuning/frontend/audio.js index 4f09c1a2..5316c45c 100644 --- a/scripts/audio_tuning/frontend/audio.js +++ b/scripts/audio_tuning/frontend/audio.js @@ -886,6 +886,7 @@ function audio_source_set(url) { player.controls = true; player.addEventListener('canplay', audio_source_canplay); container.appendChild(player); + update_source_node(player); player.src = url; player.load(); @@ -896,7 +897,6 @@ function audio_source_canplay() { var loading = document.getElementById('audio_loading'); loading.style.visibility = 'hidden'; player.play(); - update_source_node(player); } function update_source_node(mediaElement) { |