| Age | Commit message (Collapse) | Author |
|---|
|
implementation
The spec of WebAudio biquad filter "lowpass" and "highpass" has
been changed. Chrome's implementation was changed in 53.0.2768.0.
The new implementation uses the Audio EQ Cookbook formula, different
from the original one, but still expects Q in dB.
See https://github.com/WebAudio/web-audio-api/issues/771
This patch adds detection of the filter implementation. If the
browser uses the new formula, conversion of Q is made to
simulate the original filter frequency response with the new
formula. This ensures the audio-tuning playback is always
consistent with the current CRAS DSP implementation, on any
browser verion.
BUG=chrome-os-partner:55365
TEST=DRC/EQ testing on Chrome before/after the filter change
Change-Id: I3e67a9b87f94b228d173fa08dcaa0fe4df5ac64e
Signed-off-by: Ben Zhang <benzh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/367551
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
|
|
Use Google Drive API and Picker API to let user select file from Google
Drive.
The Picker API must be enabled in the appengine API console.
BUG=chromium:480768
TEST=Go to http://4.audio-tuning.appspot.com and play audio from Google
Drive
Change-Id: Iaa0ea2b08bfbe62b6f8241d3a736c83b70402494
Reviewed-on: https://chromium-review.googlesource.com/267778
Reviewed-by: Chih-Chung Chang <chihchung@chromium.org>
Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
|
|
In Chrome M42 and above, audio tag needs to have crossOrigin attribute
set to access audio source served from different origin.
Note that the header in the response from server should include
Access-Control-Allow-Origin: *.
Check crbug.com/477692 and crbug.com/477364 for detail.
BUG=chromium:480768
TEST=run audio_tuning webpage and check an url with CORS support can
play.
Change-Id: I3c1cbf0ab8bb252ed4a848278dd389e6e52c8b2d
Reviewed-on: https://chromium-review.googlesource.com/267724
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
|
|
webkitAudioContext is renamed to AudioContext.
webkitOfflineAudioContext is renamed to OfflineAudioContext.
createGainNode in AudioConext is renamed to createGain.
This CL fixes those element names so the site can work with both old and
new version.
Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
BUG=chromium:365989
TEST=run audio-tuning site on ubuntu desktop and chromeos
Change-Id: Icd18cac04e7db9549c5d307e21bfde8ab764bcfe
Reviewed-on: https://chromium-review.googlesource.com/196469
Reviewed-by: Chih-Chung Chang <chihchung@chromium.org>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
|
|
When audio file is played in a loop, we don't need to reset source node
in every loop. Now we just set the source node when there is a new file
url being set.
BUG=chrome-os-partner:26686
TEST=run audio-tuning frontend, check there is no error message
complaining audioContext.createMediaElementSource gets an invalid
argument. Also check that processing effect remains the same
when playing a file in a loop.
Change-Id: Ia75b732690a0d467be0c5096e78bef327780fd18
Reviewed-on: https://chromium-review.googlesource.com/189567
Reviewed-by: Chih-Chung Chang <chihchung@chromium.org>
Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
|
|
When setting config from UI or applying config from config file,
drc.emphasis_disabled should be skipped since it is a tag and is
different from other configs that can actually be set to the audio
processing graph.
BUG=chrome-os-partner:26686
TEST=run audio-tuning frontend and check console there is no error
message complaining 'config' is not defined.
Change-Id: Ia7cbfc09fb7a904bb81abd0ae9b44a9f4524e3f0
Reviewed-on: https://chromium-review.googlesource.com/189566
Reviewed-by: Chih-Chung Chang <chihchung@chromium.org>
Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
|
|
Currently drc.disable_emphasis is detected when user plays audio file.
It should be detected in the webpage load time.
Also, before disable_emphasis detection is done, save_config button
should be disabled.
When saving config, drc.disable_emphasis value should come from the
variable which set by get_disable_emphasis function so that value
will be not be changed when user loads a config file.
BUG=chrome-os-partner:26686
TEST=run audio-tuning ui, save config and check drc.emphasis_disabled is
in the config. Load a config with different drc.emphasis_disabled, then
save config. Check drc.emphasis_disabled is not affected.
Change-Id: I692534260f75df9e1632bb9d5a493ac048ba725a
Reviewed-on: https://chromium-review.googlesource.com/189565
Reviewed-by: Chih-Chung Chang <chihchung@chromium.org>
Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
|
|
There is a new parameter emphasis_disabled in drc. This patch modifies
conf2ini2.py script so it honors the "drc.emphasis_disabled" in config
file generated by new http://audio-tuning.appspot.com/ and generate
dsp.ini file containing emphasis_disabled in input_4 of [drc].
BUG=chrome-os-partner:25940
TEST=run conf2ini2 file on config file with "drc.emphasis_disabled": 0,
check output contains "intput_4=0 ; emphasis_disabled" in [drc]
section.
Change-Id: I12347f9a7215c2fbcdb65588a32f327cd29737e5
Reviewed-on: https://chromium-review.googlesource.com/186858
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
|
|
There is a new parameter "emphasis_disabled" in drc. This patch modifies
audio.js file in audio_tuning webpage such that it will check if
emphasis/disemphasis is disabled in chrome, then determine
drc.emphasis_disabled config value.
BUG=chrome-os-partner:25940
TEST=run audio_tuning webpage with modified audio.js. Checks that the
output config contains "drc.emphasis_disabled": 0 for chrome without
https://codereview.chromium.org/152333003/, and contains
"drc.emphasis_disabled": 1 for chrome with
https://codereview.chromium.org/152333003/.
Change-Id: I6ef355a1d7cd6a4ac340f711d4270a6a88d42b27
Reviewed-on: https://chromium-review.googlesource.com/186857
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
|
|
Initial commit for source code at http://audio-tuning.appspot.com/
BUG=chrome-os-partner:25940
TEST=serve audio.html webpage and connect to it to generate a config
file.
Change-Id: Id05f08c300aec70dc502281a0f26b3135d68f60b
Reviewed-on: https://chromium-review.googlesource.com/186865
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
|
|
Add conf2ini2.py script to handle config file to ini file conversion.
The config file obtained from calibration webpage
http://audio-tuning.appspot.com should be converted to dsp.ini file
using this script.
BUG=chrome-os-partner:25940
TEST=run conf2ini2.py on config file generated by
http://audio-tuning.appspot.com
Change-Id: I747952643def774090855f4fe63f9b7b3997bdc7
Reviewed-on: https://chromium-review.googlesource.com/186864
Reviewed-by: Chih-Chung Chang <chihchung@chromium.org>
Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
|
