aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRoman Lavrov <romanl@google.com>2023-04-20 12:12:10 -0400
committerAngle LUCI CQ <angle-scoped@luci-project-accounts.iam.gserviceaccount.com>2023-04-20 17:39:10 +0000
commit362c70238251c3610a1668b9f4c91f422d7d7f24 (patch)
tree476bba260a48e298a83f019dab6478cdb22c80dc
parent37ea63174b6ffe9102b03604901873ca14f506c4 (diff)
downloadangle-362c70238251c3610a1668b9f4c91f422d7d7f24.tar.gz
When asserts enabled, log validation errors as WARN
These messages are useful for debugging but INFO() doesn't get logged at all (e.g. when using flags from linux-test CI) Bug: None Change-Id: I7fc02e866fc304c1e925becff58b71345d34238b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4456067 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
-rw-r--r--src/libANGLE/Context.cpp7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/libANGLE/Context.cpp b/src/libANGLE/Context.cpp
index 0b1e9f462a..d03a2625c3 100644
--- a/src/libANGLE/Context.cpp
+++ b/src/libANGLE/Context.cpp
@@ -10255,10 +10255,13 @@ void ErrorSet::validationError(angle::EntryPoint entryPoint, GLenum errorCode, c
{
ASSERT(errorCode != GL_NO_ERROR);
mErrors.insert(errorCode);
-
+ gl::LogSeverity severity = gl::LOG_INFO;
+#if defined(ANGLE_ENABLE_ASSERTS)
+ severity = gl::LOG_WARN;
+#endif // defined(ANGLE_ENABLE_ASSERTS)
mContext->getState().getDebug().insertMessage(GL_DEBUG_SOURCE_API, GL_DEBUG_TYPE_ERROR,
errorCode, GL_DEBUG_SEVERITY_HIGH, message,
- gl::LOG_INFO, entryPoint);
+ severity, entryPoint);
}
bool ErrorSet::empty() const