diff options
| author | Zequan Wu <zequanwu@google.com> | 2021-09-03 23:30:52 +0000 |
|---|---|---|
| committer | Angle LUCI CQ <angle-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2021-09-04 02:02:34 +0000 |
| commit | 178b8481d6465549d4dcfdd3190dcc9146f88225 (patch) | |
| tree | 0a88183134b300b1d4ca68920b0d8e5fe2f14caa | |
| parent | 3ae1f33606d674e81aeda7f952b190332955d8ba (diff) | |
| download | angle-178b8481d6465549d4dcfdd3190dcc9146f88225.tar.gz | |
Revert "Skip validation of stderr in TestSuiteTest.RunFlakyTests"
This reverts commit 89dbbb2ac6875c92c99feb24353641142bbd49b1.
Reason for revert: The test failure was gone in latest clang roll.
Original change's description:
> Skip validation of stderr in TestSuiteTest.RunFlakyTests
>
> There is a bug (crbug.com/1234124) causing the profile runtime to print
> errors about failing to write the profraw file. Don't validate stderr in
> these builds until that is fixed.
>
> Bug: chromium:1234124
> Change-Id: Ie1e3a3eaf7dc0e2c20064822f774cc85fe79d3bc
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076479
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: chromium:1234124
Change-Id: If33e92b533c99677d2b8f55de618ecf15e3f19d2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3141973
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
| -rw-r--r-- | src/tests/test_utils/runner/TestSuite_unittest.cpp | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/tests/test_utils/runner/TestSuite_unittest.cpp b/src/tests/test_utils/runner/TestSuite_unittest.cpp index f1310531c7..db9885f98e 100644 --- a/src/tests/test_utils/runner/TestSuite_unittest.cpp +++ b/src/tests/test_utils/runner/TestSuite_unittest.cpp @@ -109,11 +109,8 @@ TEST_F(TestSuiteTest, RunMockTests) { std::vector<std::string> extraArgs = {"--gtest_filter=MockTestSuiteTest.DISABLED_*"}; - // TODO(crbug.com/1234124): Clang's profile runtime currently emits warnings to stderr, so we - // can't validate the stderr output in those builds. Remove this when that is fixed. - bool validateStderr = false; TestResults actual; - ASSERT_TRUE(runTestSuite(extraArgs, &actual, validateStderr)); + ASSERT_TRUE(runTestSuite(extraArgs, &actual, true)); std::map<TestIdentifier, TestResult> expectedResults = { {{"MockTestSuiteTest", "DISABLED_Pass"}, {TestResultType::Pass, 0.0}}, |