diff options
| author | Jamie Madill <jmadill@chromium.org> | 2021-07-16 10:33:57 -0400 |
|---|---|---|
| committer | Angle LUCI CQ <angle-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2021-07-16 17:02:36 +0000 |
| commit | dd0e8a1fc0a73d3c0b168752dbc92767cc39c2cb (patch) | |
| tree | cb167e6a76c680d00b3dfca23b49262370c0d730 | |
| parent | 2a713d929969dba4d31035b0cbfc54e7da45514b (diff) | |
| download | angle-dd0e8a1fc0a73d3c0b168752dbc92767cc39c2cb.tar.gz | |
Capture/Replay tests: Enable dcheck_always_on.
This will enable release ASSERTs. ASSERTs were unintentionally
disabled when switching to release builds.
Bug: angleproject:5133
Change-Id: Ie19e9fd02624b10283192467c4e22e3cf2b382c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035521
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
| -rwxr-xr-x | src/tests/capture_replay_tests.py | 10 | ||||
| -rw-r--r-- | src/tests/capture_replay_tests/capture_replay_expectations.txt | 1 |
2 files changed, 8 insertions, 3 deletions
diff --git a/src/tests/capture_replay_tests.py b/src/tests/capture_replay_tests.py index 7b46ab4158..6965fb977b 100755 --- a/src/tests/capture_replay_tests.py +++ b/src/tests/capture_replay_tests.py @@ -259,8 +259,11 @@ class ChildProcessesManager(): def RunGNGen(self, args, build_dir, pipe_stdout, extra_gn_args=[]): gn_args = [('use_goma', str(args.use_goma).lower()), - ('angle_with_capture_by_default', 'true'), - ('is_debug', 'false')] + extra_gn_args + ('angle_with_capture_by_default', 'true')] + extra_gn_args + if not args.debug: + gn_args.append(('is_debug', 'false')) + gn_args.append(('symbol_level', '1')) + gn_args.append(('dcheck_always_on', 'true')) if args.goma_dir: gn_args.append(('goma_dir', '"%s"' % args.goma_dir)) if args.asan: @@ -559,7 +562,7 @@ class TestBatch(): # CaptureReplayTests.cpp self.CreateTestsCompositeFiles(composite_file_id, tests) - gn_args = [('angle_build_capture_replay_tests', 'true'), ('symbol_level', '1'), + gn_args = [('angle_build_capture_replay_tests', 'true'), ('angle_capture_replay_test_trace_dir', '"%s"' % self.trace_dir), ('angle_capture_replay_composite_file_id', str(composite_file_id))] returncode, output = child_processes_manager.RunGNGen(self.args, replay_build_dir, True, @@ -1043,6 +1046,7 @@ if __name__ == "__main__": parser.add_argument('--asan', action='store_true', help='Build with ASAN.') parser.add_argument( '--show-capture-stdout', action='store_true', help='Print test stdout during capture.') + parser.add_argument('--debug', action='store_true', help='Debug builds (default is Release).') args = parser.parse_args() if platform == "win32": args.test_suite += ".exe" diff --git a/src/tests/capture_replay_tests/capture_replay_expectations.txt b/src/tests/capture_replay_tests/capture_replay_expectations.txt index bf3c6b4436..e0477571b7 100644 --- a/src/tests/capture_replay_tests/capture_replay_expectations.txt +++ b/src/tests/capture_replay_tests/capture_replay_expectations.txt @@ -53,6 +53,7 @@ GLSLTest.ZeroShaderLength/* GPUTestConfigTest.GPUTestConfigConditions_D3D11/* ImageTest.SourceCubeTargetExternal/* PBOExtensionTest.* +RobustBufferAccessBehaviorTest.* Texture2DTest.DefineMultipleLevelsWithoutMipmapping/* VertexAttributeTest.* |