diff options
| author | Gert Wollny <gert.wollny@collabora.com> | 2021-07-15 13:46:54 +0200 |
|---|---|---|
| committer | Angle LUCI CQ <angle-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2021-07-16 11:21:57 +0000 |
| commit | 044856565e688373cacc8cc988c87a6f6c9d625b (patch) | |
| tree | d0d025183cef7a3dd62c303b67434d069157924b | |
| parent | 1e75181f31bc326de22ec787687396984b668593 (diff) | |
| download | angle-044856565e688373cacc8cc988c87a6f6c9d625b.tar.gz | |
Capture/Replay: Capture WaitSemaphore and SignalSemaphore
Enable tests that now pass, but keep tests that time out or
still crash on the skip list.
Bug: angleproject:6164
Change-Id: I39e56f0a1bfae09c74a54b06367f7eef41d1063c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3024208
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
| -rw-r--r-- | src/libANGLE/capture/capture_gles_ext_params.cpp | 13 | ||||
| -rw-r--r-- | src/tests/capture_replay_tests/capture_replay_expectations.txt | 9 |
2 files changed, 15 insertions, 7 deletions
diff --git a/src/libANGLE/capture/capture_gles_ext_params.cpp b/src/libANGLE/capture/capture_gles_ext_params.cpp index 19a0484069..2b6509595b 100644 --- a/src/libANGLE/capture/capture_gles_ext_params.cpp +++ b/src/libANGLE/capture/capture_gles_ext_params.cpp @@ -2610,7 +2610,7 @@ void CaptureSignalSemaphoreEXT_buffersPacked(const State &glState, const GLenum *dstLayouts, ParamCapture *paramCapture) { - UNIMPLEMENTED(); + CaptureArray(buffers, numBufferBarriers, paramCapture); } void CaptureSignalSemaphoreEXT_texturesPacked(const State &glState, @@ -2623,7 +2623,7 @@ void CaptureSignalSemaphoreEXT_texturesPacked(const State &glState, const GLenum *dstLayouts, ParamCapture *paramCapture) { - UNIMPLEMENTED(); + CaptureArray(textures, numTextureBarriers, paramCapture); } void CaptureSignalSemaphoreEXT_dstLayouts(const State &glState, @@ -2636,7 +2636,8 @@ void CaptureSignalSemaphoreEXT_dstLayouts(const State &glState, const GLenum *dstLayouts, ParamCapture *paramCapture) { - UNIMPLEMENTED(); + CaptureArray(dstLayouts, (numBufferBarriers + numTextureBarriers) * sizeof(GLenum), + paramCapture); } void CaptureWaitSemaphoreEXT_buffersPacked(const State &glState, @@ -2649,7 +2650,7 @@ void CaptureWaitSemaphoreEXT_buffersPacked(const State &glState, const GLenum *srcLayouts, ParamCapture *paramCapture) { - UNIMPLEMENTED(); + CaptureArray(buffers, numBufferBarriers, paramCapture); } void CaptureWaitSemaphoreEXT_texturesPacked(const State &glState, @@ -2662,7 +2663,7 @@ void CaptureWaitSemaphoreEXT_texturesPacked(const State &glState, const GLenum *srcLayouts, ParamCapture *paramCapture) { - UNIMPLEMENTED(); + CaptureArray(textures, numTextureBarriers, paramCapture); } void CaptureWaitSemaphoreEXT_srcLayouts(const State &glState, @@ -2675,7 +2676,7 @@ void CaptureWaitSemaphoreEXT_srcLayouts(const State &glState, const GLenum *srcLayouts, ParamCapture *paramCapture) { - UNIMPLEMENTED(); + CaptureArray(srcLayouts, (numBufferBarriers + numTextureBarriers), paramCapture); } void CaptureGetSamplerParameterIivEXT_params(const State &glState, diff --git a/src/tests/capture_replay_tests/capture_replay_expectations.txt b/src/tests/capture_replay_tests/capture_replay_expectations.txt index 93cbe47b2d..4dbfb15caf 100644 --- a/src/tests/capture_replay_tests/capture_replay_expectations.txt +++ b/src/tests/capture_replay_tests/capture_replay_expectations.txt @@ -46,7 +46,14 @@ GPUTestConfigTest.GPUTestConfigConditions_D3D11/* ImageTest.SourceCubeTargetExternal/* PBOExtensionTest.* VertexAttributeTest.* -VulkanExternalImageTest.* + +# Crashes because closing the FD fails and this raises an assertion +VulkanExternalImageTest.ShouldImportSemaphoreOpaqueFd/ES2_Vulkan_SwiftShader + +# Replay times out +VulkanExternalImageTest.WaitSemaphoresRetainsContentOpaqueFd/ES2_Vulkan_SwiftShader +VulkanExternalImageTest.ShouldClearOpaqueFdWithSema*/ES2_Vulkan_SwiftShader +VulkanExternalImageTest.ShouldDrawOpaqueFdWithSemaphores/ES2_Vulkan_SwiftShader WebGLCompatibilityTest.MultiContextNoRenderingFeedbackLoops/* WebGLFramebufferTest.* |