diff options
| author | Yiwei Zhang <zzyiwei@chromium.org> | 2024-05-03 20:52:55 +0000 |
|---|---|---|
| committer | Angle LUCI CQ <angle-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2024-05-05 23:09:54 +0000 |
| commit | 465f6b7d2f3b4928cfe422d1cdd59b7aab1e2102 (patch) | |
| tree | 295af8a506581e00fc841e66feb6cd0514c1ae17 | |
| parent | 58742dfb79161a374aad7e1d58b53b1469ddf3be (diff) | |
| download | angle-465f6b7d2f3b4928cfe422d1cdd59b7aab1e2102.tar.gz | |
Android: forward visibility flags
This results in a 25~35% perf gain for gfxbench gl_driver2_off on x86
platforms. See also https://gcc.gnu.org/wiki/Visibility
Bug: b/331680143, b/333235176
Test: 25~35% gain in gfxbench gl_driver2_off score on x86
Change-Id: I5fb1174ae21f9feb33b8350e21f7cc5445b9cf25
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5513280
Reviewed-by: Roman Lavrov <romanl@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
| -rw-r--r-- | scripts/generate_android_bp.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/scripts/generate_android_bp.py b/scripts/generate_android_bp.py index 0b2635846f..c967ecb73f 100644 --- a/scripts/generate_android_bp.py +++ b/scripts/generate_android_bp.py @@ -294,6 +294,7 @@ def gn_cflags_to_blueprint_cflags(target_info): # regexs of allowlisted cflags cflag_allowlist = [ r'^-Wno-.*$', # forward cflags that disable warnings + r'^-fvisibility.*$', # forward visibility (https://gcc.gnu.org/wiki/Visibility) flags for better perf on x86 r'-mpclmul' # forward "-mpclmul" (used by zlib) ] |