aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-04-29Merge remote-tracking branch 'goog/master' into rvc-dev am: e0379aae9b am: ↵android-11.0.0_r48android-11.0.0_r47android-11.0.0_r46android-11.0.0_r45android-11.0.0_r44android-11.0.0_r43android-11.0.0_r42android-11.0.0_r41android-11.0.0_r40android-11.0.0_r39android-11.0.0_r38android-11.0.0_r37android-11.0.0_r36android-11.0.0_r35android-11.0.0_r34android-11.0.0_r33android-11.0.0_r32android-11.0.0_r31android-11.0.0_r30android-11.0.0_r29android-11.0.0_r28android-11.0.0_r27android-11.0.0_r26android-11.0.0_r24android-11.0.0_r23android-11.0.0_r22android-11.0.0_r21android-11.0.0_r20android-11.0.0_r19android-11.0.0_r18android11-qpr3-s1-releaseandroid11-qpr3-releaseandroid11-qpr2-releaseandroid11-qpr1-s2-releaseandroid11-qpr1-s1-releaseandroid11-qpr1-releaseandroid11-qpr1-d-s1-releaseandroid11-qpr1-d-releaseandroid11-qpr1-c-releaseandroid11-d2-releaseGeoff Lang
fff55c6819 Change-Id: Ie7aba6cc3c62eaea05a5a7bd233541cdc6b9e942
2020-04-29Merge remote-tracking branch 'goog/master' into rvc-dev am: e0379aae9bandroid-11.0.0_r16android11-d1-b-releaseGeoff Lang
Change-Id: I08848b2abf8b8b2990be510c82830a1f51d390e4
2020-04-29Merge remote-tracking branch 'goog/master' into rvc-devandroid-mainline-11.0.0_r44android-mainline-11.0.0_r43android-mainline-11.0.0_r42android-mainline-11.0.0_r41android-mainline-11.0.0_r40android-mainline-11.0.0_r39android-mainline-11.0.0_r38android-mainline-11.0.0_r37android-mainline-11.0.0_r36android-mainline-11.0.0_r35android-mainline-11.0.0_r34android-mainline-11.0.0_r32android-mainline-11.0.0_r31android-mainline-11.0.0_r30android-mainline-11.0.0_r28android-mainline-11.0.0_r27android-mainline-11.0.0_r26android-mainline-11.0.0_r25android-mainline-11.0.0_r24android-mainline-11.0.0_r23android-mainline-11.0.0_r22android-mainline-11.0.0_r21android-mainline-11.0.0_r20android-mainline-11.0.0_r18android-mainline-11.0.0_r17android-mainline-11.0.0_r16android-mainline-11.0.0_r15android-mainline-11.0.0_r14android-mainline-11.0.0_r13android-mainline-11.0.0_r12android11-mainline-tethering-releaseandroid11-mainline-permission-releaseandroid11-mainline-os-statsd-releaseandroid11-mainline-networkstack-releaseandroid11-mainline-media-swcodec-releaseandroid11-mainline-media-releaseandroid11-mainline-extservices-releaseandroid11-mainline-documentsui-releaseandroid11-mainline-conscrypt-releaseandroid11-mainline-cellbroadcast-releaseandroid11-mainline-captiveportallogin-releaseandroid11-devGeoff Lang
Bug: 0 Change-Id: Iab31fefc417ec663337c9b04987bff3aabfd5b17
2020-04-28Revert "Remove ANGLE from Developer Options"Courtney Goeltzenleuchter
This reverts commit 1c0aed17d767b3f9813b8c1ca3dc880386132c41. We want ANGLE Developer options in master. Bug: 154951060 Test: Manually verified ANGLE is present. Change-Id: Ib53e11a011e7c283c710257d9bfa55cc12bae98f
2020-04-28Add license type: contains GPL+LGPL = RESTRICTED am: 7fe299adf9 am: ↵Bob Badour
2471a08fad am: 50261badc5 am: 8bcda2f549 am: 10e251d2c5 Change-Id: I4af2e01db29d3afd07579682ffaf5e8b5ee71f13
2020-04-28Add license type: contains GPL+LGPL = RESTRICTED am: 7fe299adf9 am: ↵Bob Badour
2471a08fad am: 50261badc5 am: 8bcda2f549 Change-Id: I18ec7a32219575536bc1c8fdaac9b4380eaa651d
2020-04-28Add license type: contains GPL+LGPL = RESTRICTED am: 7fe299adf9 am: ↵Bob Badour
2471a08fad am: 50261badc5 Change-Id: I476b6129fb910d1fc0cda39996c15c65e0dfd777
2020-04-28Add license type: contains GPL+LGPL = RESTRICTED am: 7fe299adf9 am: 2471a08fadBob Badour
Change-Id: I760e5748907657d964f48a8aca5dbf4fc78a756b
2020-04-28Add license type: contains GPL+LGPL = RESTRICTED am: 7fe299adf9Bob Badour
Change-Id: Ic48a8c6b4eb03bfe89b8d453395eddfd920da0d6
2020-04-23Add license type: contains GPL+LGPL = RESTRICTEDBob Badour
Bug: 68860345 Bug: 69058154 Bug: 151953481 Test: no code changes Change-Id: Ieb5248909c2c79e12450ef3c965d3972a14ea04b
2020-04-22Merge remote-tracking branch 'aosp/upstream-mirror' am: 727a9674f2 am: ↵Geoff Lang
dfc18b6661 am: 1a174352dd am: 6fb50989f6 am: 00ab640c44 Change-Id: I6d97b851ba16f62ebc3abe3bf3cef4297f1ee59d
2020-04-22Merge remote-tracking branch 'aosp/upstream-mirror' am: 727a9674f2 am: ↵Geoff Lang
dfc18b6661 am: 1a174352dd am: 6fb50989f6 Change-Id: Id59a53f037cc8c01190dee009a7396529e9ae04b
2020-04-22Merge remote-tracking branch 'aosp/upstream-mirror' am: 727a9674f2 am: ↵Geoff Lang
dfc18b6661 am: 1a174352dd Change-Id: I693dc0a1261130cd60e7d0fdd37a32669395b19f
2020-04-22Merge remote-tracking branch 'aosp/upstream-mirror' am: 727a9674f2 am: ↵Geoff Lang
dfc18b6661 Change-Id: I13362b5020667fe90233b4473b06e1409eec8cc5
2020-04-22Merge remote-tracking branch 'aosp/upstream-mirror' am: 727a9674f2Geoff Lang
Change-Id: I83ab57473e4de78e4fefb0a2c4cbf8c8e7a9e95e
2020-04-22Merge remote-tracking branch 'aosp/upstream-mirror'Geoff Lang
Change-Id: I2b8cd4c087463d92d8018f03fed89b60314f837f
2020-04-22Add capture support for FenceSyncCourtney Goeltzenleuchter
This allows us to capture Angry Birds 2 traces. Bug: b/153652100 Change-Id: I99a47f9e41a84218b3bb3d9740df4bb7fc2a01fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2144763 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
2020-04-22Roll third_party/vulkan-validation-layers/src 09f4b08483bb..36d7cca6fdc9 (1 ↵angle-autoroll
commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/09f4b08483bb..36d7cca6fdc9 git log 09f4b08483bb..36d7cca6fdc9 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 tony@lunarg.com layers: Fix renderpass2 tracking Created with: gclient setdep -r third_party/vulkan-validation-layers/src@36d7cca6fdc9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: Iddad6155212d216fb1bcee45006707a0ffc2d451 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2160273 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-22Roll third_party/SwiftShader ff772a7bcc98..ceb6258ae101 (1 commits)angle-autoroll
https://swiftshader.googlesource.com/SwiftShader.git/+log/ff772a7bcc98..ceb6258ae101 git log ff772a7bcc98..ceb6258ae101 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 amaiorano@google.com CMake: fix astc code not being enabled correctly Created with: gclient setdep -r third_party/SwiftShader@ceb6258ae101 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: I469606bfc8fd7433d14770f2158954ea8d78458a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2160274 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-22Roll third_party/glslang/src 3f4e5c456306..c9b28b9f3388 (1 commits)angle-autoroll
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3f4e5c456306..c9b28b9f3388 Created with: gclient setdep -r third_party/glslang/src@c9b28b9f3388 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: I82d61d8560b2d48d54f405d879aa20f5e8197f16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2160275 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-21Vulkan: Enable persistently mapped buffer objectsMohan Maiya
The VMA allocator has a handy feature where during memory allocation we can request persistently mapped memory. This saves IOCTL overhead for apps that update buffers frequently. Bug: angleproject:2162 Change-Id: I870d880033beec343efae6de06f1c5935de4c2c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2155131 Reviewed-by: Tobin Ehlis <tobine@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tobin Ehlis <tobine@google.com>
2020-04-21Vulkan: Allow commands to completely fill allocationTobin Ehlis
If the remaining allocation size for commands in the SecondaryCommandBuffer class is equal to the command allocation size and the follow-on header, then we can fill the allocation. Previously we were conservative and if the size needed exactly equals the size remaining, we would allocate a new block. Bug: b/154030403 Change-Id: Ie31f0f5d33782d12adbaea9e3b02598a004d7643 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158817 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com>
2020-04-21GL: Make sure primitive restart emulation is disabled below GL 3.1Geoff Lang
If the GL driver version is below 3.1, we cannot set the primitive restart fixed index (ES3 wont be supported anyway). Make sure the feature is disabled. Speculative fix for crbug.com/1073020 BUG=chromium:1073020 BUG=angleproject:3997 Change-Id: I67756b377aa951da2e70c26f7db978ede9010586 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2159289 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
2020-04-21Vulkan: Skip load if depth/stencil value are undefinedCharlie Lao
EGL1.5 spec says depth/stencil data are undefined after swap. This CL will track the depth/stencil data and mark it as undefined and skip the load if it is undefined. Bug: b/153885625 Change-Id: Ifb3d88d442da547fa78c1eae091cbae08a20d0ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2148179 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
2020-04-21Vulkan: Refactor SecondaryCommandBuffers classTobin Ehlis
A strictly cosmetic change to move code into alphabetical order. In working with SecondaryCommandBuffer commands in separate CLs, it can be difficult/annoying to track which commands are already in place as some of them are out-of-order. This change puts the command enums, functions, and processing in alphabetical order to simplify searching and adding new commands. Bug: b/154030403 Change-Id: I6dba4cf48d6f27c056585ac633c694e083b1a263 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158816 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tobin Ehlis <tobine@google.com>
2020-04-21Don't redefine VMA_IMPLEMENTATION in build files and sourceGeoff Lang
VMA_IMPLEMENTATION is defined in the build files, it doesn't need to be redefined in vk_mem_alloc_wrapper.cpp. BUG=angleproject:2162 Change-Id: Ie4eceedd2dd3051f8431c7c8c86403250e93f98b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2154538 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
2020-04-21Revert "Vulkan: Forward RenderBuffer/Surface dirty messages."Jamie Madill
This reverts commit 3fb33ade6ec8f286797bff5645304df580b1a963. Reason for revert: Causing WebGL test failures on GLES/ANGLE/Android. Bug: chromium:1072739 Original change's description: > Vulkan: Forward RenderBuffer/Surface dirty messages. > > Previously we were only forwarding Texture staging changes to the > Framebuffer for re-sync. We could miss out on clears that were staged > in Surfaces and Renderbuffer attachments. Complete the chain by making > the SurfaceVk and RenderbufferVk forward notifications from the > VkImage. > > Bug: angleproject:4517 > Change-Id: I15f36c225517e915f656d0c2464a99631ef9f945 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2150699 > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Commit-Queue: Jamie Madill <jmadill@chromium.org> TBR=cnorthrop@google.com,timvp@google.com,jmadill@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:4517 Change-Id: I4fd4d79dc11da0ba86065d3a80975de4c791a2a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2159288 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
2020-04-21Vulkan: Manual validation rollTobin Ehlis
Manually roll validation layers to latest and ignore two more VUIDs that are being flagged with latest layers. Bug: angleproject:4578 Bug: angleproject:4579 Bug: angleproject:4580 Change-Id: I4fc46d9df3fa3be4be1f8b773eb2d63e6f4bbd92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158265 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com>
2020-04-21Fix quotes around emails in WATCHLISTSGeoff Lang
Quotes were around the entire list of emails instead of around individual ones. Change-Id: Ice783622eb31981f606f49f57984a15771ace995 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2159290 Commit-Queue: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
2020-04-21CGL/EAGL: Fix default FBO size on Retina displaysCorentin Wallez
This was found while trying to fix https://github.com/glfw/glfw/issues/1169 VulkanSurfaceMtl and metal/SurfaceMtl already handle contentsScale correctly. Change-Id: I234d7b0901dd7c075cf1e9d58466f52140ab1e2b Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2154670 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-04-21Roll third_party/vulkan-loader/src 50eaecd721a2..4fb0e0374a39 (1 commits)angle-autoroll
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/50eaecd721a2..4fb0e0374a39 git log 50eaecd721a2..4fb0e0374a39 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 petr_kraus@email.cz docs: Fix link in interface docs Created with: gclient setdep -r third_party/vulkan-loader/src@4fb0e0374a39 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: I663809ab903c97827ccca4c8b9f290e59a0a1ffd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158781 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-21Roll third_party/spirv-tools/src 61b7de3c39f0..67f4838659f4 (1 commits)angle-autoroll
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/61b7de3c39f0..67f4838659f4 Created with: gclient setdep -r third_party/spirv-tools/src@67f4838659f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: I55e966b6836899c1fc656620c271b0f8d8db0b0a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158783 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-21Roll third_party/SwiftShader 068611f07d28..ff772a7bcc98 (1 commits)angle-autoroll
https://swiftshader.googlesource.com/SwiftShader.git/+log/068611f07d28..ff772a7bcc98 git log 068611f07d28..ff772a7bcc98 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 capn@google.com Don't use deprecated llvm::Type::getVectorNumElements() Created with: gclient setdep -r third_party/SwiftShader@ff772a7bcc98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: Icb8097e2c135d1dbb7dc3cd3258f65b28066cda3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158784 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-21Roll third_party/vulkan-tools/src 8824107d57d3..84463fe2902f (1 commits)angle-autoroll
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/8824107d57d3..84463fe2902f git log 8824107d57d3..84463fe2902f --date=short --first-parent --format='%ad %ae %s' 2020-04-20 petr_kraus@email.cz repo: Update the clang style from VVL Created with: gclient setdep -r third_party/vulkan-tools/src@84463fe2902f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: Ic492d090c5c2e1b5e75ed9ed5f586b23f4f13942 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158779 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-21Capture/Replay: More mid-execution capture supportCody Northrop
Test: Temple Run MEC capture and replay Bug: b/152512564 Bug: angleproject:3662 Change-Id: I31be6e7ad9d290c2077f2f4d975c2d66779eb558 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2155490 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
2020-04-21Capture/Replay: Handle default uniforms during MECCody Northrop
During mid-execution capture, when processing uniforms for a program, capture their values and repopulate during replay. Test: Temple Run MEC capture and replay Bug: b/152512564 Bug: angleproject:3662 Change-Id: If84711ead144b7c88710e6b12d0968e80e263c69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2155489 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
2020-04-21Capture/Replay: Use TexStorage for immutable imagesCody Northrop
When we detect a texture is immutable, create it with TexStorage and populate with TexSubImage. Test: Temple Run MEC capture and replay Bug: b/152512564 Bug: angleproject:3662 Change-Id: I1948a0376d2634957329d1da35d60ded3608479a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2155488 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
2020-04-20Vulkan: Suppress VUID-vkCmdClearColorImage-image-01993Tobin Ehlis
The latest VVL roll is generating many new errors for VUID-vkCmdClearColorImage-image-01993. This CL will suppress the error messages to prevent the test failures until they can be fixed. Bug: angleproject:4577 Change-Id: I3ea4986c1f43c7d7921761e537d6d51cac3327e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2157853 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com>
2020-04-20Vulkan: Use DontCare for the presentable surface's last renderpass ↵Charlie Lao
depth/stencil storeOp The EGL spec says depth/stencil value are undefined after swap. We dont need to store depth/stencil value if this is the very last renderpass of a presentable surface and the endRenderpass call is from swap call. Bug: b/153885625 Change-Id: Ie853d2686c8eb15a4fa9dbdd80eb66e9fc037d24 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2157886 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
2020-04-20doc: Update ANGLE Try Waterfall linksTobin Ehlis
Bug: angleproject:1944 Change-Id: I200ee1bbd2c1e856e97db24dff2ab550292ba248 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2157888 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Tobin Ehlis <tobine@google.com>
2020-04-20Vulkan: Use renderpass' finalLayout to transit to ImageLayout::PresentCharlie Lao
This detects the last renderpass is actually rendering to the image we are going to present and this is the very last renderpass to that image. We use finalLayout of the renderpass to do layout transition to VK_IMAGE_LAYOUT_PRESENT_SRC_KHR instead of a standalone barrier call. Bug: b/153885625 Change-Id: Ifc17c77a1ba12f22c9d6038775f3e254c35655ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2155250 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
2020-04-20Vulkan: Suppress VUID-vkCmdCopyImageToBuffer-srcImage-01998Tim Van Patten
The latest VVL roll is generating many new errors for VUID-vkCmdCopyImageToBuffer-srcImage-01998. This CL will suppress the error messages to prevent the test failures until they can be fixed. Bug: angleproject:4572 Test: BindUniformLocationES31Test.ArrayOfArrays/ES3_1_Vulkan_SwiftShader Change-Id: I6b36ab64cea8490e577f9077bb44fc7e5023fbda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2154833 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
2020-04-20Add cclao@ and timvp@ to watch for vulkan CLsTim Van Patten
This CL adds cclao@ and timvp@ to watch for vulkan CLs so they can be notified for reviews. Bug: None Change-Id: Iea55a95aa2037ae5c141665dfa494c809a5befa2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152946 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
2020-04-20GL: Re-enable emulatePrimitiveRestartFixedIndexGeoff Lang
This workaround is needed when the GL driver is less than 4.3 (all MacOS). The driver will generate many errors during execution without this enabled which blocks GL driver error checking. Add additional workarounds for Intel drivers that need a sufficiently large primitive restart index when doing DrawArrays calls. BUG=angleproject:3997 Change-Id: Idd293ff1dbc0a3609b11ea1d6b30da0a99e8f5c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2141714 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
2020-04-20Vulkan: glDrawElements used old offset into index bufferIan Elliott
When the vertex array binding is changed, the value of ContextVk::mLastIndexBufferOffset must be reset so that an old/cached offset (from a previous draw call) is not used for a new draw call. This addresses rendering artifacts and Vulkan validation errors seen with running NBA 2K20 on Android (or the ANGLE trace on Windows). Bug: b/153682968 Bug: angleproject:4575 Bug: angleproject:4576 Change-Id: I69089964b8d278c7fc8610ab003548864a215dab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152850 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
2020-04-20Add PackedEnums for blend state parametersAlexey Knyazev
Bug: angleproject:4394, angleproject:2169 Change-Id: I6c218af3871a1215c2b103847250bbc782159cb3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2149645 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
2020-04-20Vulkan: Store ImageType in ImageHelper.Jamie Madill
We ended up needing this to recover the image type in the RenderTarget. Otherwise we don't have direct access to this information in the FramebufferVk sync state code. Bug: angleproject:4517 Change-Id: I387947e0b7394e1f63f313dd4792bb042b8da73a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2151170 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
2020-04-20Roll third_party/vulkan-tools/src 454ab259c1b8..8824107d57d3 (1 commits)angle-autoroll
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/454ab259c1b8..8824107d57d3 git log 454ab259c1b8..8824107d57d3 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 locke@lunarg.com icd: Set texel size is 32 Created with: gclient setdep -r third_party/vulkan-tools/src@8824107d57d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I5b93c96db1e0a2cdd4fbf83bbbda85bf741c3083 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2156119 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-20Roll third_party/SwiftShader d25ce8725224..068611f07d28 (8 commits)angle-autoroll
https://swiftshader.googlesource.com/SwiftShader.git/+log/d25ce8725224..068611f07d28 git log d25ce8725224..068611f07d28 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 capn@google.com Fix JIT on separate thread 2020-04-17 bclayton@google.com Use Thread Safety Analysis annotations throughout SwiftShader. 2020-04-17 digit@google.com CMakeLists: Fix Fuchsia build. 2020-04-17 bclayton@google.com Merge changes Ia8226c11,If413b9d6 2020-04-17 bclayton@google.com LLVMReactor: Drop codegenMutex, now thread safe. 2020-04-17 bclayton@google.com LLVMJIT: Remove the TargetMachine cache. 2020-04-17 bclayton@google.com LLVM 7: Set LLVM_ENABLE_THREADS to 1 2020-04-17 bclayton@google.com SpirvShader: Fix ASSERT firing in debugger Created with: gclient setdep -r third_party/SwiftShader@068611f07d28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I186bb705c9af7638abb1e20edb0bc0011de6cc95 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2156120 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-04-20Roll third_party/glslang/src 4d2298bfd78a..3f4e5c456306 (2 commits)angle-autoroll
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4d2298bfd78a..3f4e5c456306 Created with: gclient setdep -r third_party/glslang/src@3f4e5c456306 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I4e94af432409212f47a17bbd9d2d54126d6f3134 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2156118 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>