aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-04-20Roll ANGLE from cfc92ebf1f1e to 55c21842b204 (3 revisions) am: 6fb0b00ad2 ↵android-autoroll
am: e0c3056997 Original change: https://android-review.googlesource.com/c/platform/external/angle/+/2068371 Change-Id: I05bd1c6f6a9e0624dfae7fd3d12d5346958833df Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-20Roll ANGLE from cfc92ebf1f1e to 55c21842b204 (3 revisions) am: 6fb0b00ad2android-autoroll
Original change: https://android-review.googlesource.com/c/platform/external/angle/+/2068371 Change-Id: I0958dbc343851cef8c69a5f1f404135ed844ba15 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-19Roll ANGLE from c3f1596293c9 to cfc92ebf1f1e (31 revisions) am: 345b350a2a ↵android-autoroll
am: fab0221071 Original change: https://android-review.googlesource.com/c/platform/external/angle/+/2068368 Change-Id: Ie6eb7f8b6a92c1033db0324f4891a472bf73d2a4 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-19Roll ANGLE from c3f1596293c9 to cfc92ebf1f1e (31 revisions) am: 345b350a2aandroid-autoroll
Original change: https://android-review.googlesource.com/c/platform/external/angle/+/2068368 Change-Id: I7e4e54d9578088e3a507c5fd62638634a3a4d808 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-19Roll ANGLE from cfc92ebf1f1e to 55c21842b204 (3 revisions)android-autoroll
https://chromium.googlesource.com/angle/angle.git/+log/cfc92ebf1f1e..55c21842b204 Please enable autosubmit on changes if possible when approving them. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-android-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Test: Presubmit checks will test this change. Exempt-From-Owner-Approval: The autoroll bot does not require owner approval. Change-Id: Ie328f7c5bf83f6b501440c4e67750218ee699ec6
2022-04-19Vulkan: Use flat array lookups for shader variables.Jamie Madill
The array lookups we use after link now are simple array lookups and no longer use string hashing queries. This will make the descriptor cache indexing much faster after the cache key redesign. Bug: angleproject:4524 Change-Id: If19e3a4aa57c415f33c69172dd76c10a207e3264 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3580979 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
2022-04-19D3D: fix SSBOs used in vertex shaders.Stephen White
Use the total number of pixel shader outputs as the base UAV register for vertex and pixel shaders. This is less fragile than making the vertex shader depend on the number of draw-time pixel shader outputs. Add a test that exercises SSBOs in vertex shaders, varying the number of draw-time pixel shader outputs (which should have no effect on register assignment). Bug: angleproject:7156 Change-Id: I5801d59299275ea6d2569456d53c230e7e8ee5a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3579501 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-04-19Roll ANGLE from d2fd28caead9 to c3f1596293c9 (8 revisions) am: 4e9775f972 ↵android-autoroll
am: 1120ead7a6 Original change: https://android-review.googlesource.com/c/platform/external/angle/+/2064550 Change-Id: Ia7cc9cb7afa1e2baa742917ed13680af066c63d1 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-19Fix BlendStateExt::mMaxColorMask initializationAlexey Knyazev
This variable should not have its unused bits set. To avoid confusion with other masks of the same class, the variable was renamed to mAllColorMask. Bug: angleproject:7200 Change-Id: I72542d49ff8da3dbb8d61c5034ce37c1e8fcc6e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3581990 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
2022-04-19Roll ANGLE from d2fd28caead9 to c3f1596293c9 (8 revisions) am: 4e9775f972android-autoroll
Original change: https://android-review.googlesource.com/c/platform/external/angle/+/2064550 Change-Id: I536779517da27fe93fb02e9aa1e5aadfca3faca0 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-19Roll ANGLE from c3f1596293c9 to cfc92ebf1f1e (31 revisions)android-autoroll
https://chromium.googlesource.com/angle/angle.git/+log/c3f1596293c9..cfc92ebf1f1e Please enable autosubmit on changes if possible when approving them. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-android-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Test: Presubmit checks will test this change. Exempt-From-Owner-Approval: The autoroll bot does not require owner approval. Bug: b/223428306 Change-Id: I605b4ab0787bfd1779a009d0eab346323eae2406
2022-04-19Vulkan: Encapsulate ShareGroup::mContextsCharlie Lao
Instead of return mContexts, this add addContext/removeContext API and changed getContexts to const function. No functional change expected, but clean up only. Bug: b/223428306 Change-Id: I020c4bc781f58352089980c9d8ff22bcb183dbe6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3590970 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
2022-04-19gold tests: Add command-line arg for gold instance.Jamie Madill
This will allow other users of the script to override the ANGLE Skia Gold instance with their own. Bug: angleproject:6854 Change-Id: Id6a0966d4db4fd0265d427d684f07dc1e4c610e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3594619 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
2022-04-19Mark contexts as shared when importing EGL images.Geoff Lang
Once a context references an EGL image, it can share resources with contexts in other share groups. Marking the context as shared ensures that locks are held by all contexts referencing EGL images for GL functions. Bug: angleproject:6957 Change-Id: Ic3901c458f388306c59f6bb01560a7c66d0574c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3424659 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
2022-04-19Vulkan: Prep variable info map to remove hashing.Jamie Madill
The removes all the string-based query APIs from the program executable descriptor set init. The new APIs still use string-keyed maps but will be switched out with non-hashed maps in a future CL. Bug: angleproject:4524 Change-Id: I427efb3ebcf22d5fbdf6d20679bbdaa23cd2dc94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3573077 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
2022-04-19Revert "Infra: Enable Skia Gold tests on Pixel 6"Cody Northrop
This reverts commit 3636d129ee9c6c970e9b31883fcc88c539382434. Reason for revert: Causing test timeouts on Pixel 6: https://bugs.chromium.org/p/angleproject/issues/detail?id=7216 Original change's description: > Infra: Enable Skia Gold tests on Pixel 6 > > We have our first trace that can't run on any existing > bots, so we need to expand to Pixel 6. > > Test: TracePerfTest.Run/vulkan_car_chase > Bug: angleproject:7125 > Bug: chromium:1280418 > Change-Id: I7a81d42bc336c7df398b1d1712cf25c0eb9d72d3 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3561490 > Auto-Submit: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Cody Northrop <cnorthrop@google.com> Bug: angleproject:7216 Bug: angleproject:7125 Bug: chromium:1280418 Change-Id: Ieca910fa11f81a3f526e9ccff49fa636fd3b7d13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3594112 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
2022-04-19Tests: Add Monster Strike traceCody Northrop
Test: angle_perftests --gtest_filter="*monster_strike*" Bug: angleproject:7210 Change-Id: I3184059a73f9d21474931633eb381a3cd12831f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587542 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
2022-04-19Use ProgramExecutable directly in GlslangWrapper.Jamie Madill
Using the ProgramExecutable instead of the state means we can deal with merged samplers and images immediately. This will make it easier to use linear maps when indexing program resources for descriptor sets. Bug: angleproject:3570 Bug: angleproject:4524 Change-Id: Icd8ee9fe61730b81fafa2bdc59a2788a0d92ad12 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3580882 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
2022-04-19Add FastMap class.Jamie Madill
We can use this class in a few cases where we can know that the integer key index won't exceed a fixed small boundary. Bug: angleproject:4524 Bug: angleproject:6776 Change-Id: Ic380e1ce8f4dc591504603ade376d9b1e8a3c1c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3579865 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
2022-04-19Skip a Vulkan test due to a threading flake.Jamie Madill
VulkanImageTest.PreInitializedOnGLImport/ES3_Vulkan_SwiftShader_AsyncCommandQueue Bug: angleproject:7204 Change-Id: I1aeb16d1e0bdaecefc0776236f55c46d307fdaad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3593363 Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2022-04-19Revert "vulkan: Call glFinish in VulkanHelper destructor"Jamie Madill
This reverts commit aefb2a99ebb598c7b3530056ef3d030b5c4f0115. Reason for revert: Still flakes: https://ci.chromium.org/ui/p/angle/builders/try/linux-test/4382/overview Original change's description: > vulkan: Call glFinish in VulkanHelper destructor > > In async queue mode, GL commands are submitted asynchronously to the > VkQueue on a separate thread. VulkanHelper destructor uses the VkQueue > when it calls vkDeviceWaitIdle(), and that's a data race when the queue > is being used to run GL commands on the other thread. Calling glFinish() > before any Vulkan commands ensures that the queue isn't being used on > another thread. > > Bug: angleproject:7204 > Change-Id: I509bcf55edf430e39805a9d43c07a902942d33ca > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587366 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Bug: angleproject:7204 Change-Id: I60e6fc519b21d53619309247fdea32f23375f975 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3594099 Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2022-04-19Add check for GL_ANDROID_extension_pack_es31a supportBrandon Schade
Expose Android Extension Pack if we meet the following conditions - 1. GLES version >= 3.1 2. All required AEP extensions are supported Bug: angleproject:3608 Change-Id: I41eaf458b0a8fe7a53cd0fbec818411196ce21ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587535 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
2022-04-19Roll vulkan-deps from 1a408eb154d7 to 00e1ddd4230c (8 revisions)angle-autoroll
https://chromium.googlesource.com/vulkan-deps.git/+log/1a408eb154d7..00e1ddd4230c Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/6a67891418..779138f39f * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/dbf1e87e6b..8a6fe16b4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I9478b2be264000ea7dba13d097b701a62b60acc2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3592348 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-19Roll Chromium from e9b55eb91cb1 to e1b5a693bbfe (303 revisions)angle-autoroll
https://chromium.googlesource.com/chromium/src.git/+log/e9b55eb91cb1..e1b5a693bbfe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9ccdb5a294..7aeed11a9e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/677dce96c9..e895c544f6 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..28b8ede735 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ab2e7f8f2e..7d2693ad8d * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/a6d209ab93..be2c3787c0 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6e7a0235bb..36b318c388 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c1ed910ca0..25916f0211 No update to Clang. Bug: angleproject:7003,angleproject:7200 Tbr: ianelliott@google.com Change-Id: I6dfc2b986794eec1a1b5c7d40f1173e11368ef74 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3592339 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-19Empty merge of sc-v2-dev-plus-aosp-without-vendor@8433047 am: 6e4e0e4a8cXin Li
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/angle/+/17805299 Change-Id: I5709281c9a937b3856ca1b356a60c6b91ee7c3ed Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-19Vulkan: Call into vulkan directly for big size allocation.Charlie Lao
When size is big, if we go down suballocation path, we end up with big size allocation and stuck with it (because some other allocation also suballocate from it). This CL force it down to vulkan driver to allocate VkBuffer and VkDeviceMemory directly for big size allocations, bypassing suballocator. Bug: b/223428306 Change-Id: Idd9f551322331f899036f73bab0489f8249eaadf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550039 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
2022-04-18Vulkan: Remove retains before acquireBufferHelperAmirali Abdolrashidi
* Removed the retainReadOnly() functions in BufferVk, since the BufferHelper object is now moved to a temporary buffer and retaining it is no longer necessary. Bug: angleproject:7103 Change-Id: Id5da88d7cfa4d7a8532eb596f552c70a9ff1d358 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3579862 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
2022-04-18Empty merge of sc-v2-dev-plus-aosp-without-vendor@8433047Xin Li
Bug: 226662282 Merged-In: I949ac9a8f375240b6c6068825eccc645f81b0185 Change-Id: I34161c4d4edb80bec0f0372efce1982020bfd46e
2022-04-18Metal: Fix bytesPerRow computation for compressed formatsAlexey Knyazev
The value represents the row size in bytes, not pixels. Bug: angleproject:7209 Change-Id: Ib7fade31f13ffd3ae78c5df313120c8e0201936c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3588416 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
2022-04-18Roll vulkan-deps from 7f875b15c6a3 to 1a408eb154d7 (4 revisions)angle-autoroll
https://chromium.googlesource.com/vulkan-deps.git/+log/7f875b15c6a3..1a408eb154d7 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/48fd6c82b3..06ac141412 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/027f567463..dbf1e87e6b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I83dae87e4423d508460b696f642ad50ac6f3b854 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3589487 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-18Roll Chromium from 573f2ec89cb9 to e9b55eb91cb1 (411 revisions)angle-autoroll
https://chromium.googlesource.com/chromium/src.git/+log/573f2ec89cb9..e9b55eb91cb1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4dc9039a2d..9ccdb5a294 * buildtools/linux64: git_revision:fd9f2036f26d83f9fcfe93042fb952e5a7fe2167..git_revision:1cdd270be9803dbfcdd0343f6104ad4dc30c38ce * buildtools/mac: git_revision:fd9f2036f26d83f9fcfe93042fb952e5a7fe2167..git_revision:1cdd270be9803dbfcdd0343f6104ad4dc30c38ce * buildtools/win: git_revision:fd9f2036f26d83f9fcfe93042fb952e5a7fe2167..git_revision:1cdd270be9803dbfcdd0343f6104ad4dc30c38ce * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b69ae9bf53..677dce96c9 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b3baa6a042 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4b2e0bd8a4..ab2e7f8f2e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f3fcc8eac8..7d4922aa87 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1cba756954..6e7a0235bb No update to Clang. Bug: angleproject:7209 Tbr: jonahr@google.com Change-Id: I58410e5547138f8cbb54a2918146fb0105bbd2c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3590366 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-16Infra: Enable Skia Gold tests on Pixel 6Cody Northrop
We have our first trace that can't run on any existing bots, so we need to expand to Pixel 6. Test: TracePerfTest.Run/vulkan_car_chase Bug: angleproject:7125 Bug: chromium:1280418 Change-Id: I7a81d42bc336c7df398b1d1712cf25c0eb9d72d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3561490 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
2022-04-15Roll vulkan-deps from c9be322642fb to 7f875b15c6a3 (16 revisions)angle-autoroll
https://chromium.googlesource.com/vulkan-deps.git/+log/c9be322642fb..7f875b15c6a3 Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/9c3fd01c8a..82becc8a8a * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/92c17edde7..cb96abbf7a * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f503824ff8..71bd6240af * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/5f3ce24e7a..ef20059aea * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5501a60aa6..027f567463 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I3f182fa688dc8924d8c6336472d604bae8f35923 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587540 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-15Roll SwiftShader from 1d450ae99a0f to 103a69bd6c82 (3 revisions)angle-autoroll
https://swiftshader.googlesource.com/SwiftShader.git/+log/1d450ae99a0f..103a69bd6c82 2022-04-14 capn@google.com Delete GLESUnitTests 2022-04-14 capn@google.com Detect <xcb/shm.h> for building XCB surface support 2022-04-14 capn@google.com Remove the extensions directory If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I4be6cec3e8d07a59bd7b6871768e68c128fcc72d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3588325 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-15Roll Chromium from e6765ea8299f to 573f2ec89cb9 (443 revisions)angle-autoroll
https://chromium.googlesource.com/chromium/src.git/+log/e6765ea8299f..573f2ec89cb9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bb1c23c67d..4dc9039a2d * buildtools/linux64: git_revision:c114b7e0b3a327e854cae6b560902230436f1ac7..git_revision:fd9f2036f26d83f9fcfe93042fb952e5a7fe2167 * buildtools/mac: git_revision:c114b7e0b3a327e854cae6b560902230436f1ac7..git_revision:fd9f2036f26d83f9fcfe93042fb952e5a7fe2167 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/bbcbce9968..1acfbbb474 * buildtools/win: git_revision:c114b7e0b3a327e854cae6b560902230436f1ac7..git_revision:fd9f2036f26d83f9fcfe93042fb952e5a7fe2167 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/533b4e6461..b69ae9bf53 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/1f41b4fc8f..b0f34841af * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5bb29764b0 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3c6f0eb95f..4b2e0bd8a4 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d82302711f..f3fcc8eac8 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f70aa510c4..1cba756954 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7b9534832c..c1ed910ca0 Clang version changed llvmorg-15-init-7040-g50de659a:llvmorg-15-init-7570-gba4537b2 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/d82302711f8b44cb5a4adffa044343342a08118d..f3fcc8eac8f12c989993f9a05dc3a9985e551d85/scripts/update.py Bug: None Tbr: jonahr@google.com Change-Id: I455a2b6628ba87f6e818456739f411f027dc2370 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587539 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-15Vulkan: updateUniforms when commandbuffer is validAmirali Abdolrashidi
In order to change the resource use list from contextVk into that from one of its command buffers, we have to ensure the render pass command buffer is valid before potentially using its resource use list. * Added the dirty bit `DIRTY_BIT_UNIFORMS`. * Moved updateUniforms() and related functions in setupDraw() to the dirty bit handler where we have ensured that the render pass command buffer is valid. * Moved updateUniforms() and related functions in setupDispatch() to the dirty bit handler. Bug: angleproject:7103 Change-Id: I5435d16df543aa5a4c4be2b82586cb557ab53738 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3582979 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
2022-04-15Remove copyResourceUseList from ShareGroupVkAmirali Abdolrashidi
* Removed copyResourceUseList() and the copy() functions in them, as they are no longer used in submitting commands. Bug: angleproject:7103 Change-Id: Ic62b21817aa2843f90695a8f50b79d254ec89929 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587531 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
2022-04-15Remove Win NVIDIA dEQP suppressionsYuly Novikov
Switching from Quadro P400 to GTX 1660 Bug: angleproject:2222 Change-Id: I7f12878a0ccf31fe5ca319251ab3f4bc60d66b61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587372 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2022-04-14Roll VK-GL-CTS from 2748d45ebbb4 to a22069b4e3b7 (10 revisions)angle-autoroll
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/2748d45ebbb4..a22069b4e3b7 2022-04-14 quic_mnetsch@quicinc.com Merge vk-gl-cts/github-main into vk-gl-cts/main 2022-04-14 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/main 2022-04-14 onion0709@gmail.com explicitly provides ssh urls to GitRepo declarations 2022-04-14 toni.merilehti@siru.fi Fix support check in transform feedback tests 2022-04-14 ari.suonpaa@siru.fi Fix framebuffer size for some GraphicsFuzz tests 2022-04-14 michal.jakubek@mobica.com Ray query helper invocations 2022-04-14 marcin.zajac@mobica.com Modified ray tracing inactive triangle definition 2022-04-14 boris.zanin@mobica.com Add robustness2 limits validation test 2022-04-14 ari.suonpaa@siru.fi Add a batch of GraphicsFuzz coverage tests 2022-04-14 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,jonahr@google.com Change-Id: I1bf98d351a4b46a8898ddd92ebd8529a98d8565f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587530 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-14vulkan: Call glFinish in VulkanHelper destructorSunny Sachanandani
In async queue mode, GL commands are submitted asynchronously to the VkQueue on a separate thread. VulkanHelper destructor uses the VkQueue when it calls vkDeviceWaitIdle(), and that's a data race when the queue is being used to run GL commands on the other thread. Calling glFinish() before any Vulkan commands ensures that the queue isn't being used on another thread. Bug: angleproject:7204 Change-Id: I509bcf55edf430e39805a9d43c07a902942d33ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587366 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
2022-04-14Roll VK-GL-CTS from 20a474e64382 to 2748d45ebbb4 (1 revision)angle-autoroll
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/20a474e64382..2748d45ebbb4 2022-04-14 quic_mnetsch@quicinc.com Merge pull request #312 from lfrb/windows-flush If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,jonahr@google.com Change-Id: I78beb41148488763fc7adf77887dc8c97cd6f239 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3586178 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2022-04-14Translator: Drop const from opaque parameter typesLubosz Sarnecki
`const` is ineffective on opaque types like sampler2D. That qualifier is now dropped as it was tripping SPIR-V gen up. New validation is added to make sure such parameters are not reintroduced. Test credit of Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Test: angle_end2end_tests --gtest_filter="GLSLTest.ConstSamplerParameter*/*_Vulkan" Bug: angleproject:7201 Bug: angleproject:7205 Change-Id: I310a47a8eb162ddafb2ab44682520f546f8a5512 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587345 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
2022-04-14Suppress flaky end2end failures on Mac/NVIDIA/OpenGLJonah Ryan-Davis
These test recently started flaking: CopyTextureTest.CubeMapTarget/ES2_OpenGL CopyTextureTest.CubeMapTargetRGB/ES2_OpenGL CopyTextureTest.CubeMapTargetRGBA/ES2_OpenGL CopyTextureTest.CopyToMipmap/ES2_OpenGL BlitFramebufferTest.ScissoredMultisampleStencil/ES3_OpenGL BlitFramebufferTest.NonZeroBaseDestinationStencil/ES3_OpenGL BlendIntegerTest.MRTUnsigned/ES3_OpenGL BlendIntegerTest.MRTSigned/ES3_OpenGL DrawBuffersTest.BlendWithGaps/ES3_OpenGL Bug: angleproject:7206 Change-Id: I75563601f9f828d5c5fc2e8da6af66d21a2f6d30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3585891 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
2022-04-14Tests: Add Special Forces Group 2 trace.Lubosz Sarnecki
Ignore a SYNC-HAZARD-WRITE_AFTER_READ VVL error in RendererVk. Add GL_EXT_texture_buffer prerequisite. Test: angle_perftests --gtest_filter="*special_forces_group_2*" Bug: angleproject:5592 Change-Id: I63350a0bdbdffbc6951fd650753d900b5ff0bade Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3578764 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
2022-04-14Roll ANGLE from 9442b7a837dc to d2fd28caead9 (14 revisions) am: 16b5c805c6 ↵android-autoroll
am: 5f1e34cdb9 Original change: https://android-review.googlesource.com/c/platform/external/angle/+/2064547 Change-Id: Icf5efc8dd768797d1b5c8768a6d3c68e9d3be0ac Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-14Roll ANGLE from 9442b7a837dc to d2fd28caead9 (14 revisions) am: 16b5c805c6android-autoroll
Original change: https://android-review.googlesource.com/c/platform/external/angle/+/2064547 Change-Id: I9cd1a0782b96acfb9ca3e24e561a4c763f240618 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-14Roll ANGLE from d2fd28caead9 to c3f1596293c9 (8 revisions)android-autoroll
https://chromium.googlesource.com/angle/angle.git/+log/d2fd28caead9..c3f1596293c9 Please enable autosubmit on changes if possible when approving them. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-android-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Test: Presubmit checks will test this change. Exempt-From-Owner-Approval: The autoroll bot does not require owner approval. Change-Id: Ib3e8f8a506911e2ad5450d022e24762a50f87b5d
2022-04-14Fix OOB problem in validationES.{h,cpp}Peng Huang
maxVertexAttributes may less than the gl::MAX_VERTEX_ATTRIBS for some GLES2 devices, so using gl::MAX_VERTEX_ATTRIBS may cause OOB problem. Bug: chromium:1258869 Change-Id: I09609db35143fbf17b4228c7fe5f38a987e4f1d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3584637 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
2022-04-14doc/DevSetup: Add Visual Studio Installer hint.Lubosz Sarnecki
Visual Studio Installer lists Windows 10 SDK versions in it's "Installation details", when modifiying the installation. The list might not contain the latest version of the SDK, which can be found under "Individual components" instead. Bug: angleproject:7018 Change-Id: I6a28afe4690a3c41667e4acb7cac4fe25495f779 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3571964 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
2022-04-14Roll SwiftShader from 011bba68c819 to 1d450ae99a0f (4 revisions)angle-autoroll
https://swiftshader.googlesource.com/SwiftShader.git/+log/011bba68c819..1d450ae99a0f 2022-04-14 sugoi@google.com Stop building legacy SwiftShader GL in Chromium 2022-04-13 capn@google.com Alert about Legacy SwiftShader debug build usage 2022-04-13 swiftshader.regress@gmail.com Regres: Update test lists @ d621b4de 2022-04-13 capn@google.com Temporarily ignore unsupported feature struct If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I75ff94ceafcc463943c3bb2bc190dfb7ae4a637a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3586160 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>