From 6535c04c044a9a1ff76410251e43932ebafa6872 Mon Sep 17 00:00:00 2001 From: "Gary D. Gregory" Date: Mon, 27 Nov 2017 19:17:45 +0000 Subject: Sort members. git-svn-id: https://svn.apache.org/repos/asf/commons/proper/bcel/trunk@1816498 13f79535-47bb-0310-9956-ffa450edef68 --- .../bcel/generic/JDKGenericDumpTestCase.java | 94 +++++++++++----------- 1 file changed, 47 insertions(+), 47 deletions(-) (limited to 'src') diff --git a/src/test/java/org/apache/bcel/generic/JDKGenericDumpTestCase.java b/src/test/java/org/apache/bcel/generic/JDKGenericDumpTestCase.java index 24d3b7a9..14ee279e 100644 --- a/src/test/java/org/apache/bcel/generic/JDKGenericDumpTestCase.java +++ b/src/test/java/org/apache/bcel/generic/JDKGenericDumpTestCase.java @@ -51,6 +51,8 @@ import com.sun.jna.platform.win32.Advapi32Util; @RunWith(Parameterized.class) public class JDKGenericDumpTestCase { + private static final char[] hexArray = "0123456789ABCDEF".toCharArray(); + private static final String KEY_JDK = "SOFTWARE\\JavaSoft\\Java Development Kit"; private static final String KEY_JDK_9 = "SOFTWARE\\JavaSoft\\JDK"; @@ -59,6 +61,22 @@ public class JDKGenericDumpTestCase { private static final String KEY_JRE_9 = "SOFTWARE\\JavaSoft\\JRE"; + private static void addAllJavaHomesOnWindows(final String keyJre, final Set javaHomes) { + javaHomes.addAll(findJavaHomesOnWindows(keyJre, Advapi32Util.registryGetKeys(HKEY_LOCAL_MACHINE, keyJre))); + } + + private static String bytesToHex(final byte[] bytes) { + final char[] hexChars = new char[bytes.length * 3]; + int i = 0; + for (final byte b : bytes) { + final int v = b & 0xFF; + hexChars[i++] = hexArray[v >>> 4]; + hexChars[i++] = hexArray[v & 0x0F]; + hexChars[i++] = ' '; + } + return new String(hexChars); + } + @Parameters(name = "{0}") public static Collection data() { return findJavaHomes(); @@ -82,10 +100,6 @@ public class JDKGenericDumpTestCase { return javaHomes; } - private static void addAllJavaHomesOnWindows(final String keyJre, final Set javaHomes) { - javaHomes.addAll(findJavaHomesOnWindows(keyJre, Advapi32Util.registryGetKeys(HKEY_LOCAL_MACHINE, keyJre))); - } - private static Set findJavaHomesOnWindows(final String keyJavaHome, final String[] keys) { final Set javaHomes = new HashSet<>(keys.length); for (final String key : keys) { @@ -102,41 +116,10 @@ public class JDKGenericDumpTestCase { return javaHomes; } - public JDKGenericDumpTestCase(final String javaHome) { - this.javaHome = javaHome; - } - private final String javaHome; - @Test - public void testJDKjars() throws Exception { - final File[] jars = listJDKjars(); - if (jars != null) { - for (final File file : jars) { - testJar(file); - } - } - } - - private void testJar(final File file) throws Exception { - System.out.println(file); - try (JarFile jar = new JarFile(file)) { - final Enumeration en = jar.entries(); - while (en.hasMoreElements()) { - final JarEntry e = en.nextElement(); - final String name = e.getName(); - if (name.endsWith(".class")) { - // System.out.println("- " + name); - try (InputStream in = jar.getInputStream(e)) { - final ClassParser parser = new ClassParser(in, name); - final JavaClass jc = parser.parse(); - for (final Method m : jc.getMethods()) { - compare(name, m); - } - } - } - } - } + public JDKGenericDumpTestCase(final String javaHome) { + this.javaHome = javaHome; } private void compare(final String name, final Method m) { @@ -171,17 +154,34 @@ public class JDKGenericDumpTestCase { }); } - private static final char[] hexArray = "0123456789ABCDEF".toCharArray(); + private void testJar(final File file) throws Exception { + System.out.println(file); + try (JarFile jar = new JarFile(file)) { + final Enumeration en = jar.entries(); + while (en.hasMoreElements()) { + final JarEntry e = en.nextElement(); + final String name = e.getName(); + if (name.endsWith(".class")) { + // System.out.println("- " + name); + try (InputStream in = jar.getInputStream(e)) { + final ClassParser parser = new ClassParser(in, name); + final JavaClass jc = parser.parse(); + for (final Method m : jc.getMethods()) { + compare(name, m); + } + } + } + } + } + } - private static String bytesToHex(final byte[] bytes) { - final char[] hexChars = new char[bytes.length * 3]; - int i = 0; - for (final byte b : bytes) { - final int v = b & 0xFF; - hexChars[i++] = hexArray[v >>> 4]; - hexChars[i++] = hexArray[v & 0x0F]; - hexChars[i++] = ' '; + @Test + public void testJDKjars() throws Exception { + final File[] jars = listJDKjars(); + if (jars != null) { + for (final File file : jars) { + testJar(file); + } } - return new String(hexChars); } } -- cgit v1.2.3