diff options
author | Gary D. Gregory <ggregory@apache.org> | 2013-01-22 07:05:41 +0000 |
---|---|---|
committer | Gary D. Gregory <ggregory@apache.org> | 2013-01-22 07:05:41 +0000 |
commit | adfcc014bd6fd24ae76425f203ae5cc1888ee33f (patch) | |
tree | 9368a420f60d681dffbceb161564d409b8a5ed66 | |
parent | 53646c1c9835ca1a681871e0ec59feb685cd907d (diff) | |
download | apache-commons-lang-adfcc014bd6fd24ae76425f203ae5cc1888ee33f.tar.gz |
Add final modifier to private fields.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1436767 13f79535-47bb-0310-9956-ffa450edef68
12 files changed, 29 insertions, 29 deletions
diff --git a/src/main/java/org/apache/commons/lang3/SerializationUtils.java b/src/main/java/org/apache/commons/lang3/SerializationUtils.java index 575998d31..abc20297c 100644 --- a/src/main/java/org/apache/commons/lang3/SerializationUtils.java +++ b/src/main/java/org/apache/commons/lang3/SerializationUtils.java @@ -266,7 +266,7 @@ public class SerializationUtils { static class ClassLoaderAwareObjectInputStream extends ObjectInputStream { private static final Map<String, Class<?>> primitiveTypes = new HashMap<String, Class<?>>(); - private ClassLoader classLoader; + private final ClassLoader classLoader; /** * Constructor. diff --git a/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java b/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java index e03ed95a2..3ac77ede6 100644 --- a/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java +++ b/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java @@ -466,7 +466,7 @@ public class StringUtilsEqualsIndexOfTest { // other object be an instance of CustomCharSequence, even though, as char sequences, // `seq` may equal the other object. private static class CustomCharSequence implements CharSequence { - private CharSequence seq; + private final CharSequence seq; public CustomCharSequence(CharSequence seq) { this.seq = seq; diff --git a/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java b/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java index ba1718d24..4e55ec3af 100644 --- a/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java +++ b/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java @@ -128,7 +128,7 @@ public class EqualsBuilderTest { static class TestTTLeafObject extends TestTTSubObject { @SuppressWarnings("unused") - private int leafValue; + private final int leafValue; public TestTTLeafObject(int a, int t, int tt, int leafValue) { super(a, t, tt); this.leafValue = leafValue; @@ -938,7 +938,7 @@ public class EqualsBuilderTest { } public static class TestACanEqualB { - private int a; + private final int a; public TestACanEqualB(int a) { this.a = a; @@ -969,7 +969,7 @@ public class EqualsBuilderTest { } public static class TestBCanEqualA { - private int b; + private final int b; public TestBCanEqualA(int b) { this.b = b; @@ -1065,11 +1065,11 @@ public class EqualsBuilderTest { static class TestObjectWithMultipleFields { @SuppressWarnings("unused") - private TestObject one; + private final TestObject one; @SuppressWarnings("unused") - private TestObject two; + private final TestObject two; @SuppressWarnings("unused") - private TestObject three; + private final TestObject three; public TestObjectWithMultipleFields(int one, int two, int three) { this.one = new TestObject(one); @@ -1111,7 +1111,7 @@ public class EqualsBuilderTest { @SuppressWarnings("unused") private TestObjectReference reference; @SuppressWarnings("unused") - private TestObject one; + private final TestObject one; public TestObjectReference(int one) { this.one = new TestObject(one); diff --git a/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderExcludeTest.java b/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderExcludeTest.java index a3ec5345f..818106089 100644 --- a/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderExcludeTest.java +++ b/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderExcludeTest.java @@ -33,10 +33,10 @@ public class ReflectionToStringBuilderExcludeTest { class TestFixture { @SuppressWarnings("unused") - private String secretField = SECRET_VALUE; + private final String secretField = SECRET_VALUE; @SuppressWarnings("unused") - private String showField = NOT_SECRET_VALUE; + private final String showField = NOT_SECRET_VALUE; } private static final String NOT_SECRET_FIELD = "showField"; diff --git a/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderMutateInspectConcurrencyTest.java b/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderMutateInspectConcurrencyTest.java index 7476abf98..2aedd16f0 100644 --- a/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderMutateInspectConcurrencyTest.java +++ b/src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderMutateInspectConcurrencyTest.java @@ -40,7 +40,7 @@ public class ReflectionToStringBuilderMutateInspectConcurrencyTest { class TestFixture {
final private LinkedList<Integer> listField = new LinkedList<Integer>();
final private Random random = new Random();
- private int N = 100;
+ private final int N = 100;
public TestFixture() {
synchronized (this) {
diff --git a/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java b/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java index e5d0820c1..32ac38a71 100644 --- a/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java +++ b/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java @@ -359,14 +359,14 @@ public class ToStringBuilderTest { static class ReflectionTestFixtureA { @SuppressWarnings("unused") - private char a='a'; + private final char a='a'; @SuppressWarnings("unused") private transient char transientA='t'; } static class ReflectionTestFixtureB extends ReflectionTestFixtureA { @SuppressWarnings("unused") - private char b='b'; + private final char b='b'; @SuppressWarnings("unused") private transient char transientB='t'; } @@ -489,7 +489,7 @@ public class ToStringBuilderTest { private static class SelfInstanceVarReflectionTestFixture { @SuppressWarnings("unused") - private SelfInstanceVarReflectionTestFixture typeIsSelf; + private final SelfInstanceVarReflectionTestFixture typeIsSelf; public SelfInstanceVarReflectionTestFixture() { this.typeIsSelf = this; @@ -503,8 +503,8 @@ public class ToStringBuilderTest { private static class SelfInstanceTwoVarsReflectionTestFixture { @SuppressWarnings("unused") - private SelfInstanceTwoVarsReflectionTestFixture typeIsSelf; - private String otherType = "The Other Type"; + private final SelfInstanceTwoVarsReflectionTestFixture typeIsSelf; + private final String otherType = "The Other Type"; public SelfInstanceTwoVarsReflectionTestFixture() { this.typeIsSelf = this; diff --git a/src/test/java/org/apache/commons/lang3/event/EventUtilsTest.java b/src/test/java/org/apache/commons/lang3/event/EventUtilsTest.java index 211045c1a..b101ed129 100644 --- a/src/test/java/org/apache/commons/lang3/event/EventUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/event/EventUtilsTest.java @@ -201,7 +201,7 @@ public class EventUtilsTest private static class EventCountingInvociationHandler implements InvocationHandler { - private Map<String, Integer> eventCounts = new TreeMap<String, Integer>(); + private final Map<String, Integer> eventCounts = new TreeMap<String, Integer>(); public <L> L createListener(Class<L> listenerType) { @@ -234,7 +234,7 @@ public class EventUtilsTest public static class MultipleEventSource { - private EventListenerSupport<MultipleEventListener> listeners = EventListenerSupport.create(MultipleEventListener.class); + private final EventListenerSupport<MultipleEventListener> listeners = EventListenerSupport.create(MultipleEventListener.class); public void addMultipleEventListener(MultipleEventListener listener) { @@ -252,7 +252,7 @@ public class EventUtilsTest public static class PropertyChangeSource { - private EventListenerSupport<PropertyChangeListener> listeners = EventListenerSupport.create(PropertyChangeListener.class); + private final EventListenerSupport<PropertyChangeListener> listeners = EventListenerSupport.create(PropertyChangeListener.class); private String property; diff --git a/src/test/java/org/apache/commons/lang3/reflect/ConstructorUtilsTest.java b/src/test/java/org/apache/commons/lang3/reflect/ConstructorUtilsTest.java index d61d9a833..523ced7cb 100644 --- a/src/test/java/org/apache/commons/lang3/reflect/ConstructorUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/reflect/ConstructorUtilsTest.java @@ -34,7 +34,7 @@ import org.apache.commons.lang3.mutable.MutableObject; */ public class ConstructorUtilsTest { public static class TestBean { - private String toString; + private final String toString; public TestBean() { toString = "()"; @@ -72,7 +72,7 @@ public class ConstructorUtilsTest { } } - private Map<Class<?>, Class<?>[]> classCache; + private final Map<Class<?>, Class<?>[]> classCache; public ConstructorUtilsTest() { classCache = new HashMap<Class<?>, Class<?>[]>(); diff --git a/src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java b/src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java index 6f8f876d7..a7ab28d81 100644 --- a/src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java @@ -54,7 +54,7 @@ public class FieldUtilsTest { private PublicChild publicChild; private PubliclyShadowedChild publiclyShadowedChild; private PrivatelyShadowedChild privatelyShadowedChild; - private Class<?> parentClass = PublicChild.class.getSuperclass(); + private final Class<?> parentClass = PublicChild.class.getSuperclass(); @Before public void setUp() { diff --git a/src/test/java/org/apache/commons/lang3/reflect/MethodUtilsTest.java b/src/test/java/org/apache/commons/lang3/reflect/MethodUtilsTest.java index 50662d59e..d29a98a45 100644 --- a/src/test/java/org/apache/commons/lang3/reflect/MethodUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/reflect/MethodUtilsTest.java @@ -126,7 +126,7 @@ public class MethodUtilsTest { } private TestBean testBean; - private Map<Class<?>, Class<?>[]> classCache = new HashMap<Class<?>, Class<?>[]>(); + private final Map<Class<?>, Class<?>[]> classCache = new HashMap<Class<?>, Class<?>[]>(); @Before public void setUp() throws Exception { diff --git a/src/test/java/org/apache/commons/lang3/reflect/testbed/Parent.java b/src/test/java/org/apache/commons/lang3/reflect/testbed/Parent.java index 89e850deb..5acb3f5a0 100644 --- a/src/test/java/org/apache/commons/lang3/reflect/testbed/Parent.java +++ b/src/test/java/org/apache/commons/lang3/reflect/testbed/Parent.java @@ -24,5 +24,5 @@ class Parent implements Foo { protected boolean b = false; int i = 0; @SuppressWarnings("unused") - private double d = 0.0; + private final double d = 0.0; } diff --git a/src/test/java/org/apache/commons/lang3/reflect/testbed/PrivatelyShadowedChild.java b/src/test/java/org/apache/commons/lang3/reflect/testbed/PrivatelyShadowedChild.java index 5eea91885..952548d59 100644 --- a/src/test/java/org/apache/commons/lang3/reflect/testbed/PrivatelyShadowedChild.java +++ b/src/test/java/org/apache/commons/lang3/reflect/testbed/PrivatelyShadowedChild.java @@ -21,8 +21,8 @@ package org.apache.commons.lang3.reflect.testbed; */ @SuppressWarnings({ "unused", "hiding" }) // deliberate re-use of variable names public class PrivatelyShadowedChild extends Parent { - private String s = "ss"; - private boolean b = true; - private int i = 1; - private double d = 1.0; + private final String s = "ss"; + private final boolean b = true; + private final int i = 1; + private final double d = 1.0; } |