aboutsummaryrefslogtreecommitdiff
path: root/src/test/java/org/apache/commons/lang3/reflect
diff options
context:
space:
mode:
authorGary Gregory <garydgregory@gmail.com>2020-11-20 22:12:25 -0500
committerGary Gregory <garydgregory@gmail.com>2020-11-20 22:12:25 -0500
commit764b9bba528487fb575b84766998086c24bb1f48 (patch)
treec724be485e186e19f7722efe41cbc4312f3c62c9 /src/test/java/org/apache/commons/lang3/reflect
parentd5196e7fe47b3121c4d18f90164ca66979d5fd80 (diff)
downloadapache-commons-lang-764b9bba528487fb575b84766998086c24bb1f48.tar.gz
Use final.
Diffstat (limited to 'src/test/java/org/apache/commons/lang3/reflect')
-rw-r--r--src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java2
-rw-r--r--src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java18
2 files changed, 10 insertions, 10 deletions
diff --git a/src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java b/src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java
index 0bcacea67..a1bb83d98 100644
--- a/src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java
@@ -181,7 +181,7 @@ public class FieldUtilsTest {
assertEquals(expected, allFields.length, Arrays.toString(allFields));
}
- private Field[] sort(Field[] fields) {
+ private Field[] sort(final Field[] fields) {
// Field does not implement Comparable, so we use a KISS solution here.
return ArrayUtils.sort(fields, ObjectToStringComparator.INSTANCE);
}
diff --git a/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java b/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java
index 8cdce0b89..3570a9a74 100644
--- a/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java
@@ -739,18 +739,18 @@ public class TypeUtilsTest<B> {
assertTrue(TypeUtils.isAssignable(fClassType, eClassType));
}
- private void testIsAssignable(Class testUnassignableClass) {
+ private void testIsAssignable(final Class testUnassignableClass) {
final Class<Constructor> rawClass = Constructor.class;
final Class<Insets> typeArgClass = Insets.class;
// Builds a ParameterizedType for Constructor<Insets>
- ParameterizedType paramType = TypeUtils.parameterize(rawClass, typeArgClass);
+ final ParameterizedType paramType = TypeUtils.parameterize(rawClass, typeArgClass);
assertEquals(rawClass, paramType.getRawType());
assertEquals(typeArgClass, paramType.getActualTypeArguments()[0]);
assertFalse(testUnassignableClass.isAssignableFrom(paramType.getClass()));
assertFalse(paramType.getClass().isAssignableFrom(testUnassignableClass));
- GenericArrayType arrayType = TypeUtils.genericArrayType(paramType);
+ final GenericArrayType arrayType = TypeUtils.genericArrayType(paramType);
assertFalse(TypeUtils.isAssignable(arrayType, paramType),
() -> String.format("TypeUtils.isAssignable(%s, %s)", arrayType, paramType));
assertFalse(TypeUtils.isAssignable(paramType, arrayType),
@@ -762,14 +762,14 @@ public class TypeUtilsTest<B> {
final Class<Constructor> rawClass = Constructor.class;
final Class<Insets> typeArgClass = Insets.class;
// Builds a ParameterizedType for Constructor<Insets>
- ParameterizedType paramType = TypeUtils.parameterize(rawClass, typeArgClass);
+ final ParameterizedType paramType = TypeUtils.parameterize(rawClass, typeArgClass);
assertEquals(rawClass, paramType.getRawType());
assertEquals(typeArgClass, paramType.getActualTypeArguments()[0]);
assertFalse(GenericArrayType.class.isAssignableFrom(paramType.getClass()));
assertFalse(paramType.getClass().isAssignableFrom(GenericArrayType.class));
- GenericArrayType testType = TypeUtils.genericArrayType(paramType);
+ final GenericArrayType testType = TypeUtils.genericArrayType(paramType);
assertFalse(TypeUtils.isAssignable(paramType, testType),
() -> String.format("TypeUtils.isAssignable(%s, %s)", paramType, testType));
assertFalse(TypeUtils.isAssignable(testType, paramType),
@@ -782,14 +782,14 @@ public class TypeUtilsTest<B> {
final Class<Constructor> rawClass = Constructor.class;
final Class<Insets> typeArgClass = Insets.class;
// Builds a ParameterizedType for Constructor<Insets>
- ParameterizedType paramType = TypeUtils.parameterize(rawClass, typeArgClass);
+ final ParameterizedType paramType = TypeUtils.parameterize(rawClass, typeArgClass);
assertEquals(rawClass, paramType.getRawType());
assertEquals(typeArgClass, paramType.getActualTypeArguments()[0]);
assertFalse(WildcardType.class.isAssignableFrom(paramType.getClass()));
assertFalse(paramType.getClass().isAssignableFrom(WildcardType.class));
- WildcardType testType = TypeUtils.WILDCARD_ALL;
+ final WildcardType testType = TypeUtils.WILDCARD_ALL;
// TODO This test returns true unlike the test above.
// Is this a bug in this test or in the main code?
assertFalse(TypeUtils.isAssignable(paramType, testType),
@@ -803,14 +803,14 @@ public class TypeUtilsTest<B> {
final Class<Constructor> rawClass = Constructor.class;
final Class<Insets> typeArgClass = Insets.class;
// Builds a ParameterizedType for Constructor<Insets>
- ParameterizedType paramType = TypeUtils.parameterize(rawClass, typeArgClass);
+ final ParameterizedType paramType = TypeUtils.parameterize(rawClass, typeArgClass);
assertEquals(rawClass, paramType.getRawType());
assertEquals(typeArgClass, paramType.getActualTypeArguments()[0]);
assertTrue(Object.class.isAssignableFrom(paramType.getClass()));
assertFalse(paramType.getClass().isAssignableFrom(Object.class));
- Type testType = Object.class;
+ final Type testType = Object.class;
assertTrue(TypeUtils.isAssignable(paramType, testType),
() -> String.format("TypeUtils.isAssignable(%s, %s)", paramType, testType));
assertFalse(TypeUtils.isAssignable(testType, paramType),