diff options
| author | XenoAmess <xenoamess@gmail.com> | 2020-06-13 22:57:51 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-06-13 10:57:51 -0400 |
| commit | f2d376ae01d59cf89a87f0114e21f9a5d4bc4885 (patch) | |
| tree | 99806094d792b8a4e1b49725d7676496b8d72168 /src/test/java/org/apache | |
| parent | 386c1e2f37f77aedbfb624800bab51319bf3a9fd (diff) | |
| download | apache-commons-lang-f2d376ae01d59cf89a87f0114e21f9a5d4bc4885.tar.gz | |
[LANG-1564] use Collections.singletonList insteadof Arrays.asList when there be only one element. (#549)
* asList
* Update TypeUtilsTest.java
Diffstat (limited to 'src/test/java/org/apache')
| -rw-r--r-- | src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java | 4 | ||||
| -rw-r--r-- | src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java | 3 |
2 files changed, 3 insertions, 4 deletions
diff --git a/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java b/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java index 373f40ca7..aab3a4e77 100644 --- a/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java @@ -243,10 +243,10 @@ public class ObjectUtilsTest { @Test public void testHashCodeMulti_multiple_likeList() { - final List<Object> list0 = new ArrayList<>(Arrays.asList()); + final List<Object> list0 = new ArrayList<>(Collections.emptyList()); assertEquals(list0.hashCode(), ObjectUtils.hashCodeMulti()); - final List<Object> list1 = new ArrayList<>(Arrays.asList("a")); + final List<Object> list1 = new ArrayList<>(Collections.singletonList("a")); assertEquals(list1.hashCode(), ObjectUtils.hashCodeMulti("a")); final List<Object> list2 = new ArrayList<>(Arrays.asList("a", "b")); diff --git a/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java b/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java index eeaaa8c41..d029c088a 100644 --- a/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java @@ -32,7 +32,6 @@ import java.lang.reflect.TypeVariable; import java.lang.reflect.WildcardType; import java.net.URI; import java.util.ArrayList; -import java.util.Arrays; import java.util.Collection; import java.util.Collections; import java.util.HashMap; @@ -504,7 +503,7 @@ public class TypeUtilsTest<B> { assertEquals(Integer.class, typeVarAssigns.get(treeSetTypeVar), "Type argument of Comparable from int: " + typeArg); - final Collection<Integer> col = Arrays.asList(); + final Collection<Integer> col = Collections.emptyList(); typeVarAssigns = TypeUtils.getTypeArguments(List.class, Collection.class); treeSetTypeVar = Comparable.class.getTypeParameters()[0]; assertFalse(typeVarAssigns.containsKey(treeSetTypeVar), |