diff options
| author | Claude Brisson <cbrisson@apache.org> | 2017-01-28 19:21:08 +0000 |
|---|---|---|
| committer | Claude Brisson <cbrisson@apache.org> | 2017-01-28 19:21:08 +0000 |
| commit | 23e6d0faeb4648ec700481fb3f01214bd81f4f79 (patch) | |
| tree | 9dcf8c9be8710fa85f2dd31ea18604584445882f /velocity-engine-examples | |
| parent | 34e78d04e1edf70a291f2acbf9d891466bc9582a (diff) | |
| download | apache-velocity-engine-23e6d0faeb4648ec700481fb3f01214bd81f4f79.tar.gz | |
[engine] full code review (foreach loops and some other problems detected by code analysis tools)
git-svn-id: https://svn.apache.org/repos/asf/velocity/engine/trunk@1780734 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'velocity-engine-examples')
3 files changed, 2 insertions, 7 deletions
diff --git a/velocity-engine-examples/src/main/java/org/apache/velocity/example/DBContext.java b/velocity-engine-examples/src/main/java/org/apache/velocity/example/DBContext.java index 2dcbfb34..cd64e833 100644 --- a/velocity-engine-examples/src/main/java/org/apache/velocity/example/DBContext.java +++ b/velocity-engine-examples/src/main/java/org/apache/velocity/example/DBContext.java @@ -179,8 +179,6 @@ public class DBContext extends AbstractContext { System. out.println(e); } - - return; } } diff --git a/velocity-engine-examples/src/main/java/org/apache/velocity/example/EventExample.java b/velocity-engine-examples/src/main/java/org/apache/velocity/example/EventExample.java index 607d6ffd..45eb87ab 100644 --- a/velocity-engine-examples/src/main/java/org/apache/velocity/example/EventExample.java +++ b/velocity-engine-examples/src/main/java/org/apache/velocity/example/EventExample.java @@ -276,10 +276,7 @@ public class EventExample extends MarkerIgnoringBase */ public boolean shouldLogOnNullSet( String lhs, String rhs ) { - if (lhs.equals("$settest")) - return false; - - return true; + return !lhs.equals("$settest"); } public Object methodException( Context context, Class claz, String method, Exception e, Info info ) { diff --git a/velocity-engine-examples/src/main/java/org/apache/velocity/example/Example.java b/velocity-engine-examples/src/main/java/org/apache/velocity/example/Example.java index 3cb33e68..7717f382 100644 --- a/velocity-engine-examples/src/main/java/org/apache/velocity/example/Example.java +++ b/velocity-engine-examples/src/main/java/org/apache/velocity/example/Example.java @@ -88,7 +88,7 @@ public class Example * of the template and the data to produce the output stream. */ - BufferedWriter writer = writer = new BufferedWriter( + BufferedWriter writer = new BufferedWriter( new OutputStreamWriter(System.out)); if ( template != null) |