diff options
author | Bipin Ravi <bipin.ravi@arm.com> | 2021-03-31 16:45:40 -0500 |
---|---|---|
committer | Bipin Ravi <bipin.ravi@arm.com> | 2021-09-03 15:44:47 -0500 |
commit | 213afde907a375f4f28ac1843b633ca83887f174 (patch) | |
tree | 0f0896ae7f9075d6794bb3ea452cca773092c0de /lib | |
parent | 4618b2bfa7116371a5785a32f69ef2ea928f7cb7 (diff) | |
download | arm-trusted-firmware-213afde907a375f4f28ac1843b633ca83887f174.tar.gz |
errata: workaround for Cortex-A710 erratum 2055002
Cortex-A710 erratum 2055002 is a Cat B erratum that applies to
revisions r1p0 & r2p0 and is still open. The workaround is to
set CPUACTLR_EL1[46] to force L2 tag ECC inline correction mode.
This workaround works on revision r1p0 & r2p0.
SDEN can be found here:
https://developer.arm.com/documentation/SDEN1775101/latest
Signed-off-by: Bipin Ravi <bipin.ravi@arm.com>
Change-Id: I67be1dce53c4651167d8cee33c116e73b9dafe81
Diffstat (limited to 'lib')
-rw-r--r-- | lib/cpus/aarch64/cortex_a710.S | 38 | ||||
-rw-r--r-- | lib/cpus/cpu-ops.mk | 8 |
2 files changed, 43 insertions, 3 deletions
diff --git a/lib/cpus/aarch64/cortex_a710.S b/lib/cpus/aarch64/cortex_a710.S index 469b430a9..ac2517c21 100644 --- a/lib/cpus/aarch64/cortex_a710.S +++ b/lib/cpus/aarch64/cortex_a710.S @@ -107,6 +107,32 @@ func check_errata_2081180 b cpu_rev_var_ls endfunc check_errata_2081180 +/* --------------------------------------------------------------------- + * Errata Workaround for Cortex-A710 Erratum 2055002. + * This applies to revision r1p0, r2p0 of Cortex-A710 and is still open. + * Inputs: + * x0: variant[4:7] and revision[0:3] of current cpu. + * Shall clobber: x0-x17 + * --------------------------------------------------------------------- + */ +func errata_a710_2055002_wa + /* Compare x0 against revision r2p0 */ + mov x17, x30 + bl check_errata_2055002 + cbz x0, 1f + mrs x1, CORTEX_A710_CPUACTLR_EL1 + orr x1, x1, CORTEX_A710_CPUACTLR_EL1_BIT_46 + msr CORTEX_A710_CPUACTLR_EL1, x1 +1: + ret x17 +endfunc errata_a710_2055002_wa + +func check_errata_2055002 + /* Applies to r1p0, r2p0 */ + mov x1, #0x20 + b cpu_rev_var_ls +endfunc check_errata_2055002 + /* ---------------------------------------------------- * HW will do the cache maintenance while powering down * ---------------------------------------------------- @@ -123,10 +149,10 @@ func cortex_a710_core_pwr_dwn ret endfunc cortex_a710_core_pwr_dwn +#if REPORT_ERRATA /* - * Errata printing function for Cortex A710. Must follow AAPCS. + * Errata printing function for Cortex-A710. Must follow AAPCS. */ -#if REPORT_ERRATA func cortex_a710_errata_report stp x8, x30, [sp, #-16]! @@ -139,6 +165,7 @@ func cortex_a710_errata_report */ report_errata ERRATA_A710_1987031, cortex_a710, 1987031 report_errata ERRATA_A710_2081180, cortex_a710, 2081180 + report_errata ERRATA_A710_2055002, cortex_a710, 2055002 ldp x8, x30, [sp], #16 ret @@ -164,8 +191,13 @@ func cortex_a710_reset_func bl errata_a710_2081180_wa #endif +#if ERRATA_A710_2055002 + mov x0, x18 + bl errata_a710_2055002_wa +#endif + isb - ret x19 + ret x19 endfunc cortex_a710_reset_func /* --------------------------------------------- diff --git a/lib/cpus/cpu-ops.mk b/lib/cpus/cpu-ops.mk index f93aecdd9..fe66fbb9e 100644 --- a/lib/cpus/cpu-ops.mk +++ b/lib/cpus/cpu-ops.mk @@ -429,6 +429,10 @@ ERRATA_N2_2067956 ?=0 # to revision r0p0 of the Neoverse N2 cpu and is still open. ERRATA_N2_2025414 ?=0 +# Flag to apply erratum 2055002 workaround during reset. This erratum applies +# to revision r1p0, r2p0 of the Cortex-A710 cpu and is still open. +ERRATA_A710_2055002 ?=0 + # Flag to apply DSU erratum 798953. This erratum applies to DSUs revision r0p0. # Applying the workaround results in higher DSU power consumption on idle. ERRATA_DSU_798953 ?=0 @@ -790,6 +794,10 @@ $(eval $(call add_define,ERRATA_N2_2067956)) $(eval $(call assert_boolean,ERRATA_N2_2025414)) $(eval $(call add_define,ERRATA_N2_2025414)) +# Process ERRATA_A710_2055002 flag +$(eval $(call assert_boolean,ERRATA_A710_2055002)) +$(eval $(call add_define,ERRATA_A710_2055002)) + # Process ERRATA_DSU_798953 flag $(eval $(call assert_boolean,ERRATA_DSU_798953)) $(eval $(call add_define,ERRATA_DSU_798953)) |