diff options
author | Daniel Boulby <daniel.boulby@arm.com> | 2018-06-22 14:16:03 +0100 |
---|---|---|
committer | Daniel Boulby <daniel.boulby@arm.com> | 2018-09-21 13:14:13 +0100 |
commit | a08a2014300a495381cdb8f6d59523bcd5d3b883 (patch) | |
tree | ab016b027c303ccbe8001764f824f8980b233f54 /plat/xilinx | |
parent | e52ed092cde21d13533df32eb68629a980d69b4b (diff) | |
download | arm-trusted-firmware-a08a2014300a495381cdb8f6d59523bcd5d3b883.tar.gz |
Ensure the flow through switch statements is clear
Ensure case clauses:
* Terminate with an unconditional break, return or goto statement.
* Use conditional break, return or goto statements as long as the end
of the case clause is unreachable; such case clauses must terminate
with assert(0) /* Unreachable */ or an unconditional __dead2 function
call
* Only fallthough when doing otherwise would result in less
readable/maintainable code; such case clauses must terminate with a
/* Fallthrough */ comment to make it clear this is the case and
indicate that a fallthrough is intended.
This reduces the chance of bugs appearing due to unintended flow through a
switch statement
Change-Id: I70fc2d1f4fd679042397dec12fd1982976646168
Signed-off-by: Daniel Boulby <daniel.boulby@arm.com>
Diffstat (limited to 'plat/xilinx')
-rw-r--r-- | plat/xilinx/zynqmp/pm_service/pm_api_ioctl.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/plat/xilinx/zynqmp/pm_service/pm_api_ioctl.c b/plat/xilinx/zynqmp/pm_service/pm_api_ioctl.c index 32c73577a..16c08ae6d 100644 --- a/plat/xilinx/zynqmp/pm_service/pm_api_ioctl.c +++ b/plat/xilinx/zynqmp/pm_service/pm_api_ioctl.c @@ -253,6 +253,7 @@ static enum pm_ret_status pm_ioctl_sd_dll_reset(enum pm_node_id nid, if (type == PM_DLL_RESET_ASSERT) break; mdelay(1); + /* Fallthrough */ case PM_DLL_RESET_RELEASE: ret = pm_mmio_write(ZYNQMP_SD_DLL_CTRL, mask, 0); break; |