diff options
author | Brad Corso <bcorso@google.com> | 2021-06-01 15:04:00 -0700 |
---|---|---|
committer | Google Java Core Libraries <java-libraries-firehose+copybara@google.com> | 2021-06-01 15:04:34 -0700 |
commit | de4033252036cc8d58bcfa6cf3099cd43da02ea1 (patch) | |
tree | 4b554f511254cfad5cb39d033f4728544efef9bc | |
parent | 15d49d9f3c0b2a782b03e16a80daf4f503943035 (diff) | |
download | auto-de4033252036cc8d58bcfa6cf3099cd43da02ea1.tar.gz |
Upgrade dependencies to auto-common 1.0.1 and replace Guava toImmutable* usages with auto-common alternatives.
This fixes an issue that occurs when the Android flavor of Guava somehow finds its way onto the processor class path and gets classloaded instead of the server Guava. The ideal solution would be to just keep the Android flavor of Guava off of the processor class path. However, it's been something that we've allowed for a while now, e.g. in Dagger, and would be difficult to start enforcing.
RELNOTES=N/A
PiperOrigin-RevId: 376926489
14 files changed, 19 insertions, 57 deletions
diff --git a/factory/pom.xml b/factory/pom.xml index dd680c99..b7f351db 100644 --- a/factory/pom.xml +++ b/factory/pom.xml @@ -71,7 +71,7 @@ <dependency> <groupId>com.google.auto</groupId> <artifactId>auto-common</artifactId> - <version>1.0</version> + <version>1.0.1</version> </dependency> <dependency> <groupId>com.google.auto.value</groupId> diff --git a/service/processor/pom.xml b/service/processor/pom.xml index a342a254..4e525d47 100644 --- a/service/processor/pom.xml +++ b/service/processor/pom.xml @@ -49,7 +49,7 @@ <dependency> <groupId>com.google.auto</groupId> <artifactId>auto-common</artifactId> - <version>1.0</version> + <version>1.0.1</version> </dependency> <dependency> <groupId>com.google.guava</groupId> diff --git a/service/processor/src/main/java/com/google/auto/service/processor/AutoServiceProcessor.java b/service/processor/src/main/java/com/google/auto/service/processor/AutoServiceProcessor.java index 932a0fdf..cb4bc46f 100644 --- a/service/processor/src/main/java/com/google/auto/service/processor/AutoServiceProcessor.java +++ b/service/processor/src/main/java/com/google/auto/service/processor/AutoServiceProcessor.java @@ -17,8 +17,8 @@ package com.google.auto.service.processor; import static com.google.auto.common.AnnotationMirrors.getAnnotationValue; import static com.google.auto.common.MoreElements.getAnnotationMirror; +import static com.google.auto.common.MoreStreams.toImmutableSet; import static com.google.common.base.Throwables.getStackTraceAsString; -import static com.google.common.collect.ImmutableSet.toImmutableSet; import com.google.auto.common.MoreElements; import com.google.auto.common.MoreTypes; diff --git a/value/processor/pom.xml b/value/processor/pom.xml index 4980fffa..19a2607c 100644 --- a/value/processor/pom.xml +++ b/value/processor/pom.xml @@ -49,7 +49,7 @@ <dependency> <groupId>com.google.auto</groupId> <artifactId>auto-common</artifactId> - <version>1.0</version> + <version>1.0.1</version> </dependency> <dependency> <groupId>com.google.auto.service</groupId> diff --git a/value/src/main/java/com/google/auto/value/extension/memoized/processor/MemoizeExtension.java b/value/src/main/java/com/google/auto/value/extension/memoized/processor/MemoizeExtension.java index 50dab429..2cf0e7ad 100644 --- a/value/src/main/java/com/google/auto/value/extension/memoized/processor/MemoizeExtension.java +++ b/value/src/main/java/com/google/auto/value/extension/memoized/processor/MemoizeExtension.java @@ -19,12 +19,12 @@ import static com.google.auto.common.AnnotationMirrors.getAnnotationValue; import static com.google.auto.common.GeneratedAnnotationSpecs.generatedAnnotationSpec; import static com.google.auto.common.MoreElements.getPackage; import static com.google.auto.common.MoreElements.isAnnotationPresent; +import static com.google.auto.common.MoreStreams.toImmutableList; +import static com.google.auto.common.MoreStreams.toImmutableSet; import static com.google.auto.value.extension.memoized.processor.ClassNames.MEMOIZED_NAME; import static com.google.auto.value.extension.memoized.processor.MemoizedValidator.getAnnotationMirror; import static com.google.common.base.Predicates.equalTo; import static com.google.common.base.Predicates.not; -import static com.google.common.collect.ImmutableList.toImmutableList; -import static com.google.common.collect.ImmutableSet.toImmutableSet; import static com.google.common.collect.Iterables.filter; import static com.google.common.collect.Iterables.getOnlyElement; import static com.google.common.collect.Sets.union; diff --git a/value/src/main/java/com/google/auto/value/extension/serializable/processor/SerializableAutoValueExtension.java b/value/src/main/java/com/google/auto/value/extension/serializable/processor/SerializableAutoValueExtension.java index 2f59e5d2..5143d8bf 100644 --- a/value/src/main/java/com/google/auto/value/extension/serializable/processor/SerializableAutoValueExtension.java +++ b/value/src/main/java/com/google/auto/value/extension/serializable/processor/SerializableAutoValueExtension.java @@ -15,9 +15,9 @@ */ package com.google.auto.value.extension.serializable.processor; +import static com.google.auto.common.MoreStreams.toImmutableList; +import static com.google.auto.common.MoreStreams.toImmutableMap; import static com.google.auto.value.extension.serializable.processor.ClassNames.SERIALIZABLE_AUTO_VALUE_NAME; -import static com.google.common.collect.ImmutableList.toImmutableList; -import static com.google.common.collect.ImmutableMap.toImmutableMap; import static java.util.stream.Collectors.joining; import com.google.auto.common.GeneratedAnnotationSpecs; diff --git a/value/src/main/java/com/google/auto/value/extension/toprettystring/processor/ExtensionClassTypeSpecBuilder.java b/value/src/main/java/com/google/auto/value/extension/toprettystring/processor/ExtensionClassTypeSpecBuilder.java index 528126af..e2381f7e 100644 --- a/value/src/main/java/com/google/auto/value/extension/toprettystring/processor/ExtensionClassTypeSpecBuilder.java +++ b/value/src/main/java/com/google/auto/value/extension/toprettystring/processor/ExtensionClassTypeSpecBuilder.java @@ -20,9 +20,9 @@ import static com.google.auto.common.AnnotationMirrors.getAnnotationValue; import static com.google.auto.common.GeneratedAnnotationSpecs.generatedAnnotationSpec; import static com.google.auto.common.MoreElements.getPackage; import static com.google.auto.common.MoreElements.isAnnotationPresent; +import static com.google.auto.common.MoreStreams.toImmutableList; +import static com.google.auto.common.MoreStreams.toImmutableSet; import static com.google.auto.value.extension.toprettystring.processor.Annotations.getAnnotationMirror; -import static com.google.common.collect.ImmutableList.toImmutableList; -import static com.google.common.collect.ImmutableSet.toImmutableSet; import static com.google.common.collect.Sets.union; import static com.squareup.javapoet.MethodSpec.constructorBuilder; import static com.squareup.javapoet.TypeSpec.classBuilder; diff --git a/value/src/main/java/com/google/auto/value/extension/toprettystring/processor/ToPrettyStringCollectors.java b/value/src/main/java/com/google/auto/value/extension/toprettystring/processor/ToPrettyStringCollectors.java deleted file mode 100644 index 8fdc1373..00000000 --- a/value/src/main/java/com/google/auto/value/extension/toprettystring/processor/ToPrettyStringCollectors.java +++ /dev/null @@ -1,38 +0,0 @@ -/* - * Copyright 2021 Google LLC - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package com.google.auto.value.extension.toprettystring.processor; - -import static java.util.stream.Collectors.collectingAndThen; -import static java.util.stream.Collectors.toCollection; -import static java.util.stream.Collectors.toList; - -import com.google.common.collect.ImmutableList; -import com.google.common.collect.ImmutableSet; -import java.util.LinkedHashSet; -import java.util.stream.Collector; - -final class ToPrettyStringCollectors { - static <E> Collector<E, ?, ImmutableList<E>> toImmutableList() { - return collectingAndThen(toList(), ImmutableList::copyOf); - } - - static <E> Collector<E, ?, ImmutableSet<E>> toImmutableSet() { - return collectingAndThen(toCollection(LinkedHashSet::new), ImmutableSet::copyOf); - } - - private ToPrettyStringCollectors() {} -} diff --git a/value/src/main/java/com/google/auto/value/extension/toprettystring/processor/ToPrettyStringExtension.java b/value/src/main/java/com/google/auto/value/extension/toprettystring/processor/ToPrettyStringExtension.java index 968e7b75..134fcac4 100644 --- a/value/src/main/java/com/google/auto/value/extension/toprettystring/processor/ToPrettyStringExtension.java +++ b/value/src/main/java/com/google/auto/value/extension/toprettystring/processor/ToPrettyStringExtension.java @@ -17,9 +17,9 @@ package com.google.auto.value.extension.toprettystring.processor; import static com.google.auto.common.MoreElements.getLocalAndInheritedMethods; +import static com.google.auto.common.MoreStreams.toImmutableList; import static com.google.auto.common.MoreTypes.asTypeElement; import static com.google.auto.value.extension.toprettystring.processor.ExtensionClassTypeSpecBuilder.extensionClassTypeSpecBuilder; -import static com.google.auto.value.extension.toprettystring.processor.ToPrettyStringCollectors.toImmutableList; import static com.google.auto.value.extension.toprettystring.processor.ToPrettyStringMethods.toPrettyStringMethod; import static com.google.auto.value.extension.toprettystring.processor.ToPrettyStringMethods.toPrettyStringMethods; import static com.google.common.collect.Iterables.getLast; diff --git a/value/src/main/java/com/google/auto/value/extension/toprettystring/processor/ToPrettyStringMethods.java b/value/src/main/java/com/google/auto/value/extension/toprettystring/processor/ToPrettyStringMethods.java index b5b1242b..041a16d6 100644 --- a/value/src/main/java/com/google/auto/value/extension/toprettystring/processor/ToPrettyStringMethods.java +++ b/value/src/main/java/com/google/auto/value/extension/toprettystring/processor/ToPrettyStringMethods.java @@ -17,9 +17,9 @@ package com.google.auto.value.extension.toprettystring.processor; import static com.google.auto.common.MoreElements.getLocalAndInheritedMethods; +import static com.google.auto.common.MoreStreams.toImmutableList; +import static com.google.auto.common.MoreStreams.toImmutableSet; import static com.google.auto.value.extension.toprettystring.processor.Annotations.toPrettyStringAnnotation; -import static com.google.auto.value.extension.toprettystring.processor.ToPrettyStringCollectors.toImmutableList; -import static com.google.auto.value.extension.toprettystring.processor.ToPrettyStringCollectors.toImmutableSet; import static com.google.common.collect.MoreCollectors.toOptional; import com.google.auto.value.extension.AutoValueExtension.Context; diff --git a/value/src/main/java/com/google/auto/value/processor/AutoBuilderProcessor.java b/value/src/main/java/com/google/auto/value/processor/AutoBuilderProcessor.java index 5952f624..7a700431 100644 --- a/value/src/main/java/com/google/auto/value/processor/AutoBuilderProcessor.java +++ b/value/src/main/java/com/google/auto/value/processor/AutoBuilderProcessor.java @@ -17,10 +17,10 @@ package com.google.auto.value.processor; import static com.google.auto.common.MoreElements.getLocalAndInheritedMethods; import static com.google.auto.common.MoreElements.getPackage; +import static com.google.auto.common.MoreStreams.toImmutableList; +import static com.google.auto.common.MoreStreams.toImmutableSet; import static com.google.auto.value.processor.AutoValueProcessor.OMIT_IDENTIFIERS_OPTION; import static com.google.auto.value.processor.ClassNames.AUTO_BUILDER_NAME; -import static com.google.common.collect.ImmutableList.toImmutableList; -import static com.google.common.collect.ImmutableSet.toImmutableSet; import static java.util.stream.Collectors.joining; import static java.util.stream.Collectors.toCollection; import static java.util.stream.Collectors.toMap; diff --git a/value/src/main/java/com/google/auto/value/processor/AutoValueishProcessor.java b/value/src/main/java/com/google/auto/value/processor/AutoValueishProcessor.java index 8237b82e..1d6f0266 100644 --- a/value/src/main/java/com/google/auto/value/processor/AutoValueishProcessor.java +++ b/value/src/main/java/com/google/auto/value/processor/AutoValueishProcessor.java @@ -19,9 +19,9 @@ import static com.google.auto.common.AnnotationMirrors.getAnnotationValue; import static com.google.auto.common.GeneratedAnnotations.generatedAnnotation; import static com.google.auto.common.MoreElements.getPackage; import static com.google.auto.common.MoreElements.isAnnotationPresent; +import static com.google.auto.common.MoreStreams.toImmutableSet; import static com.google.auto.value.processor.ClassNames.AUTO_VALUE_PACKAGE_NAME; import static com.google.auto.value.processor.ClassNames.COPY_ANNOTATIONS_NAME; -import static com.google.common.collect.ImmutableSet.toImmutableSet; import static com.google.common.collect.Iterables.getOnlyElement; import static com.google.common.collect.Sets.union; import static java.util.stream.Collectors.joining; diff --git a/value/src/main/java/com/google/auto/value/processor/BuilderMethodClassifierForAutoBuilder.java b/value/src/main/java/com/google/auto/value/processor/BuilderMethodClassifierForAutoBuilder.java index 94b258f1..55a31983 100644 --- a/value/src/main/java/com/google/auto/value/processor/BuilderMethodClassifierForAutoBuilder.java +++ b/value/src/main/java/com/google/auto/value/processor/BuilderMethodClassifierForAutoBuilder.java @@ -15,8 +15,8 @@ */ package com.google.auto.value.processor; -import static com.google.common.collect.ImmutableBiMap.toImmutableBiMap; -import static com.google.common.collect.ImmutableMap.toImmutableMap; +import static com.google.auto.common.MoreStreams.toImmutableBiMap; +import static com.google.auto.common.MoreStreams.toImmutableMap; import com.google.auto.common.MoreElements; import com.google.auto.common.MoreTypes; diff --git a/value/src/main/java/com/google/auto/value/processor/TypeVariables.java b/value/src/main/java/com/google/auto/value/processor/TypeVariables.java index 75186f11..ae27f91b 100644 --- a/value/src/main/java/com/google/auto/value/processor/TypeVariables.java +++ b/value/src/main/java/com/google/auto/value/processor/TypeVariables.java @@ -15,7 +15,7 @@ */ package com.google.auto.value.processor; -import static com.google.common.collect.ImmutableMap.toImmutableMap; +import static com.google.auto.common.MoreStreams.toImmutableMap; import com.google.auto.common.MoreElements; import com.google.auto.common.MoreTypes; |