diff options
| author | dpb <dpb@google.com> | 2018-11-29 08:30:33 -0800 |
|---|---|---|
| committer | Ron Shapiro <shapiro.rd@gmail.com> | 2018-12-03 17:12:05 -0500 |
| commit | 2a5d8850b4e08a363072e692856362ba420937ef (patch) | |
| tree | 2429f1bd8982b8a2566888765bea02d46904f665 /common | |
| parent | e0b8c93fcdf47670ea3f3692e5243cf256dfcaab (diff) | |
| download | auto-2a5d8850b4e08a363072e692856362ba420937ef.tar.gz | |
Ignore ECJ test in JDK 10 and 11 since ECJ doesn't work for us in those versions of the JDK.
RELNOTES=n/a
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=223350143
Diffstat (limited to 'common')
| -rw-r--r-- | common/src/test/java/com/google/auto/common/OverridesTest.java | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/common/src/test/java/com/google/auto/common/OverridesTest.java b/common/src/test/java/com/google/auto/common/OverridesTest.java index 17d273db..d785b8cf 100644 --- a/common/src/test/java/com/google/auto/common/OverridesTest.java +++ b/common/src/test/java/com/google/auto/common/OverridesTest.java @@ -75,12 +75,14 @@ import org.junit.runners.model.Statement; */ @RunWith(Parameterized.class) public class OverridesTest { + private static final ImmutableSet<String> TOO_NEW_FOR_ECJ = ImmutableSet.of("9", "10", "11"); + @Parameterized.Parameters(name = "{0}") public static List<Object[]> data() { List<Object[]> compilerTypes = new ArrayList<Object[]>(); compilerTypes.add(new Object[] {CompilerType.JAVAC}); - if (!"9".equals(JAVA_SPECIFICATION_VERSION.value())) { - // TODO(emcmanus): make this test pass with ECJ on Java 9. + if (!TOO_NEW_FOR_ECJ.contains(JAVA_SPECIFICATION_VERSION.value())) { + // TODO(emcmanus): make this test pass with ECJ on Java > 8. // Currently it complains because it can't find java.lang.Object. Probably we need a newer // version of ECJ. compilerTypes.add(new Object[] {CompilerType.ECJ}); |