diff options
author | cushon <cushon@google.com> | 2019-05-16 10:48:16 -0700 |
---|---|---|
committer | Ron Shapiro <shapiro.rd@gmail.com> | 2019-05-27 12:17:56 -0400 |
commit | a8ecd1f0a7c1fa65f081d1f0847976ca5c2dcfb5 (patch) | |
tree | 52171bdac775db197b40d05316eb96a58a07077f /factory/src/test | |
parent | 6b9005c0fa68b45a3788878e1383f2f713062d4e (diff) | |
download | auto-a8ecd1f0a7c1fa65f081d1f0847976ca5c2dcfb5.tar.gz |
Don't compare TypeMirrors using Object#equals
They don't override Object#equals and are not interned, so reference
equality is not useful. This was causing unnecessary duplication of
Provider fields in AutoFactories.
RELNOTES=n/a
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=248752047
Diffstat (limited to 'factory/src/test')
-rw-r--r-- | factory/src/test/resources/expected/CheckerFrameworkNullableFactory.java | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/factory/src/test/resources/expected/CheckerFrameworkNullableFactory.java b/factory/src/test/resources/expected/CheckerFrameworkNullableFactory.java index bea01e98..79175c7e 100644 --- a/factory/src/test/resources/expected/CheckerFrameworkNullableFactory.java +++ b/factory/src/test/resources/expected/CheckerFrameworkNullableFactory.java @@ -27,24 +27,21 @@ import org.checkerframework.checker.nullness.compatqual.NullableType; ) final class CheckerFrameworkNullableFactory { - private final Provider<String> providedNullableDeclProvider; - private final Provider<String> providedNullableTypeProvider; + private final Provider<String> java_lang_StringProvider; @Inject CheckerFrameworkNullableFactory( - Provider<String> providedNullableDeclProvider, - Provider<String> providedNullableTypeProvider) { - this.providedNullableDeclProvider = checkNotNull(providedNullableDeclProvider, 1); - this.providedNullableTypeProvider = checkNotNull(providedNullableTypeProvider, 2); + Provider<String> java_lang_StringProvider) { + this.java_lang_StringProvider = checkNotNull(java_lang_StringProvider, 1); } CheckerFrameworkNullable create( @NullableDecl String nullableDecl, @NullableType String nullableType) { return new CheckerFrameworkNullable( nullableDecl, - providedNullableDeclProvider.get(), + java_lang_StringProvider.get(), nullableType, - providedNullableTypeProvider.get()); + java_lang_StringProvider.get()); } private static <T> T checkNotNull(T reference, int argumentIndex) { |