aboutsummaryrefslogtreecommitdiff
path: root/common
AgeCommit message (Collapse)Author
2022-03-04Update Android.bp for upstream mergeColin Cross
Test: m checkbuild Change-Id: I3580bd1fdc55ee04ff9700eef3c8bc03d4dd6601
2022-03-04Merge commit 'auto-value-1.8.2^'Colin Cross
Bug: 219098645 Test: m checkbuild Change-Id: I64e22d75b4f077b3e4cdfb13b42239d95ae9e86c
2021-06-30Avoid wildcards, which confuse our nullness checker.cpovirk
Specifically, wildcards defeat our ability to recognize that `containsKey` guarantees that `get` will return non-null. See https://github.com/jspecify/nullness-checker-for-checker-framework/blob/a13e6921d6e23ec1349be007b5e9a6d1f279c91c/src/main/java/com/google/jspecify/nullness/NullSpecTransfer.java#L603 Without this CL, Auto-Common would break when I submit CL 382342656 to annotate the remaining immutable-map classes. Arguably we should have a specific issue open for this problem, but: - This may be the first time it's come up in practice. - _Everything_ about wildcards in our checker is weird, thanks to a combination of the Checker Framework's unusual handling of them (which they are fixing by implementing capture conversion) and our hacks on top of that (which we hope can go away). (The very general project of "remove our hacks" is tracked by https://github.com/jspecify/checker-framework/issues/4#issuecomment-763111013 and other issues there.) RELNOTES=n/a PiperOrigin-RevId: 382352859
2021-06-30Annotate auto-common for nullness.Éamonn McManus
RELNOTES=`com.google.auto.common` is annotated for null-safety. PiperOrigin-RevId: 382311770
2021-06-28Use more fluent streams constructs.Éamonn McManus
Previously we avoided collectors like `toImmutableList()` because of Google-internal problems where sometimes we would end up with a version of Guava that didn't include those methods. Now we have copies of the methods in `MoreStreams` so we can use those. RELNOTES=n/a PiperOrigin-RevId: 381898090
2021-06-03Apply a few automated suggestions.Éamonn McManus
RELNOTES=n/a PiperOrigin-RevId: 377297134
2021-06-03Add String and TypeElement versions of auto-common APIs that currently take ↵Brad Corso
in Class. These changes continue the effort to move away from referencing classes from the user API directly in processors, which can cause issues especially with Android dependencies. Note: I decided not to do anything with isTypeOf yet because I'm not sure of a great way to support that. RELNOTES=Add String and TypeElement versions of auto-common APIs that currently take in Class. PiperOrigin-RevId: 377287397
2021-06-02Reformat all the Auto projects using google-java-format. For now, javadoc ↵Éamonn McManus
reformatting is excluded. RELNOTES=n/a PiperOrigin-RevId: 377145832
2021-06-01Replace server Guava API usage with Android compatible alternatives.Brad Corso
The issue occurs when the Android flavor of Guava somehow finds its way onto the processor class path and gets classloaded instead of the server Guava. The ideal solution would be to just keep the Android flavor of Guava off of the processor class path. However, it's been something that we've allowed for a while now, e.g. in Dagger, and would be difficult to start enforcing. This CL adds a new API for auto-common. A follow-up CL will update auto-value and auto-service to depend on the new auto-common APIs once auto-common has a release with those changes. RELNOTES=Added new public APIs for guava collector usage (toImmutable*) that are Android-compatible. PiperOrigin-RevId: 376892205
2021-05-26Bump truth from 1.1.2 to 1.1.3 in /commondependabot[bot]
Bumps [truth](https://github.com/google/truth) from 1.1.2 to 1.1.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/google/truth/releases">truth's releases</a>.</em></p> <blockquote> <h2>1.1.3</h2> <ul> <li>Fixed a bug in how <code>comparingExpectedFieldsOnly()</code> handles <code>oneof</code> fields. (f27208428)</li> <li>Improved <code>comparingExpectedFieldsOnly</code> to work when required fields are absent. (f27208428)</li> <li>Changed <code>Subject.toString()</code> to throw <code>UnsupportedOperationException</code>. (fa4c7b512)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/google/truth/commits">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.google.truth:truth&package-manager=maven&previous-version=1.1.2&new-version=1.1.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Fixes #1103 COPYBARA_INTEGRATE_REVIEW=https://github.com/google/auto/pull/1103 from google:dependabot/maven/common/com.google.truth-truth-1.1.3 91762d77ae2b31df62921b9120b7d76407f4457e PiperOrigin-RevId: 375932815
2021-05-13Fix a crash when `getLocalAndInheritedMethods` is called with a raw-type ↵Éamonn McManus
ancestor. RELNOTES=Fixed a crash when `getLocalAndInheritedMethods` is called with a raw-type ancestor. PiperOrigin-RevId: 373583104
2021-04-30Remove "Processor Resilience" section now that Auto Common 1.0 has been releasedThomas Broyer
Fixes #1085 COPYBARA_INTEGRATE_REVIEW=https://github.com/google/auto/pull/1085 from tbroyer:patch-1 3468b1253f4f4f1b5276fed94f9db1ea99d614e9 PiperOrigin-RevId: 371409446
2021-04-20`MoreTypes.isTypeOf` returns false for `ErrorType` rather than throwing.Éamonn McManus
Throwing `IllegalArgumentException` can mask the real source of a problem, or prevent code that would have handled the `ErrorType` from running. The `ErrorType` typically (maybe always) corresponds to an identifier in the source code, so it is in fact a class, just one that doesn't exist. RELNOTES=MoreTypes.isTypeOf returns false for ErrorType rather than throwing. PiperOrigin-RevId: 369464743
2021-03-29Bump plexus-java from 1.0.6 to 1.0.7 in /commondependabot[bot]
Bumps [plexus-java](https://github.com/codehaus-plexus/plexus-languages) from 1.0.6 to 1.0.7. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/1b9a66590acc07f59f0ab4124162c69ddc8f56ad"><code>1b9a665</code></a> [maven-release-plugin] prepare release plexus-languages-1.0.7</li> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/781600e5e7d9c22bbf0701fe04f4e5f114fb62e7"><code>781600e</code></a> [maven-release-plugin] rollback the release of plexus-languages-1.0.7</li> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/22b6e96aaf6995aef0901dc35ffec41f6b3681fc"><code>22b6e96</code></a> [maven-release-plugin] prepare release plexus-languages-1.0.7</li> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/d317fa13b8bcfa223ffdb6ee3f7984c01fbf6b0e"><code>d317fa1</code></a> Bump release-drafter/release-drafter from v5.13.0 to v5.15.0</li> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/83921e48375b14f5798e292a7b65053a807ab8f2"><code>83921e4</code></a> Bump actions/cache from v2.1.3 to v2.1.4</li> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/40f57c77923db5259485097988ca0538e844aa03"><code>40f57c7</code></a> Bump junit from 4.13.1 to 4.13.2</li> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/fbe59511ace6372b09cd34ca465d92bf69fa4edb"><code>fbe5951</code></a> <a href="https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/70">#70</a> Jars of which modulename extraction cause an exception should end up on t...</li> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/249f8bd6c55afdc281ed5c3185b20c3859e86b24"><code>249f8bd</code></a> <a href="https://github-redirect.dependabot.com/codehaus-plexus/plexus-languages/issues/64">#64</a> BinaryModuleInfoParser.parse does not take toolchain into account</li> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/a1b61e06394026b123517e57d89d7ecd0e9db939"><code>a1b61e0</code></a> [maven-release-plugin] prepare for next development iteration</li> <li>See full diff in <a href="https://github.com/codehaus-plexus/plexus-languages/compare/plexus-languages-1.0.6...plexus-languages-1.0.7">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.codehaus.plexus:plexus-java&package-manager=maven&previous-version=1.0.6&new-version=1.0.7)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Fixes #1035 COPYBARA_INTEGRATE_REVIEW=https://github.com/google/auto/pull/1035 from google:dependabot/maven/common/org.codehaus.plexus-plexus-java-1.0.7 841524dc6994c0816910ea451f8c50dd4b7c1049 PiperOrigin-RevId: 365562287
2021-03-22Bump guava.version from 30.1-jre to 30.1.1-jre in /commondependabot[bot]
Bumps `guava.version` from 30.1-jre to 30.1.1-jre. Updates `guava` from 30.1-jre to 30.1.1-jre <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/google/guava/releases">guava's releases</a>.</em></p> <blockquote> <h2>30.1.1</h2> <h3>Maven</h3> <pre lang="xml"><code>&lt;dependency&gt; &lt;groupId&gt;com.google.guava&lt;/groupId&gt; &lt;artifactId&gt;guava&lt;/artifactId&gt; &lt;version&gt;30.1.1-jre&lt;/version&gt; &lt;!-- or, for Android: --&gt; &lt;version&gt;30.1.1-android&lt;/version&gt; &lt;/dependency&gt; </code></pre> <h3>Javadoc</h3> <ul> <li><a href="http://guava.dev/releases/30.1.1-jre/api/docs/">30.1.1-jre</a></li> <li><a href="http://guava.dev/releases/30.1.1-android/api/docs/">30.1.1-android</a></li> </ul> <h3>JDiff</h3> <ul> <li><a href="http://guava.dev/releases/30.1.1-jre/api/diffs/">30.1.1-jre vs. 30.1-jre</a></li> <li><a href="http://guava.dev/releases/30.1.1-android/api/diffs/">30.1.1-android vs. 30.1-android</a></li> <li><a href="http://guava.dev/releases/30.1.1-android/api/androiddiffs/">30.1.1-android vs. 30.1.1-jre</a></li> </ul> <h3>Changelog</h3> <ul> <li>Increased the aggressiveness of <a href="https://github.com/google/guava/releases/tag/v30.1">Guava 30.1</a>'s warning log message for running <code>guava-android</code> under a Java 7 VM. (Android VMs are unaffected.) If the warning <em>itself</em> causes you trouble, you can eliminate it by silencing the logger for <code>com.google.common.base.Preconditions</code> (which is used <em>only</em> for this warning). This warning prepares for <a href="https://github-redirect.dependabot.com/google/guava/issues/5269">removing support for Java 7 in 2021</a>. Please report any problems. We have tried to make the warning as safe as possible, but anytime a common library logs, especially as aggressively as we do in this new release, there is the potential for <a href="https://stackoverflow.com/a/41017717/28465"><code>NullPointerException</code></a> or even <a href="https://stackoverflow.com/a/48009613/28465">deadlock</a>. (To be clear, Guava will not log under Java 8 or Android, but it will under Java 7.) (00c25e9b11)</li> <li><code>cache</code>: Fixed compatibility between <code>asMap().compute(...)</code> and a load. (42bf4f4eb7)</li> <li><code>cache</code>: Added <code>@CheckReturnValue</code> to some APIs. (a5ef129ffc)</li> <li><code>collect</code>: Added <code>@DoNotCall</code> to the mutator methods on immutable types (6ae9532d11)</li> <li><code>hash</code>: Removed <code>@Beta</code> from <code>HashCode</code>. (2c9f161e10)</li> <li><code>io</code>: Removed <code>@Beta</code> from <code>CountingOutputStream</code>. (d394bac847)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/google/guava/commits">compare view</a></li> </ul> </details> <br /> Updates `guava-testlib` from 30.1-jre to 30.1.1-jre <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/google/guava/releases">guava-testlib's releases</a>.</em></p> <blockquote> <h2>30.1.1</h2> <h3>Maven</h3> <pre lang="xml"><code>&lt;dependency&gt; &lt;groupId&gt;com.google.guava&lt;/groupId&gt; &lt;artifactId&gt;guava&lt;/artifactId&gt; &lt;version&gt;30.1.1-jre&lt;/version&gt; &lt;!-- or, for Android: --&gt; &lt;version&gt;30.1.1-android&lt;/version&gt; &lt;/dependency&gt; </code></pre> <h3>Javadoc</h3> <ul> <li><a href="http://guava.dev/releases/30.1.1-jre/api/docs/">30.1.1-jre</a></li> <li><a href="http://guava.dev/releases/30.1.1-android/api/docs/">30.1.1-android</a></li> </ul> <h3>JDiff</h3> <ul> <li><a href="http://guava.dev/releases/30.1.1-jre/api/diffs/">30.1.1-jre vs. 30.1-jre</a></li> <li><a href="http://guava.dev/releases/30.1.1-android/api/diffs/">30.1.1-android vs. 30.1-android</a></li> <li><a href="http://guava.dev/releases/30.1.1-android/api/androiddiffs/">30.1.1-android vs. 30.1.1-jre</a></li> </ul> <h3>Changelog</h3> <ul> <li>Increased the aggressiveness of <a href="https://github.com/google/guava/releases/tag/v30.1">Guava 30.1</a>'s warning log message for running <code>guava-android</code> under a Java 7 VM. (Android VMs are unaffected.) If the warning <em>itself</em> causes you trouble, you can eliminate it by silencing the logger for <code>com.google.common.base.Preconditions</code> (which is used <em>only</em> for this warning). This warning prepares for <a href="https://github-redirect.dependabot.com/google/guava/issues/5269">removing support for Java 7 in 2021</a>. Please report any problems. We have tried to make the warning as safe as possible, but anytime a common library logs, especially as aggressively as we do in this new release, there is the potential for <a href="https://stackoverflow.com/a/41017717/28465"><code>NullPointerException</code></a> or even <a href="https://stackoverflow.com/a/48009613/28465">deadlock</a>. (To be clear, Guava will not log under Java 8 or Android, but it will under Java 7.) (00c25e9b11)</li> <li><code>cache</code>: Fixed compatibility between <code>asMap().compute(...)</code> and a load. (42bf4f4eb7)</li> <li><code>cache</code>: Added <code>@CheckReturnValue</code> to some APIs. (a5ef129ffc)</li> <li><code>collect</code>: Added <code>@DoNotCall</code> to the mutator methods on immutable types (6ae9532d11)</li> <li><code>hash</code>: Removed <code>@Beta</code> from <code>HashCode</code>. (2c9f161e10)</li> <li><code>io</code>: Removed <code>@Beta</code> from <code>CountingOutputStream</code>. (d394bac847)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/google/guava/commits">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Fixes #1021 COPYBARA_INTEGRATE_REVIEW=https://github.com/google/auto/pull/1021 from google:dependabot/maven/common/guava.version-30.1.1-jre 59585adc041c4bb4da1c230e02d38d9a95292be5 PiperOrigin-RevId: 364314012
2021-03-17Bump ecj from 3.24.0 to 3.25.0 in /commondependabot[bot]
Bumps ecj from 3.24.0 to 3.25.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.eclipse.jdt:ecj&package-manager=maven&previous-version=3.24.0&new-version=3.25.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Fixes #1011 COPYBARA_INTEGRATE_REVIEW=https://github.com/google/auto/pull/1011 from google:dependabot/maven/common/org.eclipse.jdt-ecj-3.25.0 34ae56ad5f8385b168b884353c517f662b6b0601 PiperOrigin-RevId: 363433677
2021-02-16Add `toString()` implementations for `MoreTypes.equivalence()` and ↵Ron Shapiro
`AnnotationMirrors.equivalence()` They often come up in debugging information RELNOTES=n/a PiperOrigin-RevId: 357734043
2021-02-15Bump junit from 4.13.1 to 4.13.2 in /commondependabot[bot]
Bumps [junit](https://github.com/junit-team/junit4) from 4.13.1 to 4.13.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit4/releases">junit's releases</a>.</em></p> <blockquote> <h2>JUnit 4.13.2</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.2.md">release notes</a> for details.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/junit-team/junit4/commit/05fe2a64f59127c02135be22f416e91260d6ede6"><code>05fe2a6</code></a> [maven-release-plugin] prepare release r4.13.2</li> <li><a href="https://github.com/junit-team/junit4/commit/ff57344f7171ea8b0935c4f842cacf1097266592"><code>ff57344</code></a> Add build for JDK 17-ea</li> <li><a href="https://github.com/junit-team/junit4/commit/02aaa01b8f74c0eb496d76685ec49fddeb311087"><code>02aaa01</code></a> Improve check that thread is stopped</li> <li><a href="https://github.com/junit-team/junit4/commit/e9a75f4be71a4d5a794ccd063522eea4b0f3194f"><code>e9a75f4</code></a> Merge test for exception type and message</li> <li><a href="https://github.com/junit-team/junit4/commit/d27ad5259228e84c235dac24cd62f974ac0a8e1d"><code>d27ad52</code></a> Rename DelegateStatement to DelegatingStatement</li> <li><a href="https://github.com/junit-team/junit4/commit/b83dc2e8c4ff06cf233cd347f1280bb417482985"><code>b83dc2e</code></a> Better name for test that stops statement</li> <li><a href="https://github.com/junit-team/junit4/commit/527f3a3d0d71ad6dc66ede6f68f6fc316904ed2a"><code>527f3a3</code></a> Replace InfiniteLoop with RunForASecond</li> <li><a href="https://github.com/junit-team/junit4/commit/2db63942882d91020b46d7333285e5c94f1d1e52"><code>2db6394</code></a> Tidy up FailOnTimeoutTest</li> <li><a href="https://github.com/junit-team/junit4/commit/64634e1c3e357251a84278c26b73b04fc3450ea3"><code>64634e1</code></a> Update 4.13.2 release notes to document pull 1654</li> <li><a href="https://github.com/junit-team/junit4/commit/f8ee412316b1a94d3dc35498359cc2f0ca273216"><code>f8ee412</code></a> Fix serialization of AssumptionViolatedException (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1654">#1654</a>)</li> <li>Additional commits viewable in <a href="https://github.com/junit-team/junit4/compare/r4.13.1...r4.13.2">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=junit:junit&package-manager=maven&previous-version=4.13.1&new-version=4.13.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Fixes #988 COPYBARA_INTEGRATE_REVIEW=https://github.com/google/auto/pull/988 from google:dependabot/maven/common/junit-junit-4.13.2 07c4a973c4258652ab13ed12fd808d64b27b3437 PiperOrigin-RevId: 357654071
2021-02-12[LSC] Add LOCAL_LICENSE_KINDS to external/autoandroid-s-preview-1Bob Badour
Added SPDX-license-identifier-Apache-2.0 to: Android.bp android-annotation-stubs/Android.bp common/Android.bp factory/Android.bp service/Android.bp value/Android.bp Bug: 68860345 Bug: 151177513 Bug: 151953481 Test: m all Exempt-From-Owner-Approval: janitorial work Change-Id: I213d1de311f7729ccee0ad86219ef1bfb4d944a9
2021-01-26Bump truth from 1.1 to 1.1.2 in /commondependabot[bot]
Bumps [truth](https://github.com/google/truth) from 1.1 to 1.1.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/google/truth/releases">truth's releases</a>.</em></p> <blockquote> <h2>1.1.2</h2> <p>This release completes the feature that I got wrong in <a href="https://github.com/google/truth/releases/tag/release_1_1_1">1.1.1</a> -- the ability to exclude our JUnit 4 dependency and still use standard Truth assertions.</p> <ul> <li>Made it possible for users to exclude our JUnit 4 dependency and still use standard Truth assertions -- <em>really</em> this time, even in cases in which excluding the dependency failed under <a href="https://github.com/google/truth/releases/tag/release_1_1_1">1.1.1</a>. (JUnit 4 is still required for some advanced features, like <code>Expect</code>, <code>ExpectFailure</code>, and <code>TruthJUnit.assume()</code>.) (948f3edca)</li> <li>When JUnit 4 is excluded from the classpath, the <code>AssertionError</code> Truth generates as a substitute for <code>ComparisonFailure</code> now includes the expected and actual values that were missing in <a href="https://github.com/google/truth/releases/tag/release_1_1_1">1.1.1</a>. (6b0140730)</li> </ul> <h2>1.1.1</h2> <p><strong>We recommend not trying to exclude our JUnit dependency even under this release. We will release 1.1.2 with better handling for the missing dependency shortly.</strong></p> <ul> <li><del>Made it possible for users to exclude our JUnit 4 dependency and still use standard Truth assertions. (JUnit 4 is still required for some advanced features, like <code>Expect</code>, <code>ExpectFailure</code>, and <code>TruthJUnit.assume()</code>.) (2d65326ec)</del> <ul> <li><strong>Update:</strong> This appears to let users exclude the dependency in some cases <a href="https://github-redirect.dependabot.com/google/truth/issues/333#issuecomment-765616282">but not all</a>. We are working on <a href="https://github-redirect.dependabot.com/google/truth/pull/806">a fix</a>.</li> <li><strong>Update 2:</strong> Also, even if you succeed in excluding the dependency in your environment, you will see failure messages that are missing information. We have <a href="https://github.com/google/truth/commit/6b0140730fa0e3ebb3056ddb0ae30863bbf95364">a fix</a> for this ready.</li> </ul> </li> </ul> <p>If you wish to exclude our JUnit dependency, you may wish to consider <a href="https://github-redirect.dependabot.com/google/truth/issues/333#issuecomment-765616282">this alternative approach</a>. That approach <a href="https://github-redirect.dependabot.com/google/truth/issues/333#issuecomment-765677646">may be worthwhile even after we fix the bugs described above</a>.</p> <p>I apologize for the trouble.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/google/truth/commits">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.google.truth:truth&package-manager=maven&previous-version=1.1&new-version=1.1.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Fixes #975 COPYBARA_INTEGRATE_REVIEW=https://github.com/google/auto/pull/975 from google:dependabot/maven/common/com.google.truth-truth-1.1.2 bdf0d3843f38018a1340f9c38b0445d36a5a7530 PiperOrigin-RevId: 353866900
2021-01-15Bump plexus-java from 1.0.5 to 1.0.6 in /commondependabot[bot]
Bumps [plexus-java](https://github.com/codehaus-plexus/plexus-languages) from 1.0.5 to 1.0.6. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/29371988cece5c37e2f6e661d249ca4a897e5988"><code>2937198</code></a> [maven-release-plugin] prepare release plexus-languages-1.0.6</li> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/e24c11531a55e7e234b3b7e5208c0b9c01216321"><code>e24c115</code></a> manage maven-javadoc-plugin version in root pom</li> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/695c2ca846dec90957d3b8c1b4881d60dfed32fa"><code>695c2ca</code></a> Update maven-shared-resources for maven-checkstyle-plugin</li> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/6473afcd32bdab490a6f53367c9b0eb54c07bfbd"><code>6473afc</code></a> Bump guice from 4.1.0 to 4.2.3</li> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/50a010b55f9c0e89a6e20c3a5b9e186c58d4e4de"><code>50a010b</code></a> Bump actions/cache from v2.1.2 to v2.1.3</li> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/4c4cb8acd760c502dc4b74bc93ae3328f1e8ad02"><code>4c4cb8a</code></a> Bump release-drafter/release-drafter from v5.11.0 to v5.13.0</li> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/93714422ea7ca907b1012930150ea3da3cd604d1"><code>9371442</code></a> Bump maven-enforcer-plugin from 3.0.0-M1 to 3.0.0-M3</li> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/bf4bb5488dabb99411055abd5e023cba52ff774d"><code>bf4bb54</code></a> Bump plexus from 6.5 to 7</li> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/1802e9fba5b48d96b6c17cdd13e76400edb56acb"><code>1802e9f</code></a> Bump sisu-maven-plugin from 0.3.3 to 0.3.4</li> <li><a href="https://github.com/codehaus-plexus/plexus-languages/commit/eaba96a1cbdf4ca2d9d3c79e017d993b9fa8d5a3"><code>eaba96a</code></a> Bump maven-failsafe-plugin from 2.21.0 to 2.22.2</li> <li>Additional commits viewable in <a href="https://github.com/codehaus-plexus/plexus-languages/compare/plexus-languages-1.0.5...plexus-languages-1.0.6">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.codehaus.plexus:plexus-java&package-manager=maven&previous-version=1.0.5&new-version=1.0.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Fixes #953 COPYBARA_INTEGRATE_REVIEW=https://github.com/google/auto/pull/953 from google:dependabot/maven/common/org.codehaus.plexus-plexus-java-1.0.6 1001b1089868ebc47f8013a67ba66fdf321bd4da PiperOrigin-RevId: 352054954
2020-12-21Bump guava.version from 30.0-jre to 30.1-jre in /commondependabot[bot]
Bumps `guava.version` from 30.0-jre to 30.1-jre. Updates `guava` from 30.0-jre to 30.1-jre - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) Updates `guava-testlib` from 30.0-jre to 30.1-jre - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) Signed-off-by: dependabot[bot] <support@github.com>
2020-12-21Bump ecj from 3.23.0 to 3.24.0 in /commondependabot[bot]
Bumps ecj from 3.23.0 to 3.24.0. Signed-off-by: dependabot[bot] <support@github.com>
2020-11-23Merge tags 'auto-value-1.7.4' and 'auto-common-0.11'Colin Cross
Bug: 173800389 Test: m checkbuild Change-Id: I5ae96c22de7eb6e17f127bd49a0782f2aea86e21
2020-11-16Fix Javadoc typos.David P. Baker
RELNOTES=n/a PiperOrigin-RevId: 342637604
2020-10-22Update versions of some plugins.cpovirk
Process: Just look at https://github.com/google/auto/pulls, grep for all files that contain the plugins mentioned, and edit them with Vim :) There might be other plugins that could be updated, too; I didn't check. Fixes #916 Fixes #913 Fixes #912 Fixes #910 Fixes #909 Fixes #907 Fixes #905 Fixes #902 Fixes #898 ...and, as with the previous CL, also "fixes" some PRs that Dependabot hasn't gotten around to submitting yet :) RELNOTES=n/a PiperOrigin-RevId: 338524539
2020-10-22Update a bunch of *deps* (though not *plugins*).cpovirk
Process: ( for F in common factory service value; do ( mvn org.codehaus.mojo:versions-maven-plugin:2.8.1:update-properties org.codehaus.mojo:versions-maven-plugin:2.8.1:use-latest-releases -f $F/pom.xml ); done && mvn org.codehaus.mojo:versions-maven-plugin:2.8.1:use-latest-versions -f value/src/it/gwtserializer/pom.xml ) Then undid the Compile-Testing update in value/pom.xml. It somehow breaks things. And I undid the google-java-format update in factory/pom.xml. It isn't compatible with JDK8/9, which is what Travis is set up for. (And then I flailed around for 15 minutes because Maven didn't rebuild some files when I changed JDKs, producing mystery failures. Argh. Perhaps we should set `<useIncrementalCompilation>` to `false` everywhere.) And *then* I undid the auto-service upgrade in value/processor/pom.xml. It causes problems but only under JDK9: https://travis-ci.org/github/google/auto/jobs/738096563 The error isn't in generated code, so I suspect a compiler bug. (But my quick search didn't find a filed OpenJDK issue.) (Someday I will remember -DgenerateBackupPoms=false....) For some reason, gwtserializer responds to use-latest-versions but not to use-latest-releases, even though it's updating GWT to a release (just as in one of the other POMs). We don't use use-latest-versions everywhere not just because it could theoretically pick a non-release versions but also because use-latest-versions replaces variable usages like ${guava-version} by inlining the value into them: https://github.com/mojohaus/versions-maven-plugin/issues/243 I would have updated the plugins in addition to the deps, but oddly the plugin does not support this: https://stackoverflow.com/q/34032262/28465 Fixes #919, #918, #917, #915, #914, #911, #908, #906, #904, #903, #901, #900, #899 RELNOTES=n/a PiperOrigin-RevId: 338507900
2020-09-03Correct docs to clarify that AutoValueExtension should be in a java_plugin ruleGoogle Java Core Libraries
PiperOrigin-RevId: 330014961
2020-09-01Remove redundant `hasNext()` checks. Since the `equalLists` method starts by ↵Éamonn McManus
checking that the lists have equal sizes, we can assume that `aIterator.hasNext()` ≡ `bIterator.hasNext()`. Fixes https://github.com/google/auto/issues/873. PiperOrigin-RevId: 329635623
2020-08-27Automatic code cleanup.Google Java Core Libraries
PiperOrigin-RevId: 326930055
2020-08-17Remove a stray semicolonronshapiro
RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=326930055
2020-08-11Set version number for auto-common to 0.11.upstream/auto-common-0.11upstream-auto-common-0.11Ron Shapiro
2020-08-07Update dependency versions.dpb
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=325291991
2020-07-29Add javadoc to the methods in SuperficialValidation. Also add a private ↵emcmanus
constructor, and rewrite some code to use streams. RELNOTES=Add javadoc for SuperficialValidation methods. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=323682147
2020-07-28Open SuperficialValidation#validateType(TypeMirror) to public visibilitybcorso
so it can be used from other internal code. RELNOTES=Open SuperficialValidation#validateType(TypeMirror) to public visibility ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=323425711
2020-06-18Add Android files to build AutoValueplatform-tools-30.0.4android-r-beta-3android-r-beta-2Colin Cross
Add Android.bp files, stubs for unused annotations, METADATA file and MODULE_LICENSE_APACHE2 file. Bug: 158870037 Test: m checkbuild Change-Id: Ibd9836e10c77c216af8d207c5347645e13cc2e3d
2020-06-18[ #HiltMigration ] Updating BasicAnnotationProcessor to support a ↵armandgray
String-based API. Context: Per discussion in [] this change adds a String-based `Step` class as a replacement for `ProcessingStep`. The new `Step` contains the same two methods (annotations() & process()) which return and accept fully-qualified annotation names. To support the potential absence of the annotation classes from the processor classpath the corresponding methods were changed to no longer depend on explicit Class types. RELNOTES=Adding String-based `Step` as a replacement for `ProcessingStep` to BasicAnnotationProcessor. Allows for fully-qualified Annotation names to be specified in a processing Step in order to remove the requirement that implementation processors depend directly on their Annotation classes. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=316968142
2020-04-15Update versions of Truth and Compile-testing.Sean Sullivan
Closes https://github.com/google/auto/pull/831 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=306447364
2020-03-16Refactor BasicAnnotationProcessor (3 of 3)bcorso
(Context: No rush on these reviews. I was just reading through BasicAnnotationProcessor and decided to clean some stuff up.) Removes some of the duplication between package and type elements in validElements() RELNOTES=N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=301196168
2020-03-13Apply a hack to OverridesTest so that it will work with newer versions of ecj.emcmanus
In Google's internal java8 compilation environment, problems with symbolic links mean that ecj can't find the standard system classes without this workaround. In other environments, including Google's java11, this problem doesn't arise. RELNOTES=Make OverridesTest work with Google's internal java8 compilation environment. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=300664328
2020-03-13Refactor BasicAnnotationProcessor (2 of 3)bcorso
This CL reduces some of the conversions between Set<ElementName> and Map<String, ? extends Optional<? extends Element>> where it's not needed. RELNOTES=N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=300565432
2020-03-10Refactor BasicAnnotationProcessor (1 of 3)bcorso
This CL just does a format fix and applies some error-prone suggestions on BasicAnnotationProcessor. RELNOTES=N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=299896536
2020-01-10Add MoreTypes.isConversionFromObjectUnchecked. This method tells, for a ↵emcmanus
given type, whether casting Object to that type will elicit an "unchecked" warning from the compiler. RELNOTES=Added MoreTypes.isConversionFromObjectUnchecked to test whether casting to a type will elicit an "unchecked" compiler warning. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288896286
2019-11-21Clarify the documentation of MoreTypes.nonObjectSuperclass.dpb
RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=281521515
2019-11-14Automated g4 rollback of changelist 279369564.bcorso
*** Reason for rollback *** :-( rolling this back again because it breaks some targets. java.lang.IllegalArgumentException: <nulltype> cannot be represented as a Class<?>. My guess is that isType() is returning true when it should be returning false for null types, but I'll need to do more investigation. *** Original change description *** Use ElementVisitor rather than Element#getKind() in MoreElements#isType() ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=280489034
2019-11-13Optimize MoreTypes.nonObjectSuperclassbcorso
This CL tries to avoid using expensive method calls like Elements#getTypeElement, TypeElement#getKind(), and Types#directSupertypes. Of all of these, TypeElement#getKind() had the largest cost because it requires symbol completion. In addition, getKind() was being called on unnecessarily on all supertypes, even though only the first type can possibly be an ElementKind.CLASS. RELNOTES=N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=280196697
2019-11-11Roll forward of CL 264613939: Use ElementVisitor rather than ↵bcorso
Element#getKind() in MoreElements#isType() *** Original change description *** Use ElementVisitor rather than Element#getKind() in MoreElements#isType() Element#getKind() contains more information than is needed here (we just need to know if the element is an instance of TypeElement, not its kind). Element#getKind() forces symbol completion, which requires parsing the class, so we shouldn't use it unless we have... *** ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=279369564
2019-10-22Helper Methods in AnnotationValuesmahsabadian
RELNOTES=Adding helper methods for getting different types of annotation values with AnnotationValueVisitor. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=275921910
2019-10-14Fix 4 ErrorProneStyle findings:clshepherd
* Constructors and methods with the same name should appear sequentially with no other code in between. Please re-order or re-name methods. * These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=274183390
2019-09-23Suppress emitting errors about unprocessed elements when there are already ↵clayb
errors in the processing round. The extra errors don't add any information and end up hiding the real errors. I found this substantially reduced the issue highlighted in b/141176717. RELNOTES=Suppress error noise in `com.google.auto.common.BasicAnnotationProcessor` ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=270454309