Age | Commit message (Collapse) | Author |
|
|
|
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=325291991
|
|
constructor, and rewrite some code to use streams.
RELNOTES=Add javadoc for SuperficialValidation methods.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=323682147
|
|
so it can be used from other internal code.
RELNOTES=Open SuperficialValidation#validateType(TypeMirror) to public visibility
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=323425711
|
|
String-based API.
Context: Per discussion in [] this change adds a String-based `Step` class as a replacement for `ProcessingStep`. The new `Step` contains the same two methods (annotations() & process()) which return and accept fully-qualified annotation names. To support the potential absence of the annotation classes from the processor classpath the corresponding methods were changed to no longer depend on explicit Class types.
RELNOTES=Adding String-based `Step` as a replacement for `ProcessingStep` to BasicAnnotationProcessor. Allows for fully-qualified Annotation names to be specified in a processing Step in order to remove the requirement that implementation processors depend directly on their Annotation classes.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=316968142
|
|
Closes https://github.com/google/auto/pull/831
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=306447364
|
|
(Context: No rush on these reviews. I was just reading through BasicAnnotationProcessor and decided to clean some stuff up.)
Removes some of the duplication between package and type elements in validElements()
RELNOTES=N/A
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=301196168
|
|
In Google's internal java8 compilation environment, problems with symbolic links mean that ecj can't find the standard system classes without this workaround. In other environments, including Google's java11, this problem doesn't arise.
RELNOTES=Make OverridesTest work with Google's internal java8 compilation environment.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=300664328
|
|
This CL reduces some of the conversions between Set<ElementName> and Map<String, ? extends Optional<? extends Element>> where it's not needed.
RELNOTES=N/A
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=300565432
|
|
This CL just does a format fix and applies some error-prone suggestions on BasicAnnotationProcessor.
RELNOTES=N/A
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=299896536
|
|
given type, whether casting Object to that type will elicit an "unchecked" warning from the compiler.
RELNOTES=Added MoreTypes.isConversionFromObjectUnchecked to test whether casting to a type will elicit an "unchecked" compiler warning.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=288896286
|
|
RELNOTES=n/a
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=281521515
|
|
*** Reason for rollback ***
:-( rolling this back again because it breaks some targets.
java.lang.IllegalArgumentException: <nulltype> cannot be represented as a Class<?>.
My guess is that isType() is returning true when it should be returning false for null types, but I'll need to do more investigation.
*** Original change description ***
Use ElementVisitor rather than Element#getKind() in MoreElements#isType()
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=280489034
|
|
This CL tries to avoid using expensive method calls like Elements#getTypeElement, TypeElement#getKind(), and Types#directSupertypes. Of all of these, TypeElement#getKind() had the largest cost because it requires symbol completion. In addition, getKind() was being called on unnecessarily on all supertypes, even though only the first type can possibly be an ElementKind.CLASS.
RELNOTES=N/A
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=280196697
|
|
Element#getKind() in MoreElements#isType()
*** Original change description ***
Use ElementVisitor rather than Element#getKind() in MoreElements#isType()
Element#getKind() contains more information than is needed here (we just need to know if the element is an instance of TypeElement, not its kind). Element#getKind() forces symbol completion, which requires parsing the class, so we shouldn't use it unless we have...
***
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=279369564
|
|
RELNOTES=Adding helper methods for getting different types of annotation values with AnnotationValueVisitor.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=275921910
|
|
* Constructors and methods with the same name should appear sequentially with no other code in between. Please re-order or re-name methods.
* These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=274183390
|
|
errors in the processing round. The extra errors don't add any information and end up hiding the real errors.
I found this substantially reduced the issue highlighted in b/141176717.
RELNOTES=Suppress error noise in `com.google.auto.common.BasicAnnotationProcessor`
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=270454309
|
|
We have required at least Java 8 for compilation for some time now.
TGP: []
RELNOTES=n/a
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=264842791
|
|
Tested:
TAP --sample ran all affected tests and none failed
[]
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=259328073
|
|
This CL adds a new method, MoreElements#getAllMethods(), which returns all local and inherited methods (including static methods), but does not include any methods that have been overridden.
Note: we are still relying on an explicit ordering for static methods to ensure we don't include hidden static methods from super classes.
RELNOTES=Adds MoreElements#getAllMethods(), which returns all local and inherited methods (including static methods), but does not include any methods that have been overridden.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=257649768
|
|
it deliberately.
See [] for more details
#TypeEqualsCleanup
RELNOTES=Suppress TypeEquals check
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=256471146
|
|
We're removing it from open-source Truth, since we're about to permanently commit to the remaining open-source Truth APIs, and we're not sure if assert_().fail(...) offers positive value when assertWithMessage(...).fail() is more in line with normal Truth practices.
MOE_MIGRATED_REVID=254043172
|
|
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=249869914
|
|
The two behave identically, and containsAllOf is being removed.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=245840719
|
|
The two behave identically, and containsAllIn is being removed.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=245837617
|
|
It's released separately from all its children, so any updates we make there don't take effect until we make a release and update the child projects to use that.
This requires pushing various configuration down into the child projects.
Doing so makes the recent attempted update to Truth 0.44 actually take effect.
Also, update Compile-Testing to the newly released version, which actually works with Truth 0.44.
That upgrade exposes that AutoValue was relying on a transitive dependency on Truth8, which was removed in the latest Compile-Testing, so I've added explicit deps.
https://github.com/google/compile-testing/commit/43a513ab14a5b4ab5810a13e14d8cb763546ab5d
Also, I removed an explicit version for compile-testing in the AutoValue functional tests. That explicit version may or may not have been needed before, but it shouldn't be now.
Likely it would make sense to remove more versions explicitly specified elsewhere.
(Additional possible future work: Put deps on other Auto projects (like when AutoService depends on AutoCommon) into <dependencyManagement>.)
Finally, I added some <url> values, since Maven has been generating bogus ones all along (by appending the subproject name to the parent URL, producing URLs something like "https://github.com/google/auto/auto-value").
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=245779060
|
|
(The exact change is slightly different in some cases, like when using custom subjects or check(), but it's always a migration from named(...) to [assert]WithMessage(...).)
named(...) is being removed.
This CL may slightly modify the failure messages produced, but all the old information will still be present.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=245027656
|
|
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=244250754
|
|
ThrowableSubject.hasMessageThat(). This replaces assertions of the form assertThat(e).hasMessage(...) and assertThat(e.getMessage()) with assertThat(e).hasMessageThat().
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=239181584
|
|
And also add asIntersection() since it is now available.
RELNOTES=Added `MoreTypes.asIntersection()`
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=237120983
|
|
RELNOTES=n/a
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=233457151
|
|
RELNOTES=n/a
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=226067929
|
|
versions of the JDK.
RELNOTES=n/a
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=223350143
|
|
non-deprecated replacements.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=223170828
|
|
RELNOTES=N/A
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=222998072
|
|
RELNOTES=n/a
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=219712298
|
|
when there had been deferred elements.
RELNOTES=Fix bug where `ProcessingStep.process(...)` was called with too many elements when there had been deferred elements.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=218513715
|
|
RELNOTES=(auto.common) Add `MoreElements.asTypeParameter()`
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=205449221
|
|
RELNOTES=Add an `overrides()` method to `MoreElements` that is more consistent between javac and ECJ.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=200410431
|
|
RELNOTES=Document MoreTypes.equivalence().
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=189631496
|
|
MoreElements.isAnnotationPresent javadoc. :-)
RELNOTES=n/a
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=187323013
|
|
RELNOTES=N/A
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=185615476
|
|
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=182218347
|
|
RELNOTES=n/a
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=182060148
|
|
This addresses a NPE as dicussed here:
- https://github.com/mojohaus/versions-maven-plugin/issues/51
- https://stackoverflow.com/questions/29995139/maven-versions-maven-plugin-versions-plugin-2-2
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=181663560
|
|
instead of classpath introspection.
RELNOTES=N/A
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=181173931
|
|
internal code to auto-common
RELNOTES=Added `SimpleAnnotationMirror` and `SimpleTypeAnnotationValue` to easily create new `AnnotationMirror`s in code.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=179840730
|
|
annotation to use.
Add JavaPoet-specific utility methods for JavaPoet users.
RELNOTES=Add utility methods for writing `@Generated` annotations.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=178001124
|
|
dependencies and plugins for the functional test poms (which don't use auto-parent).
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=177592315
|