aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Stewart <shs96c@users.noreply.github.com>2022-11-16 13:29:32 -0500
committerGitHub <noreply@github.com>2022-11-16 19:29:32 +0100
commit5bfcb1a684550626ce138fe0fe8f5f702b3764c3 (patch)
treea4b0132d3fc043e99adc0293a90c44cad4d5c19f
parent60abca8fa2f970d4899857a46cb0586338dbf7a1 (diff)
downloadbazel-skylib-5bfcb1a684550626ce138fe0fe8f5f702b3764c3.tar.gz
Stop registering a Go SDK in the Gazelle submodule (#411)
* Do not register a Go toolchain for ourselves This module can be used as a transitive dep, and so we want to avoid forcing users to futz with their SDKs. * Add a small comment
-rw-r--r--gazelle/MODULE.bazel11
1 files changed, 1 insertions, 10 deletions
diff --git a/gazelle/MODULE.bazel b/gazelle/MODULE.bazel
index d997651..4620c08 100644
--- a/gazelle/MODULE.bazel
+++ b/gazelle/MODULE.bazel
@@ -9,16 +9,7 @@ bazel_dep(name = "bazel_skylib", version = "1.3.0")
bazel_dep(name = "gazelle", repo_name = "bazel_gazelle", version = "0.28.0")
bazel_dep(name = "rules_go", repo_name = "io_bazel_rules_go", version = "0.35.0")
-go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk")
-
-go_sdk.download(
- name = "go_sdk",
- version = "1.18",
-)
-
-use_repo(go_sdk, "go_sdk")
-
-register_toolchains("@go_sdk//:all")
+# `rules_go` will register a toolchain for us if the user doesn't do so
go_deps = use_extension("@bazel_gazelle//:extensions.bzl", "go_deps")