diff options
| author | Thomas Van Lenten <thomasvl@google.com> | 2018-04-26 12:08:01 -0400 |
|---|---|---|
| committer | Tony Allevato <tony.allevato@gmail.com> | 2018-04-26 12:08:01 -0400 |
| commit | 2d356cf8574b33d322422c561b6c811187d59a08 (patch) | |
| tree | 4a88bc547ab72495bb14347d8ad34645c5387067 /lib.bzl | |
| parent | 0b40ea7b13ad2a05d09f36680708900aa43b9fa6 (diff) | |
| download | bazel-skylib-2d356cf8574b33d322422c561b6c811187d59a08.tar.gz | |
Doc and code fixes found via skylint. (#38)
* Fix up the skylint warning about depset usage.
* Remove the reassignment of max_bazel_version.
This was flagged by skylint, the reality is _is_at_most() does the parsing
so it shouldn't be parsed before sent on the way.
* Fix up the skylint warning about depset usage.
* Fixup the skylint warning about re-exports.
Just move to the explicit re-export form.
* Fix the fail() call to use the right variable.
skylint flagged this variable as undefined, but it it seems like this
was never right and should have been "key" all along.
* Fixup docstring formatting for skylint.
Diffstat (limited to 'lib.bzl')
| -rw-r--r-- | lib.bzl | 37 |
1 files changed, 26 insertions, 11 deletions
@@ -14,17 +14,32 @@ """Index from which multiple modules can be loaded.""" -load("//lib:collections.bzl", "collections") -load("//lib:dicts.bzl", "dicts") -load("//lib:new_sets.bzl", new_sets="sets") -load("//lib:partial.bzl", "partial") -load("//lib:paths.bzl", "paths") -load("//lib:selects.bzl", "selects") -load("//lib:sets.bzl", "sets") -load("//lib:shell.bzl", "shell") -load("//lib:structs.bzl", "structs") -load("//lib:versions.bzl", "versions") +load("//lib:collections.bzl", _collections="collections") +load("//lib:dicts.bzl", _dicts="dicts") +load("//lib:new_sets.bzl", _new_sets="sets") +load("//lib:partial.bzl", _partial="partial") +load("//lib:paths.bzl", _paths="paths") +load("//lib:selects.bzl", _selects="selects") +load("//lib:sets.bzl", _sets="sets") +load("//lib:shell.bzl", _shell="shell") +load("//lib:structs.bzl", _structs="structs") +load("//lib:versions.bzl", _versions="versions") # The unittest module is treated differently to give more convenient names to # the assert functions, while keeping them in the same .bzl file. -load("//lib:unittest.bzl", "asserts", "unittest") +load("//lib:unittest.bzl", _asserts="asserts", _unittest="unittest") + + +collections = _collections +dicts = _dicts +new_sets = _new_sets +partial = _partial +paths = _paths +selects = _selects +sets = _sets +shell = _shell +structs = _structs +versions = _versions + +asserts = _asserts +unittest = _unittest |