diff options
| author | Julie <30670028+juliexxia@users.noreply.github.com> | 2020-06-24 11:31:57 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-06-24 11:31:57 -0400 |
| commit | b10f2cb0fc013218f727de8c631d6dd1cfc078ea (patch) | |
| tree | 9b3f208256083d9dcf715a81ecc663df8b91b889 /tests | |
| parent | ec2170289f3845a40945e9fbdfed03bddad13a90 (diff) | |
| download | bazel-skylib-b10f2cb0fc013218f727de8c631d6dd1cfc078ea.tar.gz | |
Remove --experimental_build_setting_api usage (#249)
* Remove --experimental_build_setting_api usage
Deprecating this flag so removing all usage.
* One more rm
* fix ,
* Revert semantics flags change
Diffstat (limited to 'tests')
| -rwxr-xr-x | tests/common_settings_test.sh | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tests/common_settings_test.sh b/tests/common_settings_test.sh index 092fab4..531e830 100755 --- a/tests/common_settings_test.sh +++ b/tests/common_settings_test.sh @@ -133,7 +133,7 @@ function test_can_set_flags() { local -r pkg="${FUNCNAME[0]}" create_volcano_pkg "$pkg" - bazel build volcano:mt-st-helens --experimental_build_setting_api --//volcano:height-flag=8366 \ + bazel build volcano:mt-st-helens --//volcano:height-flag=8366 \ --//volcano:active-flag=False --//volcano:namer-flag=puyallup-tribe \ --//volcano:nicknames-flag=volcano-mc-volcanoface \ >"$TEST_log" 2>&1 || fail "Expected test to pass" @@ -148,7 +148,7 @@ function test_cannot_set_settings() { local -r pkg="${FUNCNAME[0]}" create_volcano_pkg "$pkg" - bazel build volcano:mt-st-helens --experimental_build_setting_api --//volcano:height-setting=8366 \ + bazel build volcano:mt-st-helens --//volcano:height-setting=8366 \ >"$TEST_log" 2>&1 && fail "Expected test to fail" || true expect_log "Unrecognized option: //volcano:height-setting" @@ -158,7 +158,7 @@ function test_not_allowed_value() { local -r pkg="${FUNCNAME[0]}" create_volcano_pkg "$pkg" - bazel build volcano:mt-st-helens --experimental_build_setting_api --//volcano:namer-flag=me \ + bazel build volcano:mt-st-helens --//volcano:namer-flag=me \ >"$TEST_log" 2>&1 && fail "Expected test to fail" || true expect_log "Error setting //volcano:namer-flag: invalid value 'me'. Allowed values are" |