diff options
author | c-parsons <cparsons@google.com> | 2019-02-22 17:44:48 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-02-22 17:44:48 -0500 |
commit | a2ec47917b52199de11b737e4197e9fd040b4bfd (patch) | |
tree | d47cdfcb562d19d44e9d296a5ff4248e3e47c730 /tests | |
parent | a35b13a1c9a3d43e81fcfaca42155c53d4b31cb7 (diff) | |
download | bazel-skylib-a2ec47917b52199de11b737e4197e9fd040b4bfd.tar.gz |
fix a number of warnings found by Starlark analyzer (#114)
Diffstat (limited to 'tests')
-rw-r--r-- | tests/unittest_tests.bzl | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/tests/unittest_tests.bzl b/tests/unittest_tests.bzl index 20fd890..01ea4de 100644 --- a/tests/unittest_tests.bzl +++ b/tests/unittest_tests.bzl @@ -69,6 +69,7 @@ def _failure_testing_test(ctx): return analysistest.end(env) def _failure_testing_fake_rule(ctx): + ignore = [ctx] fail("This rule should never work") failure_testing_fake_rule = rule( @@ -92,6 +93,7 @@ def _fail_unexpected_passing_test(ctx): return analysistest.end(env) def _fail_unexpected_passing_fake_rule(ctx): + _ignore = [ctx] return [] fail_unexpected_passing_fake_rule = rule( @@ -168,7 +170,8 @@ def unittest_passing_tests_suite(): Not all tests are included. Some unittest.bzl tests verify a test fails when assertions are not met. Such tests must be run in an e2e shell test. - This suite only includes tests which verify success tests.""" + This suite only includes tests which verify success tests. + """ unittest.suite( "unittest_tests", basic_passing_test, |