go_download_sdk: work around bazel bug extracting .tar.gz files (#1949)

Also, remove or exclude some tests that provide little value.

4 files changed, 2 insertions, 32 deletions

diff --git a/tests/integration/popular_repos/BUILD.bazel b/tests/integration/popular_repos/BUILD.bazel
index 4d000d89..a316ea1c 100644
--- a/tests/integration/popular_repos/BUILD.bazel
+++ b/tests/integration/popular_repos/BUILD.bazel
@@ -161,9 +161,7 @@ test_suite(
         "@org_golang_x_tools//cmd/splitdwarf/internal/macho:go_default_test",
         "@org_golang_x_tools//cmd/tip:go_default_test",
         "@org_golang_x_tools//go/analysis/internal/analysisflags:go_default_test",
-        "@org_golang_x_tools//go/analysis/multichecker:go_default_test",
         "@org_golang_x_tools//go/analysis/passes/tests/testdata/src/divergent:go_default_test",
-        "@org_golang_x_tools//go/analysis/unitchecker:go_default_test",
         "@org_golang_x_tools//go/ast/astutil:go_default_test",
         "@org_golang_x_tools//go/callgraph/static:go_default_test",
         "@org_golang_x_tools//go/cfg:go_default_test",
@@ -216,10 +214,3 @@ test_suite(
         "@org_golang_google_grpc//test/bufconn:go_default_test",
     ],
 )
-
-test_suite(
-    name = "com_github_mattn_go_sqlite3",
-    tests = [
-        "@com_github_mattn_go_sqlite3//:go_default_test",
-    ],
-)
diff --git a/tests/integration/popular_repos/README.rst b/tests/integration/popular_repos/README.rst
index 14e46808..a7507f8c 100644
--- a/tests/integration/popular_repos/README.rst
+++ b/tests/integration/popular_repos/README.rst
@@ -160,9 +160,7 @@ This runs tests from the repository `golang.org/x/tools <https://golang.org/x/to
 * @org_golang_x_tools//cmd/splitdwarf/internal/macho:go_default_test
 * @org_golang_x_tools//cmd/tip:go_default_test
 * @org_golang_x_tools//go/analysis/internal/analysisflags:go_default_test
-* @org_golang_x_tools//go/analysis/multichecker:go_default_test
 * @org_golang_x_tools//go/analysis/passes/tests/testdata/src/divergent:go_default_test
-* @org_golang_x_tools//go/analysis/unitchecker:go_default_test
 * @org_golang_x_tools//go/ast/astutil:go_default_test
 * @org_golang_x_tools//go/callgraph/static:go_default_test
 * @org_golang_x_tools//go/cfg:go_default_test
@@ -216,11 +214,3 @@ This runs tests from the repository `google.golang.org/grpc <https://google.gola
 * @org_golang_google_grpc//test/bufconn:go_default_test
 
 
-com_github_mattn_go_sqlite3
-___________________________
-
-This runs tests from the repository `github.com/mattn/go-sqlite3 <https://github.com/mattn/go-sqlite3>`_
-
-* @com_github_mattn_go_sqlite3//:go_default_test
-
-
diff --git a/tests/integration/popular_repos/popular_repos.bzl b/tests/integration/popular_repos/popular_repos.bzl
index 507edb88..10a2c691 100644
--- a/tests/integration/popular_repos/popular_repos.bzl
+++ b/tests/integration/popular_repos/popular_repos.bzl
@@ -62,9 +62,3 @@ def popular_repos():
         commit = "3f10311ccf076b6b7cba28273df3290d42e60982",
         build_file_proto_mode = "disable",
     )
-    _maybe(
-        go_repository,
-        name = "com_github_mattn_go_sqlite3",
-        importpath = "github.com/mattn/go-sqlite3",
-        commit = "83772a7051f5e30d8e59746a9e43dfa706b72f3b",
-    )
diff --git a/tests/integration/popular_repos/popular_repos.py b/tests/integration/popular_repos/popular_repos.py
index 418b9663..4222ce56 100755
--- a/tests/integration/popular_repos/popular_repos.py
+++ b/tests/integration/popular_repos/popular_repos.py
@@ -143,6 +143,8 @@ POPULAR_REPOS = [
             "go/analysis/passes/pkgfact:go_default_test", # requires go list
             "go/packages/packagestest:go_default_test", # requires build cache
             "go/analysis/internal/facts:go_default_test", # loads test package with go/packages, which probably needs go list
+            "go/analysis/unitchecker:go_default_test", # requires go vet
+            "go/analysis/multichecker:go_default_test", # requires go vet
         ],
     ),
 
@@ -166,13 +168,6 @@ POPULAR_REPOS = [
             "internal/transport:go_default_test", # slow
         ],
     ),
-
-    dict(
-        name = "com_github_mattn_go_sqlite3",
-        importpath = "github.com/mattn/go-sqlite3",
-        commit = "83772a7051f5e30d8e59746a9e43dfa706b72f3b",
-        excludes = [],
-    ),
   ]
 
 COPYRIGHT_HEADER = """