summaryrefslogtreecommitdiff
path: root/tests/zip/BUILD
diff options
context:
space:
mode:
authoraiuto <aiuto@google.com>2022-03-07 13:29:12 -0500
committerGitHub <noreply@github.com>2022-03-07 13:29:12 -0500
commitb710cacf88e17c15e7f01e25b51e60610906885d (patch)
tree4e3af7437aaffc29744875f5704a6d8d72660c72 /tests/zip/BUILD
parentca16bbaaf0a4b61d7ba212dc263fc1e3f255e47e (diff)
downloadbazelbuild-rules_pkg-b710cacf88e17c15e7f01e25b51e60610906885d.tar.gz
Get rid of the long deprecated archive_name and extension from pkg_zip. (#552)
- Make 'out' work in a reasonable way. Fixes #414 - Partial fix for #284
Diffstat (limited to 'tests/zip/BUILD')
-rw-r--r--tests/zip/BUILD25
1 files changed, 21 insertions, 4 deletions
diff --git a/tests/zip/BUILD b/tests/zip/BUILD
index 414a85f..f892df2 100644
--- a/tests/zip/BUILD
+++ b/tests/zip/BUILD
@@ -79,9 +79,14 @@ pkg_zip(
# The contents of this file should equal test_zip_empty
pkg_zip(
- name = "test_zip_empty_different_extension",
- srcs = [],
- extension = "otherkindofzip",
+ name = "test_zip_basic_renamed",
+ srcs = [
+ ":dirs",
+ ":link",
+ "//tests:testdata/hello.txt",
+ "//tests:testdata/loremipsum.txt",
+ ],
+ package_file_name = "test_zip_basic_renamed.foo",
)
pkg_zip(
@@ -95,6 +100,15 @@ pkg_zip(
)
pkg_zip(
+ name = "test_zip_out",
+ srcs = [
+ "//tests:testdata/hello.txt",
+ "//tests:testdata/loremipsum.txt",
+ ],
+ out = "test_zip_out.foo",
+)
+
+pkg_zip(
name = "test_zip_timestamp",
srcs = [
"//tests:testdata/hello.txt",
@@ -187,6 +201,10 @@ py_test(
data = [
"test_zip_empty.zip",
"test_zip_basic.zip",
+ "test_zip_basic_renamed",
+ # We do not actually use this file, we just want to make sure we build
+ # it with this name.
+ "test_zip_out.foo",
"test_zip_package_dir0.zip",
"test_zip_timestamp.zip",
"test_zip_permissions.zip",
@@ -197,7 +215,6 @@ py_test(
# these could be replaced with diff_test() rules (from skylib)
"test_zip_basic_timestamp_before_epoch.zip",
- "test_zip_empty_different_extension.otherkindofzip",
"test_zip_package_dir1.zip",
"test_zip_package_dir2.zip",
],