diff options
| author | Chris Love <335402+chrislovecnm@users.noreply.github.com> | 2023-05-31 19:48:28 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-01 01:48:28 +0000 |
| commit | 148622aa92fdd5afcaf9f153d7bb6afce713e553 (patch) | |
| tree | 548ec4f8e351edbc8d447765be090bc32040ee77 /BZLMOD_SUPPORT.md | |
| parent | 18a7bb5b506538835c75d46d4245da08fa695df3 (diff) | |
| download | bazelbuild-rules_python-148622aa92fdd5afcaf9f153d7bb6afce713e553.tar.gz | |
feat(bzlmod): Moving register.toolchains internal (#1238)
This commit moves the register.toolchains bzlmod call to inside
of rules_python. Instead of a user having to call register.toolchains
in their MODULE.bazel, rules_python/MODULE.bazel calls it
on the internal hub.
This is a breaking change if you are using register.toolchains inside
of submodules. Using register.toolchains inside of submodules is
not recommended anyways. This is now broken because we are not
creating a repo for every Python version toolchain. All of the
toochain calls exist now in the hub's repo BUILD.bazel file.
Diffstat (limited to 'BZLMOD_SUPPORT.md')
| -rw-r--r-- | BZLMOD_SUPPORT.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/BZLMOD_SUPPORT.md b/BZLMOD_SUPPORT.md index cf95d12..8efd0df 100644 --- a/BZLMOD_SUPPORT.md +++ b/BZLMOD_SUPPORT.md @@ -31,7 +31,7 @@ A second example, in [examples/bzlmod_build_file_generation](examples/bzlmod_bui This rule set does not have full feature partity with the older `WORKSPACE` type configuration: -1. Multiple python versions are not yet supported, as demonstrated in [this](examples/multi_python_versions) example. +1. Multiple pip extensions are not yet supported, as demonstrated in [this](examples/multi_python_versions) example. 2. Gazelle does not support finding deps in sub-modules. For instance we can have a dep like ` "@our_other_module//other_module/pkg:lib",` in a `py_test` definition. Check ["issues"](/bazelbuild/rules_python/issues) for an up to date list. |