summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlex Klyubin <klyubin@google.com>2016-04-04 14:06:10 -0700
committerAlex Klyubin <klyubin@google.com>2016-04-04 14:06:10 -0700
commit9d32ea951d7fa2dd37497b539b513a9e614824f2 (patch)
treebf2e034eb5af51dbcfd402ff0d8a826ab6b06070
parentd299a6be6575f39f559481b80c9d0b6636f47c20 (diff)
downloadbouncycastle-9d32ea951d7fa2dd37497b539b513a9e614824f2.tar.gz
Permit arbitrary DSA keys when verifying signatures.
This is a follow-up to 867b6e16a13ab7a83cdf9b6f83249ccbf80b552c which modified JCA DSA Signature implementation to reject keys which don't use sensible parameters. Unfortunately, that commit was too strict and rejected keys not just when signing, but also when verifying. For backwards compatibility reasons this commit removes the checks from signature verification logic. Keys that don't use sensible parameters are still rejected during attempts to produce new signatures. Bug: 24082558 Bug: 27947262 Change-Id: I2e1f76dc56c15c25000b70063428d460854e7b57
-rw-r--r--bcprov/src/main/java/org/bouncycastle/jcajce/provider/asymmetric/dsa/DSASigner.java4
1 files changed, 0 insertions, 4 deletions
diff --git a/bcprov/src/main/java/org/bouncycastle/jcajce/provider/asymmetric/dsa/DSASigner.java b/bcprov/src/main/java/org/bouncycastle/jcajce/provider/asymmetric/dsa/DSASigner.java
index 2c4900f1..fead55dd 100644
--- a/bcprov/src/main/java/org/bouncycastle/jcajce/provider/asymmetric/dsa/DSASigner.java
+++ b/bcprov/src/main/java/org/bouncycastle/jcajce/provider/asymmetric/dsa/DSASigner.java
@@ -90,10 +90,6 @@ public class DSASigner
throw new InvalidKeyException("can't recognise key type in DSA based signer");
}
}
- // BEGIN android-added
- DSAParameters dsaParam = ((DSAKeyParameters) param).getParameters();
- checkKey(dsaParam);
- // END android-added
digest.reset();
signer.init(false, param);